From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6917993065941565440 X-Received: by 2002:a17:906:2694:: with SMTP id t20mr76810ejc.48.1610981531541; Mon, 18 Jan 2021 06:52:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:220e:: with SMTP id cq14ls162232edb.2.gmail; Mon, 18 Jan 2021 06:52:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5dsl5ZadWv4Kohk0a/SxESKfRr1nMpW5mV33E869p7iQTWlT9Pfy0jgPTwF6ffsyIf8Rz X-Received: by 2002:a05:6402:17cb:: with SMTP id s11mr19018029edy.119.1610981530561; Mon, 18 Jan 2021 06:52:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1610981530; cv=pass; d=google.com; s=arc-20160816; b=yJZcFT/wV+3UoL5TlvwqpCj9ox3dneP+TkwiKbBR6DA0WB63RYiZWyvON1e+KbyDOn aWkp0uSLywcNwJUabMIM1UookgiudnpHTbmaCXt2QoqL5c2tPlWYCgid8IDXp8xezHdG Yh+MFGUuOJqAzUgfPj3hXr9j0p468eWN2fImNHJc9+J2UgoN9SRhJO/wkNFh7mUVl7b5 rRlNUr4vmGazfkK7ZxJFGn9NI1YxQMPH8dqS8gWWeXOlOzEr3VaNPSYod//WbDaS4jyd RqvKWV4ykTPRmagfBuRG5/nJmOpXj2mxf6OWxjHpL+9CSnk6GRgL3Xqg58z1a0B1Mnp0 1Y9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-language:content-transfer-encoding:in-reply-to :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=lp4ReY1TEKKc4o8W8qNNIEZtwhQepb/hfjkxn2si2g4=; b=eSSXVHCmFUOJ5vw/ExS/XgpKGIt23pBtmszaOBUP/cGs5wfqDH7BiApzP0EXRcxjmG rtSkNpqabATjGXcfrSwJ4PSJ/2kCJUbEX5Ka9EQHuWKEi6QlXCBBn73m7ZehYdOXas7r 2YPC4+cXxfEAckS1BCajpSAo+5rxfjQHRUm2XeDOmPGA//SO9a0gfeEflB8Y7XR3/U9F oG/BaSKW8qpOohjx+ehjE3pZc+4Nj6HCZZWHaQVOeaYG8ZdAsWdS7hkoyrHaKECQAZWt CfcDmbnOramCXCIREOVEPfKmLKJbrk/jusgWSVRXG4exJDMEm+ClCOT13PIvauh/5CMY ItDg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="T/q1NmW7"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.81 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30081.outbound.protection.outlook.com. [40.107.3.81]) by gmr-mx.google.com with ESMTPS id k20si674401edx.3.2021.01.18.06.52.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2021 06:52:10 -0800 (PST) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.81 as permitted sender) client-ip=40.107.3.81; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="T/q1NmW7"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.81 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MlLYxTpgirPCWYUrB7ch6ANb4uktPZa7HM2cTDcJPzgLxktFVGsLe7bLe3Nr1s7RNhaK9NvN7f1qia8fbJvO9+I7hUW8WZu311URfpwXUfNtbRwwoXv6i4H9Ya99JxtnUdHhL4MC4jvuy0cFMzastNKaXg1f8jFNPq09PuLC3tJwm2R4t2WXtMJE74brZYlTFWYmuOxHSCw6YossS+vpJHDaPOBqmgJxKLRdRZrjSKpfpW+Bc4ICn2YuuK6uNpYuUX2d868AV3M1yxPlaooBvOaFJvJhky+iHD11l6g1uHGftOYCZM/Tldc+vV2KB4+gklS5EC6cPTX7Ojf04O77VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lp4ReY1TEKKc4o8W8qNNIEZtwhQepb/hfjkxn2si2g4=; b=ha64vHpoeGM8lO5HqmzEB7YpJHJ0UG1e4bJjBt05BdrxLySIxR6IUt1dBzi0oF7y5c5GtccYV3A0gdvvvD+7eoYZe01BGeIFAk6nQ+Nc1z2kaHtAP7ezfOBruFrUR26XejpvdU0bglyg+JNVBkvFCjXZP53zPRt2QmymotKkCH42EKsS1+wf+Bwsdu1YT1cNvC9lHPWKl4LQlRl0ukrDVF7fXjJT8OWuYeDNAZqCc0jDcXqjwwLHhjk3jw3zzjQvXlhWWOs2sw8XaoFX+OOCjqutKKQD/BjT89oBZVm+5cBQiz57CUkWFDO133A8UB1CGOHDttBkD7L2hJ5J5oPPUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lp4ReY1TEKKc4o8W8qNNIEZtwhQepb/hfjkxn2si2g4=; b=T/q1NmW7sWqb7YyMYkuxUPwUGq3EFMT89BEtfqCbmtxdW0lpNayxGXyTMxh3PL/8EeMx0g9Ig5HN+TYOfC2tNjvnY59I8izZ+XsZdvWkhj74seeKVtZIXEjGqLVOXpguM3d4A3uZ/ClImOpeizU7oOeDWq1jAxXGbfoRCFFdEh0= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) by AM0PR10MB2466.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:d6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9; Mon, 18 Jan 2021 14:52:09 +0000 Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::c035:62d1:fd79:1bc8]) by AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::c035:62d1:fd79:1bc8%5]) with mapi id 15.20.3742.012; Mon, 18 Jan 2021 14:52:09 +0000 Subject: Re: image-postproc-extension.bbclass modifying /etc/os-release To: Claudius Heine , isar-users@googlegroups.com References: <67e1fac9-5af5-29aa-de57-9a0de0cdd165@siemens.com> <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> From: Silvano Cirujano Cuesta Message-ID: <00243e87-2d72-8870-de86-4e5a8214b764@siemens.com> Date: Mon, 18 Jan 2021 15:52:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d] X-ClientProxiedBy: BL1PR13CA0182.namprd13.prod.outlook.com (2603:10b6:208:2be::7) To AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d] (2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d) by BL1PR13CA0182.namprd13.prod.outlook.com (2603:10b6:208:2be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.10 via Frontend Transport; Mon, 18 Jan 2021 14:52:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 35beac13-980f-4517-0657-08d8bbc0a114 X-MS-TrafficTypeDiagnostic: AM0PR10MB2466: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BJlRQxWvFcxuMjk4fR6Id/prJO7X0+RUg45WCgwSboBdGewjF+Si2X+JfFk0FRgchXuMPN8bAiWyl9Fh/0Npn3jrzceziy2P20f6sTaDETUc0EdYESRwt8e15DoiAa5nNbsPTByhyBcVKnSBKNu69nJ3NHVi/tvUUMMIp5fG9F3iCekg5kAtxODHFw+OMTy9BGEP0dMFB2CWiPSy6OoY1XirShjHwumRhkN0q6HqgThjGFyoHIWAR7WpCnjLqwtUyx/P5HLT9T3MfPoeVqUpp5SawWFf1TESiIHxpgB8OQ5CXC2Z2wx53pw4BlSqmMs01wVd8FPcCqf8KMzZ1qU8rr+3Fdwq7dwZZiUlUru+U0VxtzxPj6gQy+E4r7xVL3CK+AObuPuOAvDZNE1fyY0PsFhPtcE3FmnGc4SfxwL6eB9HX6CjLQN3AzYfViOunTwuI7PoBjzBB8nKLD7jgwfs+SRrwV2+iDLRHsMst7hb40Vf+QahOXWulbzK7E5BmbAqEhGdOUue9oDwrp6vUJzijYQpLZhpXE5cpfLeppo8BTe6HdNNzByj9N4Iof1O/+j6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(966005)(478600001)(31696002)(8676002)(86362001)(2616005)(31686004)(66946007)(66556008)(53546011)(316002)(45080400002)(36756003)(6486002)(66476007)(8936002)(186003)(16526019)(6666004)(2906002)(83380400001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bzVPUnZ2TkNGOG5YYkV5RnBkTTNoUE5kT241MkFwcUR5V2xsQm4rNGF6c2Rx?= =?utf-8?B?ZTNFUncxNEZVZUpEcEZGQXBKRWJZbmlJK1M1bkJPRDRkNzh6Q3Z4ejBLdFlG?= =?utf-8?B?dXJNR3NZVTdOa2pTdDJqVHo0bVhTUUFRWWFBVndmRmQ1SUVtS0RBQ20xZ2lB?= =?utf-8?B?N1RiNnNneE5wa2k0TUJTYXp6TW90R1VVOGFYYUVxcFdxRVNZeFZ5blg4dHYr?= =?utf-8?B?K1Z2Uytza3UwZnNDV3UwZUhkTkRTZnN3U3ZndHp5c25Qa0JMWjc4cDNzK3hM?= =?utf-8?B?ZkNjaGkzRDN2ai81V0Urd2Q2eTJld0J6MHF6cGJ4ZjdzOXNrd1VuRTJZanhx?= =?utf-8?B?NXpkK3dJTWY3a2JEWFV2Ukd6SkN1ak1rNTk3NngvQ01Zd1IyNlJpSFlNVTBr?= =?utf-8?B?ZmhGTmg2ZXRvV0VYci9reVJSRzBHMTlKWlVKckoxUnZMcEZGalhPQnpuclNQ?= =?utf-8?B?bCtDSTN6OGhPRnRCZzEzcHNGdkNNL0duK1RpaXdaMkU2TGM2bkQ4VzdTcHV6?= =?utf-8?B?bVZYMnJpZys4U2tveHl2SnhqWkJ1eVc2WFBaSHd2SGg0T3phVWZmOWh6YUlh?= =?utf-8?B?YWFEbGx3dVZqRjRMZGRqUU0rdCthV1ZDUlJVcENKWDJaU3cyV20vcFdPL1JZ?= =?utf-8?B?d2c0cWxGV3BmaG9oa1ZuRzNnbmw5YWlPbEF4dW9tNU9MdWFFRWlEcmdWQlNx?= =?utf-8?B?bGxycmMxNG1uVEtIcWV5bVRScmNzV1R3eXNBaXRpUzVMQm1NTnR6UGZia0dC?= =?utf-8?B?RU5wbUxmRUc1enRTT0hGazZsQWxqSEE3M0czaG4rNXpBVDRUbGFIRENXRG5I?= =?utf-8?B?K2NrcDFrR2dIQW5ZdDJvQ0lPVWJ2bTJDNFNxTXN3bnhNMGxkbElyOG1na2FI?= =?utf-8?B?bklRdFhkMkxETC91aFRRQ0RRUW5qZTV0dzgwQld0Z2lleTVPZW90OVJpRnh0?= =?utf-8?B?eFlqaXdZbGtNUFFVb0UvZkJweGZ2MzcvaEt6TFR1VGdDRUdIYlRpekVWVmFm?= =?utf-8?B?emdxRmhkSUR6VG9DSFNvWitHck5ENFlqYWltdi9xTUcxQ2xYc1NXcUxieFFS?= =?utf-8?B?US9vZWI0SXphNHRSRk1IakxOT3lSYk12cDhqUm9ITmg0L2dPZGhnd3Q3R3gx?= =?utf-8?B?Q0Y4V2NmSzVpOE5UUENXUXZBNnVtMEI5eE9zNEd0YkdHc1Q3enQ3dFJTWUdC?= =?utf-8?B?U0tLeHFZYlhPUHUyWWxlcUh5bHVvM0tXU1NCbDNZMHc2QXFoZXdIV0hmRjV0?= =?utf-8?B?b09OWndJSjF0MlJjekhQU3NBai8wNXlpU3RwNzBXQUF2U1NsR25SK0tWdEdG?= =?utf-8?B?M2h3OEpkZU1LMHN2Yyt1WVhsQlF1S0wySm9jTFNGeE5Ic0FmMEJOeEx0dmNa?= =?utf-8?B?Wmp3SnRDeWRveFZ2UmVNZ0FmOWVoMXlXa2VieHRibTAyTzR5aEd1TmxyM0VY?= =?utf-8?Q?Th0jeJ5T?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35beac13-980f-4517-0657-08d8bbc0a114 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2021 14:52:09.2739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fM4OG8Uea8bNfxpdkm7vlhwoqK2tNLuSuXU1plFkqRWA+vAMnlTmIkCddu3OoBHbOMXWmg4kR/0QZkJ3Aw68jd/hnzsFG3kbkH5gL6maHplOyHyWXdR/c/te2qW3+By0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2466 X-TUID: uKKK4PJwawKv I've tested it right now with the Qemu AMD64 image: 1. Modified it so that /etc/os-release has "my information". 2. Confirmed that /etc/os-release in the VM has "my information". 3. Made the current 'base-files' upstream package [1] available to the VM (additional disk, editing the generated image,...). 4. Installed the current 'base-files' upstream package. 5. Confirmed that "my" /etc/os-release has been silently replaced by a symlink to /usr/lib/os-release. Anybody not doing package updates on 'base-files' won't notice anything, but the bug will still be there. Only covered by a convention, uncover it and it'll bite you... Please convince me :-) that it's not a bug or that there are no realistic scenarios where it can be triggered... if not I'll contribute a fix.   Silvano [1] http://ftp.de.debian.org/debian/pool/main/b/base-files/base-files_10.3+deb10u7_amd64.deb On 18/01/2021 13:35, Claudius Heine wrote: > Hi Silvano, > > On 2021-01-18 12:35, Silvano Cirujano Cuesta wrote: >> I might try to provide a fix, if we agree that the current implementation has an issue. >> >> @Claudius: you wrote the original code [1]. Do you remember why you implemented it this way? Do you remember if you were aware of the issue I mentioned and you provided a mitigation for the issue that I see (assuming my analysis is right)? >> >> [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Filbers%2Fisar%2Fcommit%2F13ce96e5bc84b60f2fa7ccfe93dde045461884e6&data=04%7C01%7Csilvano.cirujano-cuesta%40siemens.com%7C0bf1a83dda684b9e03e408d8bbad9a58%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637465701582684886%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=rRq%2F%2BKNrHdUn1SV%2FxVTIOSH6BofosIhUrFZWyy5PmSc%3D&reserved=0 >> >>    Silvano >> >> On 15/01/2021 15:26, [ext] Silvano Cirujano Cuesta wrote: >>> Hi, >>> >>> I've noticed that '/etc/os-release' is being changed on the image in meta/classes/image-postproc-extension.bbclass [1].  What BTW ends up changing '/usr/lib/os-release', since it's only a symlink. But both '/etc/os-release' and '/usr/lib/os-release' are owned by 'base-files'... >>> >>> An upgrade of 'base-files' would be replacing (silently, since is not marked as a configuration file) '/usr/lib/os-release' with the version of the upstream 'base-files' package and possibly breaking any tools in the system relying on certain values in that file. >>> >>> Is there a reason that I'm missing for doing so instead of the Debian-way (file diversion with dpkg-divert)? Or any hack that I've overseen that avoids the mentioned breakage? > > Interesting, I didn't remember that `/etc/os-release` is a symlink, could that be something that has changed in more recent debian versions? > > If so then, of course that needs to be fixed. > > regards, > Claudius