From: Jan Kiszka <jan.kiszka@siemens.com>
To: Henning Schild <henning.schild@siemens.com>,
Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: isar-users@googlegroups.com, venkata.pyla@toshiba-tsip.com
Subject: Re: [PATCH 3/3] deb_add_changelog: use SOURCE_DATE_EPOCH
Date: Mon, 9 Jan 2023 11:30:17 +0100 [thread overview]
Message-ID: <009d07d2-a7c5-1ed5-8b32-125f2cd595a7@siemens.com> (raw)
In-Reply-To: <20230109102526.313c2082@md1za8fc.ad001.siemens.net>
On 09.01.23 10:25, Henning Schild wrote:
> Am Mon, 9 Jan 2023 05:14:28 +0000
> schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
>
>> In case the SOURCE_DATE_EPOCH bb variable is set, use that value
>> both for the auto-generated changelog as well as when appending to
>> an existing changelog.
>
> The variable SOURCE_DATE_EPOCH does not make it into the build
> environment and it very likely should not because the overall value for
> a single image must not be used for all packages. So we can not and
> should not use it. For a package the sane value would likely be the
> newest changelog entry ... like we try and do already.
No, SOURCE_DATE_EPOCH will be a global variable in the end, for all
recipes (that can/want to make use of it).
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
next prev parent reply other threads:[~2023-01-09 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 5:14 [PATCH 0/3] Fix reproducability issues in deb_add_changelog Felix Moessbauer
2023-01-09 5:14 ` [PATCH 1/3] make deb_add_changelog idempotent Felix Moessbauer
2023-01-09 9:19 ` Henning Schild
2023-01-09 10:42 ` Moessbauer, Felix
2023-01-09 5:14 ` [PATCH 2/3] deb_add_changelog: set timestamp to valid epoch Felix Moessbauer
2023-01-09 5:14 ` [PATCH 3/3] deb_add_changelog: use SOURCE_DATE_EPOCH Felix Moessbauer
2023-01-09 5:34 ` Jan Kiszka
2023-01-09 9:25 ` Henning Schild
2023-01-09 10:24 ` Moessbauer, Felix
2023-01-09 10:30 ` Jan Kiszka [this message]
2023-01-09 9:28 ` [PATCH 0/3] Fix reproducability issues in deb_add_changelog Henning Schild
2023-01-09 10:33 ` Moessbauer, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009d07d2-a7c5-1ed5-8b32-125f2cd595a7@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=venkata.pyla@toshiba-tsip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox