From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 26 Nov 2025 11:03:53 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f58.google.com (mail-ed1-f58.google.com [209.85.208.58]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5AQA3qf5011269 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Nov 2025 11:03:52 +0100 Received: by mail-ed1-f58.google.com with SMTP id 4fb4d7f45d1cf-64160e4d78esf6513736a12.0 for ; Wed, 26 Nov 2025 02:03:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1764151427; cv=pass; d=google.com; s=arc-20240605; b=O481b+d8qwS2gTKpnMEp0V2mzVZC/JHI/22fA8xtX3eoGmYNJMeswpA+JYNOlX2j5f YDYWyNssNO+zyEdi8DEddcHbeIKzJXlQb9ZD99dzfRBgTd3OMMbnKlnmysVYYBc9Gtzz IMlu8vrT9vprBMArfSIBJ3sbmukbVG95NYiTg+lsn8R4MDwikxY1U4aMa0pogjYSYAX4 N5cOLBS/zu5KUr/yZVeEeYEmnH1iEcEDdaxnJq3z9s++LaF7OMPdkwwocwjjGu2q/zwP rHzYZ16065TXhIjuAZ4eNAio3oN3NtFlvTbWOSU/c/touQXQLHOxNTzBiO1Flwd2nTf6 TGYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=nMGI5EMbVodFTthMYyyUBjrjEILAsPUi+Vg2OsYVnC0=; fh=kaOVh3P4OBHjLbDN8QGusPVNYN/7wYBdh2EjD8sPXs4=; b=bWegW6Be41m6jvC79/mHoR5GwqouJQ1v09TQnzvYqbacmMcFJXVyUyw2LDH9EhAd+5 cgapM3q3gyhMhaQG030PBw7sYbnssFPkErnXxphsypTyU1BqmiqHZ4sWZ2Gj5w7vh0MS qPjZJXxAY0CRqtpiKdwdVIASJWJSPMQrA9QqVAop8TmySIm/ddPSrSK3K+odX8KoYiEc HyhDczQhqoGIQEk5lNzjgud2V8r52ZIUA40vdklWTg8lBNZ4cbSRoPrX42BT0BG0lY+C WkQDie2hcV1GER3828kVilbfgEnaL5rE6BmLf0YSQp663FpEMDvWqpfmHgUAMrm/SFlP ACWg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1764151427; x=1764756227; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:cc :to:subject:user-agent:mime-version:date:message-id:sender:from:to :cc:subject:date:message-id:reply-to; bh=nMGI5EMbVodFTthMYyyUBjrjEILAsPUi+Vg2OsYVnC0=; b=AzSLbp4elg5mYvvzsxfdVI+309P+LHg43m3LuglsnfPmF2GdMK4YZEaQLM1G/QR9Qy t4uexoJyADYhg/mofUwrvjTMX9Bvnc7YhZQdGkN0Rl/xFtnbHS3Nc/0acguM4re8O4IV qXJ7ybZNKycMuRH3gQTVBJqQYJlUdNazPJokLEqklSCNBv7RkkAbOAqC1DswaLk3Ovve ZXCl+QeKox0DLxTWTKWTmKIr1RPKlyxeb5l3TLL7BHWeLE8+rsNcEfVjwtw3hJhHAPad Tpcc9vcI3eEqxwjheBz/8QTXeIxGmUntkUnPQ1Kez45NVr+0bLneH4XTUE+cvhqyUs7l vgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764151427; x=1764756227; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to; bh=nMGI5EMbVodFTthMYyyUBjrjEILAsPUi+Vg2OsYVnC0=; b=HQaitbZfG00xtqbSTbP4BqB0fWgRKwy3+Tx9fdCRwVA+Yie/RemzAgBASitpVv6VjC doG9l4neMzfAf7eZZV6gmSkqp0gddEdsq9RAAvMR/ysrrAB8ufl2H0Y0HG9tGLLJmsnZ dhAlS1n7xboXF1+dluCXKCx/YgLddX4UbgTJRhviZ/c6k/DkJLBBnkz2ixBDjNcHC1k2 7zliCr9xslQQ/oXgnBR42uxKM3z2at/FmoLCrwKWCnsS2aix/OVnP9zvWF7qH49zmGPv dNPdaSdp/4ud2jqQVPxba/NZd7oqQZ/sfR7MDaR183O/F5qhu7lKZSkTk+S9PXSTxr8w esUA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCV/smXYff/YUJPVUylOwrkvRcLzPR8gUk6wVx8sTw/642pyWx/rru3B3h7ZoPxS2B1297RP@ilbers.de X-Gm-Message-State: AOJu0YwPj1Xxvu3+2IzopQa0wrQyGWxkhADrVywX0h2TJkxyfVo+VzmT z4fAbwfKKRskJg4spt75eofsTDtZq0wj/gT9yY9oyXRKe3ZJnHO+9wwe X-Google-Smtp-Source: AGHT+IGDuFRYLkVj0nlJAcATkEsrB/ma9wWIXOfOS2cEA+TBXYhLyX5XJGgMA7rlGFlfE9KDG9pU5g== X-Received: by 2002:a05:6402:5248:b0:640:c3c4:45fd with SMTP id 4fb4d7f45d1cf-645eb213a19mr5175424a12.5.1764151426698; Wed, 26 Nov 2025 02:03:46 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+Ztj13yNxzd9bs5HnVvR4UJCudLrDDJL+NqwNH0fdfwEg==" Received: by 2002:aa7:cd67:0:b0:641:8d41:d6f5 with SMTP id 4fb4d7f45d1cf-6453640efd6ls5512388a12.2.-pod-prod-09-eu; Wed, 26 Nov 2025 02:03:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWYBNFrbI6gef3dX26jZI4n9Mb1rX6b9XUG7NZwjfAp727Dr40/AjQdg2dQVtWDNCqyWINGniO6eKNw@googlegroups.com X-Received: by 2002:a17:907:9706:b0:b72:7cc6:a143 with SMTP id a640c23a62f3a-b76c555cbfcmr661908966b.40.1764151423974; Wed, 26 Nov 2025 02:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1764151423; cv=none; d=google.com; s=arc-20240605; b=U0kRs9D0Hqr2JqjxoW2VTFPgVFb0zuxd5bt0jQ4kzAv4wz7mzxNIcyX5BfoB3kw/qF fnFkr73sHVDTC7/cUEDu3t5WN6cZl+IA8Afy0HYlXUBqtOTK092nMd1oZrrZnkDrxgxh D3IkyqRWToCNUU33IQ9bvp5bBNp+8udnCE2561yERv20woCx84xaggq0zweRUCfhP1hk vqYGlU4rXT2KE1bBsoeIx4vTaY7lpKGtqnv4qduY+prlXFpyw8ujCwFJEzdfVwJ4nLWZ M2RKCFBrvtxUIr637SN3MD0+iIq13nQqVVJi3j8ZKdi0iyKlHaqxAUaW+Vybr8amA+DU Gj/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=kzq1Tnw/OgqeaBcZEdqJvpiMfSFqSPHr6Jn/v3AOPbE=; fh=yh/P14EI+nWamgYtN10p0Fx7ppY1c4O8HL8e4BFyxkA=; b=ISLYSYoPMrjRsdhRo870TQjtuKRDIdKgsL3ShPPuKi/UEOpDO+XheA6RXUGGl2aaoL He/WNmJKhgN3cwkRUIdd8opu19plqqL7sgeT0No5ZYvKEOEOMNZIMOSki25v7lDGcMO/ D67WxpT2N3PT9SfMnMBaFeMyuA5KyhuI/rOQ5lRY/0hgU/So6MMLoyBf2n6nKPaLLTn8 m9tEp0ird/rJykA5Cl+ZWgoL1yo+CAQ2bfa9lR+Fkzi/kHanXVatjW8Hpefk/P2LyxQR QwPdlIdOCoky/0c4Ag3ECy1LXGUzcOOuTB8qbHzhnlU00E8qVnhzss6vxGnZIUHtODRJ yciw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a640c23a62f3a-b76550f23b9si31761966b.4.2025.11.26.02.03.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Nov 2025 02:03:43 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5AQA3csR011258 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Nov 2025 11:03:38 +0100 Message-ID: <00b287b5-4842-44e8-bb26-b8457697a77b@ilbers.de> Date: Wed, 26 Nov 2025 11:03:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] image: Fix variable dependency chain To: Jan Kiszka , isar-users Cc: "Schmidt, Adriaan" References: <4b35158b-a117-41d5-bf9b-5ff06c756b7a@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <4b35158b-a117-41d5-bf9b-5ff06c756b7a@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: WmO6I2aW5upo Applied to next, thanks. On 11/23/25 19:30, 'Jan Kiszka' via isar-users wrote: > From: Jan Kiszka > > As ROOTFS_PACKAGES is constructed from IMAGE_INSTALL or SDK_INSTALL via > an inline python function, we need to help its consumer > do_rootfs_install with maintaining its variable dependency chain. > > The issue was easy to trigger by rebuilding an image after switching > between different distro kernels. > > Instead of adding another do_rootfs_install[vardeps] rule to users of > rootfs, introduce the ROOTFS_VARDEPS variable which can be defined by > class users according to their ROOTFS_PACKAGES construction. > > Fixes: c63bb31b6f3a ("add multiarch support") > Signed-off-by: Jan Kiszka > --- > meta/classes/image.bbclass | 1 + > meta/classes/rootfs.bbclass | 3 ++- > meta/classes/sdk.bbclass | 5 +---- > 3 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 1fa71c17..d11dbee5 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -101,6 +101,7 @@ ROOTFS_FEATURES += "\ > populate-systemd-preset \ > " > ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${@isar_multiarch_packages('IMAGE_INSTALL', d)}" > +ROOTFS_VARDEPS += "IMAGE_INSTALL" > ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > ROOTFS_PACKAGE_SUFFIX ?= "${PN}-${DISTRO}-${MACHINE}" > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index e1179e61..748ed034 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -18,6 +18,7 @@ def initramfs_generator_cmdline(d): > return "update-initramfs -u -v -k \"$kernel_version\"" > > ROOTFS_PACKAGES ?= "" > +ROOTFS_VARDEPS ?= "" > ROOTFS_INITRAMFS_GENERATOR_CMD = "${@ d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMDLINE').split()[0]}" > ROOTFS_INITRAMFS_GENERATOR_CMDLINE = "${@ initramfs_generator_cmdline(d)}" > ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}" > @@ -384,7 +385,7 @@ rootfs_clear_initrd_symlinks() { > } > > do_rootfs_install[root_cleandirs] = "${ROOTFSDIR}" > -do_rootfs_install[vardeps] += "${ROOTFS_CONFIGURE_COMMAND} ${ROOTFS_INSTALL_COMMAND}" > +do_rootfs_install[vardeps] += "${ROOTFS_CONFIGURE_COMMAND} ${ROOTFS_INSTALL_COMMAND} ${ROOTFS_VARDEPS}" > do_rootfs_install[vardepsexclude] += "IMAGE_ROOTFS" > do_rootfs_install[depends] = "bootstrap-${@'target' if d.getVar('ROOTFS_ARCH') == d.getVar('DISTRO_ARCH') else 'host'}:do_build" > do_rootfs_install[recrdeptask] = "do_deploy_deb" > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass > index 46436d97..5933b52a 100644 > --- a/meta/classes/sdk.bbclass > +++ b/meta/classes/sdk.bbclass > @@ -55,6 +55,7 @@ def get_rootfs_distro(d): > ROOTFS_ARCH:class-sdk = "${HOST_ARCH}" > ROOTFS_DISTRO:class-sdk = "${@get_rootfs_distro(d)}" > ROOTFS_PACKAGES:class-sdk = "sdk-files ${SDK_TOOLCHAIN} ${SDK_PREINSTALL} ${@isar_multiarch_packages('SDK_INSTALL', d)}" > +ROOTFS_VARDEPS:class-sdk = "SDK_INSTALL SDK_INCLUDE_ISAR_APT" > ROOTFS_FEATURES:append:class-sdk = " clean-package-cache generate-manifest export-dpkg-status" > ROOTFS_MANIFEST_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}" > ROOTFS_DPKGSTATUS_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}" > @@ -70,10 +71,6 @@ SDKROOTFSDEPENDS = "" > SDKROOTFSDEPENDS:class-sdk = "${BPN}:do_rootfs" > do_rootfs_install[depends] += "${SDKROOTFSDEPENDS}" > > -SDKROOTFSVARDEPS = "" > -SDKROOTFSVARDEPS:class-sdk = "SDK_INCLUDE_ISAR_APT" > -do_rootfs_install[vardeps] += "${SDKROOTFSVARDEPS}" > - > ROOTFS_POSTPROCESS_COMMAND:remove = "${@'rootfs_cleanup_isar_apt' if bb.utils.to_boolean(d.getVar('SDK_INCLUDE_ISAR_APT')) else ''}" > > # additional SDK steps -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/00b287b5-4842-44e8-bb26-b8457697a77b%40ilbers.de.