Re: [PATCH v2] classes/image-postproc: chroot before postprocessing /etc/machine-id

["'cedric.hombourger@siemens.com' via isar-users" <isar-users@googlegroups.com>]

On Tue, 2025-10-21 at 17:58 +0200, Cedric Hombourger wrote:
> On Tue, 2025-10-21 at 11:22 +0000, 'Heinisch, Alexander' via isar-
> users
> wrote:
> > Any updates on this patch? Seems it got lost.
> > 
> > On Wed, 2025-09-17 at 11:28 +0200, alexander.heinisch@siemens.com
> > wrote:
> > > From: Alexander Heinisch <alexander.heinisch@siemens.com>
> > > 
> > > If /etc/machine-id happens to be a link to e.g. /var/...
> > > the postprocessing overrides build-hosts /var/... instead of
> > > the desired file on the rootfs.
> > > 
> > > Signed-off-by: Alexander Heinisch
> > > <alexander.heinisch@siemens.com>
> > > ---
> > >  meta/classes/image-postproc-extension.bbclass | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/classes/image-postproc-extension.bbclass
> > > b/meta/classes/image-postproc-extension.bbclass
> > > index 991bac4c..b332e826 100644
> > > --- a/meta/classes/image-postproc-extension.bbclass
> > > +++ b/meta/classes/image-postproc-extension.bbclass
> > > @@ -63,7 +63,7 @@ image_postprocess_machine_id() {
> > >      if dpkg --compare-versions "$SYSTEMD_VERSION" "lt" "247";
> > > then
> > >          MACHINE_ID=""
> > >      fi
> > > -    echo "$MACHINE_ID" | sudo tee '${IMAGE_ROOTFS}/etc/machine-
> > > id'
> > > +    echo "$MACHINE_ID" | sudo chroot ${IMAGE_ROOTFS} tee
> > > /etc/machine-id
> 
> we could use the newly introduced rootfs_cmd to avoid a sudo call
> here.
> reach out if you need some clarification on how to use rootfs_cmd

Just to update everyone. Alexander and I discussed and concluded that
rootfs_cmd may not be used here since we require write access to a
root-owned file (rootfs_cmd is only an alternative to sudo chroot for
commands where we do not require elevated privileges)

> 
> > >      sudo rm -f '${IMAGE_ROOTFS}/var/lib/dbus/machine-id'
> > >  }
> > >  
> > 
> > -- 
> > Alexander Heinisch
> > Siemens AG
> > www.siemens.com
> > 
> 


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/015be7d274ac0be11e3e25248989c49673e6a551.camel%40siemens.com.