From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 02 Oct 2024 00:33:12 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f60.google.com (mail-qv1-f60.google.com [209.85.219.60]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 491MXBsx015848 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 2 Oct 2024 00:33:12 +0200 Received: by mail-qv1-f60.google.com with SMTP id 6a1803df08f44-6cb25c3c532sf113780186d6.0 for ; Tue, 01 Oct 2024 15:33:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1727821985; cv=pass; d=google.com; s=arc-20240605; b=bVzHWmVlQ/lyy3h77i/lDDI8PBwcRt/49mYxyIrCd+xhA2CccpUWt7tGbUS6NBO6Xu EVBs/OSDe2MggeujKUcowEoWEtnnDIvKQptGA08ehBCoaZypNeMdarOG24m2f980Lend 9f2PAQaFtMkWxYjLJzEEVuuvgjqIv3m2VqPHwjybjRnASHIshhsKMDq3jjiWZEoB7sXZ UghVWLrPfe2ITBy4KzigBWltbQ3l/TVn1GVzIuL+MX7cWmJvYUAnSKF+3jMI/xYHczTu jJKVIboaX+4aWDmiiI+Ug829zQyWxAijlpjmgFmW+HfHahaDLUk6yQC6lzF8cMlb9so9 EFVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=5Un3jwrmbLCwZCoVZ9IG21Eq8FFyAes2Z3yU0GJPK7c=; fh=IOzWKTRyeYUtFju1ry9DB1bP/phP8M6h9D7Np4RBe88=; b=DKQXseIfhaO5PnbD8X/1ZgpbZkxsaeT4driuzQtXoZxxzi+ZaTnzoJzj/cgWRBEN31 6BrWBJFUSOLIt/mY2XuOgljB6N2dEWtslyOQGBaRUxuACn7itanE02W2sD70qB/Pb7Ze A2gtNkE9CJ8ExAfZShjWWu/HDmYZ1DEsFh1hR/Xat00zuxhu6zTfvZfIECJ0Q5Krk2Qd L8YAv7nKuce226oohB/ECrGHiRIeLirPSl+Yr9tFN2W7J+iTn7IQKGSvNkSNQFVqiN9l pmd801zeV+VfDR18G1NahC5YkZTgEAnXnZXwMCECrzVYv7CgsgaViLov0FWL8SJXWf1A JzHA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=avkWuh2E; spf=pass (google.com: domain of fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1727821985; x=1728426785; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5Un3jwrmbLCwZCoVZ9IG21Eq8FFyAes2Z3yU0GJPK7c=; b=bMkD13NAQn1HAGISiBne4+maSPz6lwIGsfy1oxcGzEz9vzB6pnIv+LRVG68YGySkc3 oHJb9PEQKPQ+cLi3sWJPpLS9FBhTtfxRTS76QYJYjJJAY6VVVnmQ7Sqb4Ivom2Cay+sQ Sl5y3JfqLnlJpCzySZH3ml3yFSGXKanvh1gYrdkhLhdy2NxeEwFZ8rKMVxeD5FUZGm+d NUgXYL/OU8Jh0+8J19oS3Qs2LVNvbRUlO6gop+dJ1L2omtHoq/+K4tsZZm8nSdqKidAN 7cGV0MA52rVSj2EfA0/HIlWQ7UmZ26kU5AakA/X1B8vwY5bcItX8TZTH+z2uX5s2VBvN I7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727821985; x=1728426785; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Un3jwrmbLCwZCoVZ9IG21Eq8FFyAes2Z3yU0GJPK7c=; b=czYrs45w0A/G1Y/ZyKU884oe7TDepjkiOKBTvHEZTh0Q47DrIfzjcnRczpP4us6ou/ tTHL5fveuEpIOt60W4FnugBwpUv1hmkEdFKbNWd3FN2yQ7qy7CXNlYRxLshefBRxkWaJ YLiBpmuNuaVbO/2rFn8GUyhWBpEKFAsNRGUq1OKXCZJVnENCgy5XdKuEB4hTB8ZOcGGN vHFLhyXkUB+UzffTMtrZyhGirVLZoLYPAyICNQ727iwWw0WJuo8Ad72ummxlFdfH9CX9 e08z0320bWEZzvKqTb01pPiElV4ROQ+vwRV1HFpJ3yDQHxaIpO9N5AXeSYqjobyejqRI NRiA== X-Forwarded-Encrypted: i=2; AJvYcCVTJIPliEGlKOegpCBjIYVRBhX2IqvqQOR/NrEsMN93frAF5jpkebEzVLx6DCWZu/1BO8L7@ilbers.de X-Gm-Message-State: AOJu0Yx0wjH/GYiGM6//uGhntVpJ6tmUAfGBqFPpo569WtLUD/aMlx8e zYEELaMSoSsDPL0SE45V9FGPbbH6lRpd93+DPb6b1gj/zoUlKu2C X-Google-Smtp-Source: AGHT+IHdJwh5WyXdltCsDUBWgccgD5LOwhh5MHrh5ZDEuwz8Fw+a/4spmYTJd5bepExZ7e0jNR/b/w== X-Received: by 2002:ad4:4d4d:0:b0:6cb:83a7:68db with SMTP id 6a1803df08f44-6cb83a76aebmr7332226d6.6.1727821985231; Tue, 01 Oct 2024 15:33:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac8:58d0:0:b0:45b:5cdf:9723 with SMTP id d75a77b69052e-45c94a2ad98ls30508031cf.0.-pod-prod-02-us; Tue, 01 Oct 2024 15:33:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXaBoGNQG1IuFvHUTHdw+1635+Fw/uCGSwatR3VxyPgHw5I8e78dWMbxV9eAaicdv58YrlarhWdjRDv@googlegroups.com X-Received: by 2002:a05:620a:242:b0:7ac:9a9e:4864 with SMTP id af79cd13be357-7ae626dbff3mr158031285a.36.1727821984382; Tue, 01 Oct 2024 15:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727821984; cv=none; d=google.com; s=arc-20240605; b=b6pFMyaBkwrAM4rnn0TUNzITcTzFBC0L/3x63rAzuSB4gFbDnTIADd0whgO+K5RDq7 xjx7UfKAzGwaDLpTERYa/fBT68weAyDSCQoMxdi7Pu8lv0sxCWinz0sxYywGqvubfBdf dIe/jbDb6D0V8T6TztWMbG2q2G0zm3IPAKAkQROZQbVLq1PGINsjvAfMUGPN8002TYS2 cVTNn1+1pqVhGreNPFJn3odFIojoLm/M2OpwnSrxbKfrk26KI9nGyWm0gpFAqG9PTaPq 1U9ePPCcpDszsTvnw9hIEDucKqIKRnO8QnFagh5MdnCOxDV43ZnFVetoy1t25gjwi2j/ mbig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=A+tCcfdtId4mFZ/3s2ZN8y68jP8KjDSTdgsvzfAm/LY=; fh=FCTcxDA6+yXbrrMocxO7aHwOjd/EnxOM1nNyssQwzIk=; b=WcqMyYHoA4GmfRp4GylE3BKPxQEOaFkLc4MZCF59QN8ZGkC26Uurba1MKjUV6IWpEH EogTDzg0Vyfar7NI8BY95yueC/jz8hKA5yVV/Ca03j6EltziwtR/bcZFAC8wSQB5tAI6 vcEofCUkodeyuISrG+joDA3rDg39HgQelv8IzL9JNQKvYzRCzizxj5B9vXRRvz4CStJe 4UzFtUTAipXpkbat/ccWBFIWhgT+Ty7FyWCYQRmTUxch2Cl3Ci44yWElvuthX7Hh74xT gizfLnL7NJfrOEdyr4o5nfJTPFn1LJ0N/GxA9zoKXrDIOf20uLe8+Yu9iqZg18ouQEw7 7r8w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=avkWuh2E; spf=pass (google.com: domain of fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id af79cd13be357-7ae376c3c47si41170685a.0.2024.10.01.15.33.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2024 15:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20241001223303f3c46752f8e70c70f7 for ; Wed, 02 Oct 2024 00:33:03 +0200 Message-ID: <015cefd1513be9e918baefe50b55c8323065c384.camel@siemens.com> Subject: Re: [PATCH v2 0/3] Start to address umount problems From: "'Florian Bezdeka' via isar-users" To: Jan Kiszka , isar-users Cc: Anton Mikanovich Date: Wed, 02 Oct 2024 00:33:01 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-Original-Sender: florian.bezdeka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=avkWuh2E; spf=pass (google.com: domain of fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-68982-20241001223303f3c46752f8e70c70f7-6_unm2@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Florian Bezdeka Reply-To: Florian Bezdeka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: gn8b8zOzzv46 On Tue, 2024-10-01 at 17:13 +0200, Jan Kiszka wrote: > Changes in v2: > - break up the previously single patch into refactoring + fix > - add a fix for prematurely failing rootfs_do_unounts For v2: Tested-by: Florian Bezdeka But: We're not done yet. There are two more calls to rootfs_do_mounts that are not yet pared with rootfs_do_unmounts calls. The one in do_rootfs_postprocess is the problematic one from the other thread on the ML. (Anton is now in CC as well) I'm currently testing (on top of v2): diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index c67d3bb8..e359d529 100644 --- a/meta/classes/rootfs.bbclass +++ b/meta/classes/rootfs.bbclass @@ -235,18 +235,21 @@ python do_rootfs_install() { progress_reporter = bb.progress.MultiStageProgressReporter(d, stage_weights) - for cmd in cmds: - progress_reporter.next_stage() + try: + for cmd in cmds: + progress_reporter.next_stage() - if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "acquire-before": - lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock", - shared=True) + if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "acquire-before": + lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock", + shared=True) - bb.build.exec_func(cmd, d) + bb.build.exec_func(cmd, d) - if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "release-after": - bb.utils.unlockfile(lock) - progress_reporter.finish() + if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "release-after": + bb.utils.unlockfile(lock) + progress_reporter.finish() + finally: + bb.build.exec_func('rootfs_do_umounts', d) } addtask rootfs_install before do_rootfs_postprocess after do_unpack @@ -366,9 +369,13 @@ python do_rootfs_postprocess() { if cmds is None or not cmds.strip(): return cmds = cmds.split() - for i, cmd in enumerate(cmds): - bb.build.exec_func(cmd, d) - progress_reporter.update(int(i / len(cmds) * 100)) + + try: + for i, cmd in enumerate(cmds): + bb.build.exec_func(cmd, d) + progress_reporter.update(int(i / len(cmds) * 100)) + finally: + bb.build.exec_func('rootfs_do_umounts', d) } addtask rootfs_postprocess before do_rootfs after do_unpack > > Jan Kiszka (3): > image: Avoid breaking the build when mounts are no longer present on > umount > rootfs: Provide rootfs_do_umounts > initramfs: Add missing umounts after generation > > meta/classes/image.bbclass | 21 ++------------------- > meta/classes/initramfs.bbclass | 2 ++ > meta/classes/rootfs.bbclass | 32 ++++++++++++++++++++++++++++++++ > 3 files changed, 36 insertions(+), 19 deletions(-) > > -- > 2.43.0 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/015cefd1513be9e918baefe50b55c8323065c384.camel%40siemens.com.