Re: [PATCH] wic-img: Fix bind mounting

[Jan Kiszka <jan.kiszka@siemens.com>]

Hi Maxim,

On 07.12.18 12:18, Maxim Yu. Osipov wrote:
> Hi Jan,
> 
> On 12/6/18 2:17 PM, Jan Kiszka wrote:
>> On 06.12.18 10:44, Maxim Yu. Osipov wrote:
>>> Just to doublecheck: What is your patch queue for that?
>>>
>>
>> Just updated jan/queue on github.com/siemens/isar. It's not the best ordering 
>> of patches, this fix should probably come earlier, but the top is what I 
>> tested successfully also in a stretch VM.
> 
> I'm convinced that this patch fixes these two issues.
> CI passes OK on my stretch laptop.
> It fails on isar-build.org by evident reason (CI runs in stretch chroot on 
> jessie host - the host's kernel 3.16 has troubles with 'mount --rbind'). We are 
> now upgrading the host system.

Should we document this dependency "host >= stretch" somewhere, or did we already?

> 
> When applying to the 'next' I may rearrange the ordering of patches in more 
> logical path
> 
> git log --oneline:
> 
> c46ad1b isar-image: Make do_rootfs normal shell function
> 05d0fc4 isar-events: Improve umount handler
> 93c4795 ci: Make partial rebuild test non-destructive
> 4ca0bff ci: Wait for bitbake worker to finish before deleting artifacts
> 698fb56 Remove redundant recursive umounts
> bbc61fb wic-img: Fix bind mounting
> 9cf29e6 isar-bootstrap: Fix and cleanup bind mounting
> b354026 isar-image: umount base-apt when doing offline build
> e965c0d gitlab-ci: Switch to ci_build.sh
> 
> is it OK?
> 

Looks good to me.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux