From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631790376260730880 X-Received: by 2002:a17:906:2445:: with SMTP id a5-v6mr334604ejb.8.1544182441904; Fri, 07 Dec 2018 03:34:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:97b6:: with SMTP id e51ls468858edb.6.gmail; Fri, 07 Dec 2018 03:34:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/WgnYCdQNdYT4z0JnFDnCzuibDjnMmeCXtQnRFjCmAPLvw/TsjRxrs5NchF8yP5aeWw4Rd0 X-Received: by 2002:aa7:dc56:: with SMTP id g22mr398438edu.10.1544182441382; Fri, 07 Dec 2018 03:34:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544182441; cv=none; d=google.com; s=arc-20160816; b=LyPzxorFw9KwbVqjT4mfet7OiTqAO8izqKSW6WtmIUjTDm0E9ea2aPb/62IUS7o9Lb k38WdHIyrlEBcoTABb8nyI3/UIHcPW4HWuVkijEHVrJgJdRKjNRleEIm9LzLj7H/zoW3 TX7vhD19odK9mXM9K9icWqd/x7knftg7EOEiaR89smk4xHrMFkHJ8diGS9xG+n0neKKj TLmLAiUNqEZIaUnpDOP6y+sjTWu+M1qS0rVBiEXMLRxxbNvFQmBOjwT0WMMvGgVwVFAT 9rl2bZ/9yf/SGeALPNh6SxczZaNvcZIiG3bSoVELNFvo6Yr7bVZObbeccACJT6ENIdE8 8iYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=D/PjZ9reUoD9HZCLHVq8ylC/j0ZlGohQDIFzd9GiSzA=; b=JcdkhfFQGGGUCwbFrL19QlkRMpVB498r5T4DnveGAFsAhJFJ8tzO05KFO5A9F9ONxP zYbahfPVza4g0LRx8DAXeyi5tjc5BaMw4rd68uM0N7m23h0rnmUetNf/kflZs16SLOa3 2KKhofcMGVi+66jQzfhff2w1/6SWsYmJ8dInPCWGkc035njviH60iMXQtFXIKxYAsJ9q p2l42HNSMSAs2hcimuUhcwESfAU5sYO52DWTRQJIHR9qxMudm33FbAOdclpqjelB0h9J 3D6+Q5e+u6Aw0TShRI5Va27xdWpb/LxSTcf2zxPPAwixBW324yC8P7cNSN9/4gy5izaU rkpg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id h28si137580edh.4.2018.12.07.03.34.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 03:34:01 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wB7BY0pl010089 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Dec 2018 12:34:00 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wB7BY0AM026903; Fri, 7 Dec 2018 12:34:00 +0100 Subject: Re: [PATCH] wic-img: Fix bind mounting To: "Maxim Yu. Osipov" , isar-users Cc: Henning Schild , Cedric Hombourger References: <2c2a8362-185d-5009-c1ad-716b3cd88749@ilbers.de> From: Jan Kiszka Message-ID: <0175c45c-f8ee-3875-7638-01d421aa0dcc@siemens.com> Date: Fri, 7 Dec 2018 12:33:59 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <2c2a8362-185d-5009-c1ad-716b3cd88749@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: aLrk4hxJxtcD Hi Maxim, On 07.12.18 12:18, Maxim Yu. Osipov wrote: > Hi Jan, > > On 12/6/18 2:17 PM, Jan Kiszka wrote: >> On 06.12.18 10:44, Maxim Yu. Osipov wrote: >>> Just to doublecheck: What is your patch queue for that? >>> >> >> Just updated jan/queue on github.com/siemens/isar. It's not the best ordering >> of patches, this fix should probably come earlier, but the top is what I >> tested successfully also in a stretch VM. > > I'm convinced that this patch fixes these two issues. > CI passes OK on my stretch laptop. > It fails on isar-build.org by evident reason (CI runs in stretch chroot on > jessie host - the host's kernel 3.16 has troubles with 'mount --rbind'). We are > now upgrading the host system. Should we document this dependency "host >= stretch" somewhere, or did we already? > > When applying to the 'next' I may rearrange the ordering of patches in more > logical path > > git log --oneline: > > c46ad1b isar-image: Make do_rootfs normal shell function > 05d0fc4 isar-events: Improve umount handler > 93c4795 ci: Make partial rebuild test non-destructive > 4ca0bff ci: Wait for bitbake worker to finish before deleting artifacts > 698fb56 Remove redundant recursive umounts > bbc61fb wic-img: Fix bind mounting > 9cf29e6 isar-bootstrap: Fix and cleanup bind mounting > b354026 isar-image: umount base-apt when doing offline build > e965c0d gitlab-ci: Switch to ci_build.sh > > is it OK? > Looks good to me. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux