From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 10 Aug 2026 13:06:59 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f63.google.com (mail-wm1-f63.google.com [209.85.128.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 67AB6wqH029976 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Aug 2026 13:06:58 +0200 Received: by mail-wm1-f63.google.com with SMTP id 5b1f17b1804b1-49564d4b849sf6357245e9.3 for ; Mon, 10 Aug 2026 04:06:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1786360013; cv=pass; d=google.com; s=arc-20260327; b=pv9rRKoL8T20VQiCNJrsRWvy11dxwpECbTN9rJxuv4OwEOvRnycr6/HZo3lUOBSIjg SVTm3GEl26ola3Em5pmvs00+5geZbXPVfbdcRojnVTnkR0MKQ+qgxaRI+dpRNi1F9++N UNICNQ/TRSuxgvAc2Vp0M9Db5Ml4Mg4bpwZC26G9x/iS14K2dWrblXf++qKJHy7oD3nK dlAprjtLCWZq7RnoLUtty3PFFz09xlwVu3CmrLdw+PvQBEYbM9nzYLI6M7Hq7fN6/Hws oDsPwurzzS4ZI0cF16oNUZSMVJVeI2TyOb92qHDZMq2vXUFFFONLgU9K4V4dkx0cqRl4 Ub+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=EEIgUTX/SjWwZ3xylQM8gLpyjwVWLEncYarZQYCxjsU=; fh=xTG6yZjdQxxFbp5LZDUAkLuBXvUlmYYLGO5sUr347Jg=; b=sQpxUFkRdCSsFAlPCOIgETsXIDfQ9Np/PiEKq7dvPZJuZWd/0ZVpBKp/XdC8YfX2Jd k+XvL4W/Xr3NhntKrENLh0QGK3cU3k6WGpKpUmek841UoplNruTdIAZSvOMsQXrxDMq/ 9I1Rm1szTMcLOYwIXGWIfOY/XRue/xMjc0UuZWQB0/peq+DFC63pHSMvuZt2IQGp28c8 O3SNyUnc4rnnaFi3+1ZVl911CHi5qn/uhPleEjtXM9Mn7xbh6pb4oedLFQR7eJM0TTWY uF8xY/mJKlSFnqsHlHhJGEtFBZ/5G5cAoxiFII1SkWb6Uiu1YYbiKwjeOSBt1fYeGuCS lIFQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of akarpovich@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=akarpovich@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1786360013; x=1786964813; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-type:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EEIgUTX/SjWwZ3xylQM8gLpyjwVWLEncYarZQYCxjsU=; b=GZcTVt0yXn/R0UPX8F3JA98iMM00SbM1DlbHu8dPLXTJaUvgn7kyiWOaJfZnmSvRh+ 0wceTZMV9sadeLRkNij9hI0zRqO/nkyb9kjwb+LaEf3LPBYQPylOgbr28WXL08E3eTdB gAsl4CsLlZ14aUGmMcAuwpJ31Vwi9kUQcfcrWwRYTfN2LzWtZ1YpZ1BG9jrP6pbiL5c6 fWjODp4Q5CshuWiGyyobpPsABaRIOxNdG1DYzV6TmpzbbghqJEvGEYduycqgBA1Jw3JS WGhHvVmseHZR5ctQvLuub1QZo9A8XRkWzOQYBhIYcR+PO2ZgtuFFwNxJa+yHYFi5cD7p soiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786360013; x=1786964813; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:content-type :in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EEIgUTX/SjWwZ3xylQM8gLpyjwVWLEncYarZQYCxjsU=; b=WjkokA37Te2mf0cmwd+xw3AIEvPOTAuFPpigBARXBrVNn4+OljyMlKRS29MVNuAb2f wDGYcXr1n11+cMm9wCZn4oVLAyyWg5q4J5Ds75J5motayYCfgeFjfBlbC8uZ8Lv8QG06 ZQ+IrG7OiU84BiWocZ++H+B5gMnn3j/MHqUOugwq/Fz1+9a+HTfct4kODlh7/yeGP7Db G/cTtCV6JRsVkYNK3CbVtKW3IWAGDPI5K9d6kX/kjlzmK+OhmJ4LNrjaqhVhjqiDE0Zp k7YYHkuhYA34+uI+Au5gskbKfqnR709EqkxmQ8gS69A2tFbIEC57JRoft6y/g4hMJ/1e /YTQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AHgh+RrlQ5sUM5nL0SbriMvR/UxxIgSa1V0O4AdBuPEM5EOmTM+ApH9mI7FRL5Snt9vyznUQIt+g@ilbers.de X-Gm-Message-State: AOJu0YxlCz/Xnup/xLT0fyP5PZZKS7ZrqnpTSIwqy6Q3QITLYEGYRwb0 Y8U3V6sa891Qhm7t5Qc/HH76HKDR+xWRrVSjDeZAz8QvOJ2zbk7U5J3v X-Received: by 2002:a05:600c:4f49:b0:499:4892:e84e with SMTP id 5b1f17b1804b1-4995e0d03a8mr272752235e9.11.1786360012990; Mon, 10 Aug 2026 04:06:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="Aa7YSPQngR9wSn1GVPaAz/lRQyqAGayyw5CJ8PMRkCTXIdzvLA==" Received: by 2002:a05:600c:4686:b0:493:f851:cfc1 with SMTP id 5b1f17b1804b1-49954bc1999ls38186465e9.1.-pod-prod-08-eu; Mon, 10 Aug 2026 04:06:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RpEO9d1HWwEKiuxU8PKQgEpXOcZKtUU8DGvi9AYT9b0+6sNVaTZ3RHjXPd1l3Odeh6cZclXzXP1RgZC@googlegroups.com X-Received: by 2002:a05:600c:3548:b0:498:8e6:d464 with SMTP id 5b1f17b1804b1-4995e0def7bmr296104345e9.14.1786360011057; Mon, 10 Aug 2026 04:06:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786360011; cv=none; d=google.com; s=arc-20260327; b=NN8+wFdm1uKWIxZpnNYlBNEyAD7faQzUR1tgK+UT9Fh9Fuldb1ONVAX0Xtog4AdNr9 O85ZYCN7sHETUXOVV/TgY3JdlJ7IpTGuNYlgjPppuA+kRwdWYf0F9I5pErdTRvlDUg5s eqMRFWvp/ojTxPmrl9fOD18IjyJt0vbm412nzRibWMA1y+tWbw9bBqRfphm8YjbErItA WpQyhvUJDAK5MnWRZQf6EnTO2zmjrQIJ0Cyv0rhVBqZ6JXkKFOmDjxYNL4mhizqoB0TC V5pJlzzIvLtFvl3Ptx6nBCo6+FbSoqWCK0lXm3+fIK2LPYvAmxIixN4/vA858QoNmX8o 3afA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=jQ5dYMFW817R5bYmy6RnYQbA7W+kgyo8Erfd+KlMprE=; fh=oj2Lw3hN0xAF1UllTKVHI9r/7a2eBqx72zyDCjayfJ0=; b=r1/gSisTFpg+HunuJ3+YvfS4BRplaPG+YPaG79fLBKtfZrM8UwaHsyRLfwdOhCPDEQ LebBm+Ne3v57E4lMITzEKmvFIVr6C1Co1PjaPaNabkmeREhLKXZ3bGbfI83jBEUYDEad j918OsOqJVgRfy6cfjy6e7iLHQMqJHa/dhq7DFO6EGLLwdZ02czOaWpQCXdMnfbxzSkv g/yQc5E0QYmmhd+u+oz5iRw2UwcNvZbLWCCh7XzADvWE/42BD8qOkyhO18k8ZB1vm3bw KlTsF8ELdBSitkhqqCUCgD6nF5obOZawA11fk/XL0c8+vGn7jJMoexUT7ZyWqXvxFIQB sg/w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of akarpovich@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=akarpovich@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-4995bdc17fesi1449855e9.1.2026.08.10.04.06.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Aug 2026 04:06:50 -0700 (PDT) Received-SPF: pass (google.com: domain of akarpovich@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [10.54.4.147] (62.122.174.6.serverel.net [62.122.174.6] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 67AB6RGd029963 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Aug 2026 13:06:50 +0200 Message-ID: <01cb468a-7ceb-4d2c-a361-5ad6e1ae9f57@ilbers.de> Date: Mon, 10 Aug 2026 14:06:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] fix(rootfs): copy isar-apt packages instead of downloading To: Felix Moessbauer , isar-users@googlegroups.com Cc: jan.kiszka@siemens.com References: <20260730111933.1237145-1-felix.moessbauer@siemens.com> <20260730111933.1237145-2-felix.moessbauer@siemens.com> Content-Language: en-US From: Aliaksei Karpovich In-Reply-To: <20260730111933.1237145-2-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: akarpovich@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akarpovich@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=akarpovich@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: 1/rBVdru78yO On 7/30/26 14:19, Felix Moessbauer wrote: > Previously, the arch part was stripped, hence on multiarch or compat > scenarios the wrong package might have been downloaded. We fix this by > considering the whole filename. For that, we switch to cp, as we > otherwise would have to reconstruct the package name from the filename. > As the whole path is urlencoded, we cannot directly pass the url to cp. > Instead, we reconstruct it based on the base-path (which is taken as-is, > as it does not have any special characters) and the second field emitted > on --print-uris, which provides the decoded filename. > > As we now use cp, we also don't need any locking anymore (technically we > did not need it before either, but apt was called in a way that required > it). > > Fixes: b90b722f ("rootfs: Deny packages download during install") > Signed-off-by: Felix Moessbauer > --- > meta/classes-recipe/rootfs.bbclass | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass > index 77e6aefc..2ce8cee3 100644 > --- a/meta/classes-recipe/rootfs.bbclass > +++ b/meta/classes-recipe/rootfs.bbclass > @@ -361,23 +361,15 @@ ROOTFS_INSTALL_COMMAND += "rootfs_install_pkgs_isar_download" > rootfs_install_pkgs_isar_download[weight] = "50" > rootfs_install_pkgs_isar_download[isar-apt-lock] = "acquire-before release-after" > rootfs_install_pkgs_isar_download() { > - mkdir -p "${WORKDIR}/dpkg" > - > - # Use our own dpkg lock files rather than those in the rootfs since we are not root > - # (this is safe as there are no concurrent apt/dpkg operations for that rootfs) > - touch "${WORKDIR}/dpkg/lock" "${WORKDIR}/dpkg/lock-frontend" > - > # Command apt-get install do not cache packages from local repos > # We can obtain non cached package URIs by recalling install command here > - # No need in export those files to dl_dir, so we can run it right after > + # No need to export those files to dl_dir, so we can run it right after > rootfs_cmd --bind "${ROOTFSDIR}/var/cache/apt/archives" /var/cache/apt/archives \ > - --bind "${WORKDIR}/dpkg/lock" /var/lib/dpkg/lock \ > - --bind "${WORKDIR}/dpkg/lock-frontend" /var/lib/dpkg/lock-frontend \ > --chdir "/var/cache/apt/archives" \ > ${ROOTFSDIR} \ > - -- /usr/bin/sh -c "apt-get ${ROOTFS_APT_ARGS} --print-uris ${ROOTFS_PACKAGES} | \ > - sed -n \"s|^.*/\\(.*\\)_[^_]*_[^_]*\\.deb'.*|\\1|p\" | \ > - xargs -r apt-get download" > + -- /usr/bin/sh -c 'apt-get ${ROOTFS_APT_ARGS} --print-uris ${ROOTFS_PACKAGES} | \ > + sed -n "s|^.file:\(/[^'\'']*/\)[^'\'']*\.deb. \([^ ]*\.deb\) .*|\1\2|p" | \ > + while read -r path; do cp -n "$path" ./ ; done' I rebased the 'base-apt improvement' onto new next (which contains this fix) and faced with following error: "cp: cannot stat '///base-apt/debian/pool/main/f/file/libmagic-mgc_1%3a5.39-3+deb11u1_amd64.deb': No such file or directory". It's from mc:qemuarm-bullseye:isar-image-base target build. It happens because this fix doesn't take into account that the name of package can be different in case of package has 'epoch version". For example (output from apt-get with --print-uris): 'file:///base-apt/debian/pool/main/f/file/libmagic-mgc_5.39-3%2bdeb11u1_amd64.deb' libmagic-mgc_1%3a5.39-3+deb11u1_amd64.deb 273104 MD5Sum:3794ad03799b25e843a8174af498e779 'file:///base-apt/debian/pool/main/f/file/file_5.39-3%2bdeb11u1_amd64.deb' file_1%3a5.39-3+deb11u1_amd64.deb 69164 MD5Sum:7722574e511cd65659d95042e3099fa8 file_5.39-3+bdeb11u1_amd64.deb - name in pool file_1%3a5.39-3+deb11u1_amd64.deb - name for downloading Aliaksei > } > > ROOTFS_INSTALL_COMMAND += "${@ 'rootfs_install_clean_files' if (d.getVar('ROOTFS_CLEAN_FILES') or '').strip() else ''}" -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/01cb468a-7ceb-4d2c-a361-5ad6e1ae9f57%40ilbers.de.