From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6680483261914808320 X-Received: by 2002:a50:fe15:: with SMTP id f21mr18893182edt.135.1556093889362; Wed, 24 Apr 2019 01:18:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:f4db:: with SMTP id v27ls301005edm.15.gmail; Wed, 24 Apr 2019 01:18:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyf4TallW7r4xc4a0QRB7gwVzBR7CoJYqyrWsz3Z6JMMYnskIxznChrgT/dzrq5nEpvMnlt X-Received: by 2002:a50:9172:: with SMTP id f47mr19538407eda.233.1556093888896; Wed, 24 Apr 2019 01:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556093888; cv=none; d=google.com; s=arc-20160816; b=HNTUOMroElNmawjwDS5n5mZ51+1MQEM+1TUIHZ5cY6S646ynMdvj6gSKDwIfD5jH/D eIMb4ddq7HKwE0PhNgmi3tsjKzXQDXM/TZmunvDvsrQIYWsb+DsNtEcnDjax8QpZFK0u Q6RsvAeDpj/ue7Ic/ueMYl6BBGHSZ1JEgtSJUGXvgr9p7Ls6rSI3Dj+2Rkl+LuU2Fmv2 DQ5hbqb5pfCQi9QXO62czyhwuVBomSkokMM69EKID9qx/IjFPqmTMm34WFHV2hgCSb8/ dUopMZ45zQ3+xvRBDdbRexe3zh2mAW8l/JLuoEFu2yukycAz7+qQzz3fLk1dYKZbG1IF Jluw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=dUy+iYOzYdFHOlbm/sweuX56AzuAydFBgYom/nhtdDs=; b=Zg72EbcJraa63fSmjjRR1Nk9wx3VzxZEOcmwBBLj/vDn7j5rAMWgnvD92EV9/BPyFN +ZeGSMno6ckfY2fHKh7kF9QGFaHbAOsJk5nF53J0o9xk0xhfxa1RvV9bjgrfQc6FPgA4 09vLXBTm6lmXMt9+MhyvV5gu6WAvRYj5EwgZkNnDBn/LpSnEw32tQtOi9B5ofMLZcbos qhojsCG6ZKy7YPHXzn9tYhxm1Jp2wkOSUWzMmTcUnNHpNUTqg827fBJfX32/H4CCCjjz 2z5hy+A4qyKbNMJSqrx15UKemM3YhZxe7Dq55q9uuNk9k2yNnOP6i7egK7gKfgav4gFG N5Ug== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id t17si279350ejq.0.2019.04.24.01.18.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 01:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x3O8I7x3011767 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 10:18:07 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x3O8I6Pm023626; Wed, 24 Apr 2019 10:18:06 +0200 Subject: Re: [PATCH v2 0/8] Cleanup rootfs creation To: "Maxim Yu. Osipov" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190417111159.2184-1-claudius.heine.ext@siemens.com> <24e19870-6d4c-3258-e568-b8e77d7158e2@siemens.com> <617a0721-0612-e1eb-fcd6-1b3465976e35@ilbers.de> From: Claudius Heine Message-ID: <029395a6-8a6b-06ee-7307-580fa418f261@siemens.com> Date: Wed, 24 Apr 2019 10:18:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <617a0721-0612-e1eb-fcd6-1b3465976e35@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: lyFYBexb3ihJ Hi Maxim, On 24/04/2019 10.00, Maxim Yu. Osipov wrote: > Hi Claudius, > > On 4/24/19 8:53 AM, Claudius Heine wrote: >> Hi Maxim, >> >> On 22/04/2019 15.48, Maxim Yu. Osipov wrote: >>> The same problem with SDK creation discovered in v1 series persists >>> also in v2 series. >>> >>> Just recognized that "quick" CI build fails too. See for details: >>> http://isar-build.org:8080/job/isar_mosipov_develop/91/console >>> >>> Please run CI scripts before submitting patches to the mailing list - >> >> I did: >> >> http://isar-build.org:8080/job/isar_claudius_ilbers-ci/46/consoleText >> >> That build just fails because of the qemu boot where loading of >> modules fails for some reason, but you said that could be ignored. > > Well, I said that one may ignore problems with checking login prompt (CI > tests need to be improved at this point), but I don't remember that I > said that one may ignore problems with modules loading. I thought you meant that issue, since that occurred on my post-processing patchset on my CI as well and you reviewed and merged that. It did not happen on your CI run as far as I could see so I thought it might be just something that occurred when I try to build something on that machine. (different user account, priorities, what ever) Well those two problems occur pretty intermittent. From what I have seen there is no real pattern there. I also tried booting the resulting image in qemu at one point locally as well and I could load the module from the command line or was already loaded IIRC, so I thought it could be a timing issue. Do we have a different CI configuration? If that is the case can you set my CI configuration to the one used when building next? Claudius > > Actually, the problem with loading modules persists in the current > 'next' starting from the build #291 (when I applied your patch set > Implement ROOTFS postprocess commands) > http://isar-build.org:8080/job/isar_next/291/console > > I'm investigating the reason now - from the first glance the ARM stretch > kernel version has been changed from 4.9.0-8 to 4.19.0.4. > >> >>> this will save maintainer's time. >> >> Well if you are short on time, then I would suggest looking into >> better tooling. >> >> There are solutions that could automate most of the job you do as a >> maintainer, meaning loading patchset from mailinglist, processing it >> in CI and reporting results back to the mailinglist. >> >> Probably something like this: >> https://that.guru/blog/patchwork-and-ci-in-a-tree/ >> >> As I suggested months ago that patchwork can help safe time and avoid >> leaving any patches behind. If you don't look into solutions like that >> or write your own scripting, then I don't see much reason for you to >> complain. > > >> By doing that, you might even have enough time to start doing code >> reviews and taking part in design discussions etc. where it is much >> better invested that just pushing the "Run CI build" button and >> waiting for that to finish. > > >> To be fair I might do you injustice and you are performing thorough >> review of every ones patches and every ones code is just that >> excellent that only grammar and spelling mistakes in commit messages >> are left to critic, but then it might just be a matter of improving >> communication. > > Thanks for the link/your opinion. > > Maxim. > >> Claudius >> >>> >>> Maxim. >>> >>> On 4/17/19 1:11 PM, claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> Hi, >>>> >>>> this is the fixed up version. >>>> >>>> regards, >>>> Claudius >>>> >>>> changes from v1: >>>>   - fixed typo in commit message >>>> >>>> Claudius Heine (8): >>>>    isar-boostrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to >>>>      base.bbclass >>>>    move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to >>>> isar-bootstrap >>>>    buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH >>>>    isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR >>>>    bitbake.conf: remove unneeded and differently used variables >>>>    image.bbclass: make IMAGE_ROOTFS overwritable >>>>    bitbake.conf: set default QEMU_ARCH variables >>>>    buildchroot/configscript: make creation of builder uid/gid >>>> idempotent >>>> >>>>   meta/classes/base.bbclass                          |  9 +++++++++ >>>>   meta/classes/buildchroot.bbclass                   |  2 +- >>>>   meta/classes/image-sdk-extension.bbclass           |  2 +- >>>>   meta/classes/image.bbclass                         |  2 +- >>>>   meta/classes/isar-bootstrap-helper.bbclass         | 14 >>>> -------------- >>>>   meta/conf/bitbake.conf                             | 13 ++++++++----- >>>>   .../isar-bootstrap/isar-bootstrap-host.bb          | 11 +++-------- >>>>   .../isar-bootstrap/isar-bootstrap-target.bb        |  6 +----- >>>>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc |  1 + >>>>   .../buildchroot/buildchroot-host.bb                |  1 + >>>>   meta/recipes-devtools/buildchroot/buildchroot.inc  |  3 +-- >>>>   .../buildchroot/files/configscript.sh              |  4 ++-- >>>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb       |  3 +-- >>>>   13 files changed, 30 insertions(+), 41 deletions(-) >>>> >>> >>> >> > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de