public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v2] sdk: fix toolchain install dependency
@ 2022-06-21 12:54 Anton Mikanovich
  2022-06-23 18:08 ` Anton Mikanovich
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Mikanovich @ 2022-06-21 12:54 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich

Depend on build-essential or crossbuild-essential based on
ISAR_CROSS_COMPILE value. Override style was not actually working.
This will fix SDK building of riscv64 targets.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/sdk.bbclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index 38671bb..32ee2de 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -41,9 +41,7 @@ SDK_PREINSTALL += " \
     devscripts \
     equivs"
 
-TOOLCHAIN = "crossbuild-essential-${DISTRO_ARCH}"
-TOOLCHAIN_${HOST_ARCH} = "build-essential"
-TOOLCHAIN_i386 = "build-essential"
+TOOLCHAIN = "${@'crossbuild-essential-${DISTRO_ARCH}' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' else 'build-essential'}"
 TOOLCHAIN_append_compat-arch = " crossbuild-essential-${COMPAT_DISTRO_ARCH}"
 
 # rootfs/image overrides for the SDK
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] sdk: fix toolchain install dependency
  2022-06-21 12:54 [PATCH v2] sdk: fix toolchain install dependency Anton Mikanovich
@ 2022-06-23 18:08 ` Anton Mikanovich
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Mikanovich @ 2022-06-23 18:08 UTC (permalink / raw)
  To: isar-users

21.06.2022 15:54, Anton Mikanovich wrote:
> Depend on build-essential or crossbuild-essential based on
> ISAR_CROSS_COMPILE value. Override style was not actually working.
> This will fix SDK building of riscv64 targets.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>

Applied to next without waiting too much to not slow down the release.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-23 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 12:54 [PATCH v2] sdk: fix toolchain install dependency Anton Mikanovich
2022-06-23 18:08 ` Anton Mikanovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox