From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a17:906:6992:: with SMTP id i18mr13204230ejr.224.1553502074224; Mon, 25 Mar 2019 01:21:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1d4f:: with SMTP id o15ls1882086ejh.0.gmail; Mon, 25 Mar 2019 01:21:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOEnp83hYvI+e2BUQgDQJX/BbZiWNTzjQpXFhx/8gY0+VsXYgITxhJED4ncCptmlKGKrgK X-Received: by 2002:a17:906:b7c2:: with SMTP id fy2mr13372148ejb.9.1553502073386; Mon, 25 Mar 2019 01:21:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553502073; cv=none; d=google.com; s=arc-20160816; b=cEV9ifgGrFsxxwG5bAIvpUIka1ci3RqkRwLO8G+1Uy8fO8t9KJIxRNXt97MKB8J5nM 0sK34AEbE7exraTY4pj4XuW3tZu6fuMT7G2khbyDEE/4RsDVdFHE8Gwp/R38+g58EVvW vvTHAe/SQOaYuvX1psHocAWplGVR86ROFxNFolVzEwMwZeLJRbipoZpzCjDXlYHjpopt OCw5sRwV7beIxp9DO1mvhPdEp79M0XcqjuruokpwD4QgAuS2fuoSThMolDVoU3jE85or e9lEKu8iizBiwJKBo4d1ubG1YW2UEJvF6XeTYVoHag7tt+3ApCit5QZ4xmfyjdSzR/JI s/Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=FhMAhfOwU0a9tKgwths2NWNQqDfd+ZPtf1SbErqWcaw=; b=YVsLwqLQlFmAxSwFr0GPeMSA0ZUt/3sb+ftJSSqNHOr2d5IouKNoLukwieL7eZTO/i a8/CrNrr7TLZmQZaQzc5HccGDur8qKCJsjWArEhUz4NXPyTlDJhGonz2/FsftORrvtqP oQ3IfMhZY+h+UfYCMty68hpOIX4P8bHU3WL6wB6OuEUeki2wv5yHZhwHab8VJMED3mhV lkCs7aIjOInKtA69jNK0kLslGNb+9Api9sV/vi0zRk6oSrOIllP+kpE0Mi0N3ILcWGqL nwelygcpqxac3zbdZpLHvYRFTrJjhP5bZv1ktMD8JCyef4ll2rU0jZmHt+Q4Ww2N2TDb xsug== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id a5si862905edn.3.2019.03.25.01.21.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 01:21:13 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x2P8LCkp017153 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 09:21:12 +0100 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x2P8LCF5025280; Mon, 25 Mar 2019 09:21:12 +0100 Subject: Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine References: <20190214112850.12469-1-claudius.heine.ext@siemens.com> <20190214112850.12469-2-claudius.heine.ext@siemens.com> <56f05745-cd50-e946-e189-22402b7c4d63@web.de> <15145951-bf01-4a34-7f55-0493573769f2@web.de> From: Claudius Heine Message-ID: <038e94f9-547a-9704-3221-2956b6cde69a@siemens.com> Date: Mon, 25 Mar 2019 09:21:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <15145951-bf01-4a34-7f55-0493573769f2@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: nAnYt+REucXc Hi, On 25/03/2019 09.13, Jan Kiszka wrote: > On 25.03.19 08:53, Claudius Heine wrote: >> Hi Jan, >> >> On Sun, 2019-03-24 at 19:28 +0100, Jan Kiszka wrote: >>> On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS. >>>> TEMPLATE_FILES is a list of files that should be processed in the >>>> `do_transform_template` task and TEMPLATE_VARS is a list of bitbake >>>> variable names that should be substituted in the template file. >>>> >>> >>> Bad news: This patch introduced a regression into the release (sorry, >>> didn't >>> manage to test earlier). It destroys the reuse of self-built >>> identical packages >>> for different targets. Namely, jailhouse-images now tries to build >>> the shared >>> (per arch) kernel multiple times, and that fails miserably because >>> there is a >>> common folder for all of them. The issue disappears when removing the >>> do_transform_template task from the chain. >> >> Hmm, have you looked at the resulting 'TEMPLATE_VARS' variable? All >> variables in there need to be the same in order for it to have the same >> stamp. If that is not the case then maybe overwriting it instead of >> appending it might work. >> >> These are the defaults set in 'template.bbclass': >> >>      TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME >>                        MACHINE DISTRO_ARCH" >> >> If I understand you correctly then your recipe should not be dependant >> on the MACHINE? So either remove MACHINE 'TEMPLATE_VARS_remove = >> "MACHINE"' or just set a 'TEMPLATE_VARS' that you really need in your >> template files. > > OK, might be that "MACHINE" is the problem here. Will check. If that > turns out > to be true, it is highly counter-intuitive and should be fixed, at least > for > nop-jobs. Well sane defaults is always WIP :) I think I added this because the u-boot recipe in meta needed it. It seems that u-boot is special here. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de