From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 18 Dec 2025 08:28:14 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-ej1-f61.google.com (mail-ej1-f61.google.com [209.85.218.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5BI7SE7s008652 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Dec 2025 08:28:14 +0100 Received: by mail-ej1-f61.google.com with SMTP id a640c23a62f3a-b79ff60ed8esf33903466b.0 for ; Wed, 17 Dec 2025 23:28:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1766042889; cv=pass; d=google.com; s=arc-20240605; b=KywclkIlzwyoBCinCRnLzAoBaofzWlb4JqEAzOn7vb1uYcLjEKXGOGGWkyiIUsqJgU lPF4JuRKUWEmaSDo9R/Kn7z1DLpbcrmdzEJSlUJ9Ykw2RiG8o2UsRrndHEhB7b5VsRft +Q8IguCVUgun+1yT5CGSi2Ut4x6+9O+tjwOqLW4wXDhLl04JfqeFXQY6P8f4oDrBET2d y0oQqRPdzTgn2aHPFBlwMmB2cPuFXjRM9aTofHCt9C7MBi2jGaYoNkofoC/Y4cOBJlUr w66T26eFlt8R7IzKKYo8XgcSAKaaauvUmsR1Ahn4G0saD+nZXUCUYmfvoXwRMNsMdx6E vfJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=P6o2tx6Xk+anHSiDysKDsWt7a2Y5lVm5P0C2QZjFRuA=; fh=DUf61RnLCwC12mvsnpQldJSxHtHMJvQTareViEeoJzg=; b=FDH/AwnGEAxIxUWcvtnDkzqFmtuyYQIQfih+nmcLz2qFngwNWqZ2IhhwSnQPHorCFc HBqajFlVTwRGb/80Zti6F+hLeGWGLqYZnTgKiOZIY1IFyTBVa3HPBwNaZDIFUopVe1OF 8A7s66ifguPRbe6gFGkPAIjhynpqpcw48g3xvepG1SsYgfO7OrVasjAlL1GeLZiy6SiT 1zKPoDsvYJmL9F0vTpRbuO1m3AaLIwC4H1TO23vIlWpmphtHrq2v/7v8CD0iBJ52t3GG bVQ+/bTv3xkhj0ctBSQotAs2u0PTn60DqTQsUMXCoWkeh6TZhw8HCJe5eZVf7ae4WEAa ekEQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1766042889; x=1766647689; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=P6o2tx6Xk+anHSiDysKDsWt7a2Y5lVm5P0C2QZjFRuA=; b=QdD/uS4zshP6PmPUsrtq2dhIhSs5MPhhJsVuwZwkXdBCnKUq0+VKxnabWMuIwhZr/+ hHHkkdpJSuNpIKUl5h5IIP58cBdPja1MMGmwk6zM8jNjlO4LFaaFyirgD902sFwQMkBx R1jYfA+K6yzG9HkqUwntusNxYs1nuzhXGfhYXUM0JHGUUejmmY2tNDcretmC0H3+xGXF O+o0tYBqLkDiID5vTeC/BGqWo/evABT0GlR/yXvis+hnJhxZwIomrumyPPcPK2UKM6w7 snpnF015VufNDimBujFhLtidjgsvZMP1qTrZVhXhEJ+iQcucTAQyW3tEyDdPICfu7gSv OTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766042889; x=1766647689; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=P6o2tx6Xk+anHSiDysKDsWt7a2Y5lVm5P0C2QZjFRuA=; b=ZvCxog4pOti6nwOjLXltKdhqbQej0VY5Ah9RI37eGMYd3Wxe/iuHbpPOf8s5YWkPbt goNqsFU/hNsF7lKYLqdK/RJbIhJ0j3hzkZuHqGC1sOE25OIdbi8LU2tpevpudGEQe2a3 3UdqfnxBzzZFArljtFpgPulIDOWQ1PK4SjFamG8RXAHwF/sC4plpw8sf3edZDxqfycob lAWUX2hfORh2wMvosbVVtiWAM2WG72mGKdzFUuLa5l0oU59GbVkpNCrDT4eBY5RC0m5i CT29m4Py/8yabJfvwweyI1gaJtjT9soCVcMnbc9/SaF2wm0h03i4nTsm3SfiKcg4Qluf lVVw== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCW+1fn/lZJoHjoWf3402CDQunMmZL9eFaPL2AdOoWNP2ZlId14Gz2El7d7yfzFwBI/UcQ8t@ilbers.de X-Gm-Message-State: AOJu0Yyf6V9ofWvWscKUeTpbkXws7j3Ss07U/DpNLqUg6d8YgYUrig3Z uR8RUVH7coqCWnViChhccn8cD35pRfS5Sk3l9czrrInm5fNmYaCoa3Ak X-Google-Smtp-Source: AGHT+IGDVldnsRHXOE78UYMnn26U0M4lSPLN5+W48EUCouDK9FZxkk6XWzWU2zwkqYKaLbjV5Tk0aw== X-Received: by 2002:a17:906:9fc7:b0:b76:bb0e:5ac9 with SMTP id a640c23a62f3a-b7d23a96cbfmr1954565266b.40.1766042888537; Wed, 17 Dec 2025 23:28:08 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="AWVwgWa5eiSAw7ncnJQx3vmuUgfMM/jDAsslyBFqOSSV/BNf6A==" Received: by 2002:a50:ec94:0:b0:641:5a07:215b with SMTP id 4fb4d7f45d1cf-64b566018e3ls602226a12.2.-pod-prod-06-eu; Wed, 17 Dec 2025 23:28:06 -0800 (PST) X-Received: by 2002:a17:906:c146:b0:b79:ff94:50ff with SMTP id a640c23a62f3a-b7d23a9aa23mr2159090266b.34.1766042885958; Wed, 17 Dec 2025 23:28:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1766042885; cv=none; d=google.com; s=arc-20240605; b=ekrhcgxjZHoVtunJv0sJu4gHQIYLU7amZ57xXLNqEE+XuhH4lrIBh+Y2EGAmC0ogri 8F7CWajDSuE46XaRgBhC157xod1FWj4ptKx95raC+c+zN35GYxFMiSJ8xi9bYNU+2xEk bBP0msKVudquP0YMP/dSydHGKFNd4nD+3n5UYKKxCUml5wto1sjz9GaSM5lXGw7XL/Hq y24FvAO7kX+kq+Uo1P3RaCFUyPyuTghEu6TxH00LP5IZDj4ygWJxjdkIUQOQGYDQL8kZ 1r3jQ1RLkcBxsF9RN2HU5EPQ1WtYz3/oPviJZNbIWObQj1opRg3ZSHZSAOgbUjVW9jkT RqIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=wIdAOihUNGJmNH9r9G4uDzw2a1aHQixTEYdUNP2RZBQ=; fh=1CVrLft1NUK7i+Qmj9LcC8oEwjxh/KntDHf3/xpSZrw=; b=AU063UDKI7+PX6w9WDM7aBgRXIjbM13yvFrSd8FsebOE68YlJ25X9VsFD5j4023nI7 Y19JtOLAbel7cuLA1ZX620P79W+VqN4MIH0faWH+8+Seo2EiTbJdGPVL8CNeOJ2omPX/ 4+zC3Cx6xux7MeXrxZrw9SvRBnm7TUoHSxUflpxphd+l87KbRTugQS+baS8/Pwidz6sa WNHfGAu+SYK19wAODerx3j6ejOL4/b2/UoYKE+714nI249Aa6LTdQl7vZxoWZIB6BeYm 10sm0SW2Uy67xTu7JqCi1HRYWuGinMjNxq2Iddi/zrTlijiZt0Pi6RbbLd6Ep3v1J1xJ R6oA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-64b5882889bsi35993a12.5.2025.12.17.23.28.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Dec 2025 23:28:05 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5BI7S4gW008640 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Dec 2025 08:28:05 +0100 Message-ID: <03fe0f50-b239-4d2f-8825-4de8cd6e249d@ilbers.de> Date: Thu, 18 Dec 2025 09:28:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wic: support passing extraargs for EFI partition creation To: isar-users@googlegroups.com, Richa Bharti References: <20251217130253.947946-1-Richa.Bharti@siemens.com> Content-Language: en-US From: Anton Mikanovich In-Reply-To: <20251217130253.947946-1-Richa.Bharti@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: CptmYU1gF26u Hello Richa, 17/12/2025 15:02, 'Richa Bharti' via isar-users wrote: > Some EFI firmwares require FAT filesystems to use specific geometry or > sector parameters. > > Add support for an `extraargs` source parameter to allow passing > additional mkdosfs options when creating the EFI System Partition (ESP). > If no extra arguments are provided, mkdosfs defaults to "-S 512", > preserving existing behaviour. > > Signed-off-by: Richa Bharti > --- > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > index 446398d0..6862a288 100644 > --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > @@ -506,8 +506,10 @@ class BootimgEFIPlugin(SourcePlugin): > > label = part.label if part.label else "ESP" > > - dosfs_cmd = "mkdosfs -n %s -i %s -C %s %d" % \ > - (label, part.fsuuid, bootimg, blocks) > + extraargs = source_params['extraargs'] or "-S 512" This will fail with KeyError: 'extraargs' if no extraargs declared. > + > + dosfs_cmd = "mkdosfs -n %s -i %s %s -C %s %d" % \ > + (label, part.fsuuid, extraargs, bootimg, blocks) > exec_native_cmd(dosfs_cmd, native_sysroot) > > mcopy_cmd = "mcopy -i %s -s %s/* ::/" % (bootimg, hdddir) Moreover, features like this should be covered by some target or have a test\ case in CI. -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/03fe0f50-b239-4d2f-8825-4de8cd6e249d%40ilbers.de.