Re: [PATCH] Add missing WicError import

[Wadim Klincov <wadim@klincov.com>]

On 3/16/22 09:24, Henning Schild wrote:
> Am Mon, 14 Mar 2022 10:55:53 +0000
> schrieb Wadim Klincov <wadim@klincov.com>:
>
>> This patch adds the missing import of `WicError`, making any
>> potential errors when building wic images easier to understand.
>>
>> Signed-off-by: Wadim Klincov <wadim@klincov.com>
>> ---
>>   meta/scripts/lib/wic/plugins/isarpluginbase.py | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/scripts/lib/wic/plugins/isarpluginbase.py
>> b/meta/scripts/lib/wic/plugins/isarpluginbase.py index
>> 185e2ea..68af220 100644 ---
>> a/meta/scripts/lib/wic/plugins/isarpluginbase.py +++
>> b/meta/scripts/lib/wic/plugins/isarpluginbase.py @@ -8,6 +8,8 @@
>>
>>   import os
>>
>> +from wic import WicError
>> +
>
> This is already done in all the plugins we have in tree. The file you
> are touching here is "what we need to fork", and we do not need that.
> Or does the import in the existing plugins also not work?
>
> In case you need that in your custom plugin, just include the import
> into your own plugin. Maybe you do not even need that "base" lib for
> your custom plugin. Since it is ... what we need to fork. Not what we
> might need for our own plugins.
>

Thanks for your reply!

Do you mean `isarpluginbase.py` is something I, as a user, should fork
and change to my liking? Right now using `BootimgEFIPlugin` (or a
slightly modified version for better resolution) works great and it
wasn't clear that it's not something which should be used.

The issue on my side happens when `BootimgEFIPlugin` calls
`isar_get_filenames` and the kernel is not available for whatever
reason. In this case `isar_get_filenames` tries to raise `WicError`, but
since it's not imported directly in `isarpluginbase.py` a bitbake error
is thrown instead. It's still clear that the kernel is not available,
it's just not very readable.

> regards,
> Henning
>
>>   def isar_populate_boot_cmd(rootfs_dir, hdddir):
>>       # copy all files from rootfs/boot into boot partition
>>       # no not copy symlinks (ubuntu places them here) because
>> targetfs is fat --
>> 2.35.1
>>
>>
>
Wadim