From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7074908419729129472 X-Received: by 2002:a5d:5507:0:b0:203:e0a3:7016 with SMTP id b7-20020a5d5507000000b00203e0a37016mr982764wrv.575.1647421976197; Wed, 16 Mar 2022 02:12:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3c92:b0:389:e8c4:aef4 with SMTP id bg18-20020a05600c3c9200b00389e8c4aef4ls663407wmb.2.gmail; Wed, 16 Mar 2022 02:12:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhl/sOWX2lVHD75fGHpjfHOk+tZOotvRO4H1LvVC7rotDVa/lvgZzIcGqaMwSsWCdkZM+T X-Received: by 2002:a7b:c048:0:b0:38a:12dc:4694 with SMTP id u8-20020a7bc048000000b0038a12dc4694mr6409256wmc.80.1647421975283; Wed, 16 Mar 2022 02:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647421975; cv=none; d=google.com; s=arc-20160816; b=Xg/Dcqk5PdSwbYGwvplatIOrCXu2FY9NdQ/pKMglD2aWmbQNf9GZZbxWE74yn/nWN+ h40AR71mgBNIpHwdA03W54j/JLczeHqsPyNW4ppxKraYGdS4ts8DpTo04RkAm4a0s4vU oGRoCp/dZ2hnhV50KDFFHeqwvBhnDArfCu5GOG19MTVpp86jwh2EO6r+KYVyNwX/1cak n73zhwmb3tHedtjnWF5n5jCv0xLagxFk9aYkREzXP9HOtv7qbH3g60IhegU6SfFJ9TCN uPrPqY5WxlTAqf3ffwCCYVAwBPNU0Iup0jWqUFuscibalEstBD9ruj07rordAa+arFux vmvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=WpaW/MBtDAtalLjYWHXcU4t8VIvJXtbApmsaaJtTz5A=; b=eagUOihyMePB3jM2bzsGXY5ezYXzdYKziD/SF7ZJQFkzpWXTyah9EbkxY6ZfECB1zU XIrIeTK4sBD5VtBkFALmLSFjalmA7dXWYl50zd6WAq8pbVGLn0Pn3cSBIyHmVwBBbsXv jPhhcBf1Up5i+kS5zGLG702QyBs78aLYp3i3sDLeyCvcI2PsQs2Iq7e/a2Lg86fhmTvG r59XtU9KLgjSqKr/XwID4uzFLccBWJnu7S7qNlHbMmusdScKN9aUhW0xEXNOGnxiO54M 8wxW62UOVyOg90lkLVZNG4LCrApSb/jRYKbaAh0uwOEi3x8kJv78CXbj2H+1tCcdT3p2 GkQw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@klincov.com header.s=protonmail2 header.b=wMvRZT1Q; spf=pass (google.com: domain of wadim@klincov.com designates 185.70.40.22 as permitted sender) smtp.mailfrom=wadim@klincov.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=klincov.com Return-Path: Received: from mail-4022.proton.ch (mail-4022.proton.ch. [185.70.40.22]) by gmr-mx.google.com with ESMTPS id c3-20020a1c3503000000b0038c6c8b7facsi89664wma.0.2022.03.16.02.12.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 02:12:55 -0700 (PDT) Received-SPF: pass (google.com: domain of wadim@klincov.com designates 185.70.40.22 as permitted sender) client-ip=185.70.40.22; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@klincov.com header.s=protonmail2 header.b=wMvRZT1Q; spf=pass (google.com: domain of wadim@klincov.com designates 185.70.40.22 as permitted sender) smtp.mailfrom=wadim@klincov.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=klincov.com Date: Wed, 16 Mar 2022 09:12:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klincov.com; s=protonmail2; t=1647421974; bh=WpaW/MBtDAtalLjYWHXcU4t8VIvJXtbApmsaaJtTz5A=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=wMvRZT1QhBDFOgs61OjOq5m5CV5zzMCVvxDfl+zKXDC7yKnMYKSFvtHqq30NW4WM/ MaSXXqF+66EeY0ymgUX4ebZDYV9UTXFgADEsnwEnQa/1Kv4ApnLap+naCmrEYU3NcM pjOO8j4EB5pflK6MX1MaBIXVRNIBqbtLAs22h8fjbdyq5hsLc58ggrRpNOxOnN5Gnq ESZ7L+qzhE2h1uFXp7zAmuCaXn5LkJ3jNPN39Ky3cDNScpq5I3ZIZ90qJXt+BX0ICF /ohy78HVBaeY6eFirIazIp7R+/pDbPfPKVcywA8CynxFzyip6rsn1dBzYfC6C3RnWo qzYmTtYEv6ryw== To: Henning Schild From: Wadim Klincov Cc: isar-users@googlegroups.com Reply-To: Wadim Klincov Subject: Re: [PATCH] Add missing WicError import Message-ID: <05873484-d92b-59ca-e61b-faf1359a8c1c@klincov.com> In-Reply-To: <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> References: <20220314105543.100423-1-wadim@klincov.com> <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: pcUHliR87j0n On 3/16/22 09:24, Henning Schild wrote: > Am Mon, 14 Mar 2022 10:55:53 +0000 > schrieb Wadim Klincov : > >> This patch adds the missing import of `WicError`, making any >> potential errors when building wic images easier to understand. >> >> Signed-off-by: Wadim Klincov >> --- >> meta/scripts/lib/wic/plugins/isarpluginbase.py | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/scripts/lib/wic/plugins/isarpluginbase.py >> b/meta/scripts/lib/wic/plugins/isarpluginbase.py index >> 185e2ea..68af220 100644 --- >> a/meta/scripts/lib/wic/plugins/isarpluginbase.py +++ >> b/meta/scripts/lib/wic/plugins/isarpluginbase.py @@ -8,6 +8,8 @@ >> >> import os >> >> +from wic import WicError >> + > > This is already done in all the plugins we have in tree. The file you > are touching here is "what we need to fork", and we do not need that. > Or does the import in the existing plugins also not work? > > In case you need that in your custom plugin, just include the import > into your own plugin. Maybe you do not even need that "base" lib for > your custom plugin. Since it is ... what we need to fork. Not what we > might need for our own plugins. > Thanks for your reply! Do you mean `isarpluginbase.py` is something I, as a user, should fork and change to my liking? Right now using `BootimgEFIPlugin` (or a slightly modified version for better resolution) works great and it wasn't clear that it's not something which should be used. The issue on my side happens when `BootimgEFIPlugin` calls `isar_get_filenames` and the kernel is not available for whatever reason. In this case `isar_get_filenames` tries to raise `WicError`, but since it's not imported directly in `isarpluginbase.py` a bitbake error is thrown instead. It's still clear that the kernel is not available, it's just not very readable. > regards, > Henning > >> def isar_populate_boot_cmd(rootfs_dir, hdddir): >> # copy all files from rootfs/boot into boot partition >> # no not copy symlinks (ubuntu places them here) because >> targetfs is fat -- >> 2.35.1 >> >> > Wadim