Re: [PATCH 1/4] apt: Generate configs for apt

[Claudius Heine <claudius.heine.ext@siemens.com>]

On 10/05/2017 01:43 PM, Alexander Smirnov wrote:
> On 10/05/2017 02:14 PM, Claudius Heine wrote:
>> Hi,
>>
>> On 10/05/2017 12:08 PM, Alexander Smirnov wrote:
>>> Generate reprepro configuration files for apt deployment.
>>>
>>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>>> ---
>>>   meta-isar/conf/layer.conf                            | 10 ++++++++--
>>>   meta-isar/recipes-core/images/files/distributions.in |  3 +++
>>>   meta/classes/image.bbclass                           | 17 
>>> ++++++++++++++++-
>>>   3 files changed, 27 insertions(+), 3 deletions(-)
>>>   create mode 100644 
>>> meta-isar/recipes-core/images/files/distributions.in
>>>
>>> diff --git a/meta-isar/conf/layer.conf b/meta-isar/conf/layer.conf
>>> index 72a103c..0950a34 100644
>>> --- a/meta-isar/conf/layer.conf
>>> +++ b/meta-isar/conf/layer.conf
>>> @@ -1,5 +1,5 @@
>>>   # This software is a part of ISAR.
>>> -# Copyright (C) 2015-2016 ilbers GmbH
>>> +# Copyright (C) 2015-2017 ilbers GmbH
>>>   # We have a conf and classes directory, add to BBPATH
>>>   BBPATH .= ":${LAYERDIR}"
>>> @@ -13,6 +13,12 @@ BBFILE_PRIORITY_isar = "5"
>>>   # This should only be incremented on significant changes that will
>>>   # cause compatibility issues with other layers
>>> -LAYERVERSION_isar = "2"
>>> +LAYERVERSION_isar = "3"
>>>   LAYERDIR_isar = "${LAYERDIR}"
>>> +
>>> +# Codename of the repository created by the caching class
>>> +DEBDISTRONAME = "isar"
>>> +
>>> +# Path to the Isar apt repository
>>> +DEPLOY_DIR_APT ?= "${DEPLOY_DIR}/apt"
>>
>> Thanks!
>>
>> I would prefer that being handled the same way the DL_DIR and 
>> SSTATE_DIR is handled. So the same variable naming scheme (maybe 
>> APT_CACHE_DIR) and similar default paths (maybe "${TOPDIR}/aptcache"). 
>> The deploy dir is not really the place to do work in.
> 
> This should be in deploy directory, because "${DEPLOY_DIR}/apt" folder 
> contains self-contained apt repository that could be exported/published 
> by Isar user's demand, like images.

I took a look at how OE creates repositories and its similar to the way 
its implemented here.

I am not 100% sure that it makes sense to copy it from OE in this case, 
because we are using this repo differently (as a cache) than oe (just as 
a output of the package index) but I am willing to accept this solution, 
because people coming from OE might be more familiar this way.

Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de