From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7372454980134895616 Date: Sun, 26 May 2024 22:38:18 -0700 (PDT) From: Srinuvasan Arjunan To: isar-users Message-Id: <0614a93a-c275-42aa-9515-4e0aa8ed3f85n@googlegroups.com> In-Reply-To: References: <20240524065241.1393937-1-srinuvasan.a@siemens.com> Subject: Re: [PATCH] Drop redundant expand=True parameter from getVar MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_132455_1098804959.1716788298850" X-TUID: GQxhLgtJ3x6J ------=_Part_132455_1098804959.1716788298850 Content-Type: multipart/alternative; boundary="----=_Part_132456_2041126044.1716788298850" ------=_Part_132456_2041126044.1716788298850 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Friday, May 24, 2024 at 2:08:44=E2=80=AFPM UTC+5:30 Anton Mikanovich wro= te: 24/05/2024 09:52, srinuvasan.a via isar-users wrote:=20 > From: Srinuvasan A =20 >=20 > It is long True by default, but people keep adding new cases of this=20 > redundancy, hence fix this one.=20 >=20 > Signed-off-by: Srinuvasan A =20 > ---=20 > meta/recipes-kernel/linux/linux-custom.inc | 2 +-=20 > 1 file changed, 1 insertion(+), 1 deletion(-)=20 >=20 > diff --git a/meta/recipes-kernel/linux/linux-custom.inc=20 b/meta/recipes-kernel/linux/linux-custom.inc=20 > index 0d222332..433ed057 100644=20 > --- a/meta/recipes-kernel/linux/linux-custom.inc=20 > +++ b/meta/recipes-kernel/linux/linux-custom.inc=20 > @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?=3D "${@=20 d.getVar('BPN').partition('linux-')[2]}"=20 >=20 > # Determine cross-profile override=20 > python() {=20 > - if d.getVar("DISTRO_ARCH") !=3D d.getVar("HOST_ARCH") and=20 d.getVar("ISAR_CROSS_COMPILE", True) =3D=3D "1" and "class-native" not in= =20 d.getVar("OVERRIDES", True).split(":"):=20 > + if d.getVar("DISTRO_ARCH") !=3D d.getVar("HOST_ARCH") and=20 d.getVar("ISAR_CROSS_COMPILE") =3D=3D "1" and "class-native" not in=20 d.getVar("OVERRIDES").split(":"):=20 > d.appendVar("OVERRIDES", ":cross-profile")=20 > }=20 >=20 Hello Srinuvasan,=20 This was already fixed in next by:=20 7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE")= =20 Hi Anton, Yes, accidently created patch on master instead of next, sorry= =20 for the inconvenience, but still it's partially fixed in next, i will send= =20 v1 of this patch again. Thanks, Srinu =20 ------=_Part_132456_2041126044.1716788298850 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Friday, May 24, 2024 at 2:08:44=E2=80= =AFPM UTC+5:30 Anton Mikanovich wrote:
24/05/2024 09:52, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuv...@s= iemens.com>
>
> It is long True by default, but people keep adding new cases of = this
> redundancy, hence fix this one.
>
> Signed-off-by: Srinuvasan A <sr= inuv...@siemens.com>
> ---
> meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/r= ecipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?=3D "${@ d.getVar('BPN')= .partition('linux-')[2]}"
> =20
> # Determine cross-profile override
> python() {
> - if d.getVar("DISTRO_ARCH") !=3D d.getVar("HOST_ARCH") and d= .getVar("ISAR_CROSS_COMPILE", True) =3D=3D "1" and "class-native" not in d.= getVar("OVERRIDES", True).split(":"):
> + if d.getVar("DISTRO_ARCH") !=3D d.getVar("HOST_ARCH") and d= .getVar("ISAR_CROSS_COMPILE") =3D=3D "1" and "class-native" not in d.getVar= ("OVERRIDES").split(":"):
> d.appendVar("OVERRIDES", ":cross-profile")
> }
> =20

Hello Srinuvasan,

This was already fixed in next by:
7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMP= ILE")


Hi Anton,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Yes, accidently created patch o= n master instead of next, sorry for the inconvenience, but still it's parti= ally fixed in next, i will send v1 of this patch again.

Thanks,
Srinu=C2=A0=C2=A0
------=_Part_132456_2041126044.1716788298850-- ------=_Part_132455_1098804959.1716788298850--