From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623002413686063104 X-Received: by 2002:adf:81c7:: with SMTP id 65-v6mr361447wra.16.1542201811922; Wed, 14 Nov 2018 05:23:31 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b403:: with SMTP id d3-v6ls2831949wmf.4.gmail; Wed, 14 Nov 2018 05:23:31 -0800 (PST) X-Google-Smtp-Source: AJdET5dXqwKvkpxWQ7K3bAOdMzT6FrEySPf6LTEfHzLRruO2ew84hG+G/ZlXGMGMD4zhvWUfekDp X-Received: by 2002:a1c:f518:: with SMTP id t24-v6mr373387wmh.10.1542201811397; Wed, 14 Nov 2018 05:23:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542201811; cv=none; d=google.com; s=arc-20160816; b=p2IVNNYg6Kg/bfM7WJT0PKyuxWuMNFPl2gFfUPJd2hK07J247NeSZ1GLTTNGm2DPNM 64Ikicg3U/QnsG913JqEd2LUwmZ93rMbJ9I53RhMlEG3RvYebmryWDL0pyA2PN72NIte VTVutxadVW7PEBb14z9Q1g7Z9rvcIccHOKhgRaMBty2jeFGqmyZGL4DfWARuWpZ+UHjS OLL+vH2jIZbfYBmsigwaIxvr0Tg6NAwvJyOUp30XG5h9WLHmKS9STVqYzpsF8tbqoRyt ppRkvocrAI3i+GdukZrvOuoiuEWQdaaUdIOfxOVK8OHXeXeA2gUkDexBAneeGuQRJgK+ +PIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=WiFRuaWKdURfh8v8qi0ZywT62ElcWQViQ3GNW2qQlxM=; b=z9OtoLFRFHPGRijddomVZjynMyjIVUvGf3LpQoy99r9TZvtZ747CsMgzZunFT1zIgH Rym5wqklvjesd5QWRjD97Zs3KUY3Uqesrf8xbFlpOIRR+2OzHMlafVkT47b8UWYP1Wzu FnmlUboYU464805SRWEqK4ZS75Xkna4wAtfqB+Bb3efJhLApXezMZseXxyy/hH/0dAbL NPaEqvfBX1lFtatlYI6FzlqJYZZ9tE8g7ycr7ZJBzUMfIV/lpoiHy2tlsxfcuKzGjSFV hbJt+BmZDSF1hLY/SiNRwYh+Sz+rIe/Blq//4AtGYnJBwn+vXfDLHwj0pyTUNbxi1nSG NGkw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id p19-v6si512798wmc.1.2018.11.14.05.23.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 05:23:31 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id wAEDNUT3019491 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Nov 2018 14:23:31 +0100 Received: from [167.87.37.94] ([167.87.37.94]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAEDNTZH018902; Wed, 14 Nov 2018 14:23:29 +0100 Subject: Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking" From: Jan Kiszka To: Henning Schild , isar-users References: <20181112155149.24215-1-henning.schild@siemens.com> <20181112155149.24215-3-henning.schild@siemens.com> <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> Message-ID: <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> Date: Wed, 14 Nov 2018 14:23:28 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 28kOjmUOMC3W On 14.11.18 14:10, Jan Kiszka wrote: > On 12.11.18 16:51, Henning Schild wrote: >> We do not build as root anymore and the non-root uid/gid are now in sync >> between inside and outside the chroot. >> >> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e. >> --- >> meta/classes/base.bbclass | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index fce1084..d4082de 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >> >> # Unpack package and put it into working directory >> python do_unpack() { >> - import subprocess >> - >> src_uri = (d.getVar('SRC_URI', True) or "").split() >> if len(src_uri) == 0: >> return >> >> rootdir = d.getVar('WORKDIR', True) >> >> - uid = str(os.getuid()) >> - subprocess.call('sudo chown -R ' + uid + ' ' + rootdir, shell=True) >> - >> try: >> fetcher = bb.fetch2.Fetch(src_uri, d) >> fetcher.unpack(rootdir) >> > > This possibly causes this regression: > > ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed: do_install (log file is located at /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) > ERROR: Logfile of failure stored in: /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263 > Log data follows: > | DEBUG: Executing shell function do_install > | install: cannot remove '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image//lib/systemd/system/expand-on-first-boot.service': Permission denied > | WARNING: exit code 1 from a shell command. > | ERROR: Function failed: do_install (log file is located at /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.do_install.263) > OK, that wasn't a "clean" re-build (rather a rebuild after the Isar update). Retesting with the same Isar version for build 1 and 2. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux