Re: [PATCH v2 1/3] mmdebstrap: add "skip=cleanup/reproducible" option to mmdebstrap

["'cedric.hombourger@siemens.com' via isar-users" <isar-users@googlegroups.com>]

On Fri, 2025-03-07 at 22:59 +0100, Jan Kiszka wrote:
> On 07.03.25 13:25, srinuvasan.a@siemens.com wrote:
> > From: srinuvasan <srinuvasan.a@siemens.com>
> > 
> > Without this option, mmdebstrap deletes the var/log/dpkg.log and
> > its siblings by default,
> > but this is needed to download deb-src packages for base-apt
> > creation.

I don't see where deb-src needs dpkg.log. Can you shed some light?
Both the old code and the code I recently changed parse the .deb files
that were downloaded to determine which source packages should be
downloaded

Ref: https://groups.google.com/g/isar-users/c/OwrSBmCPe0Y

> > Basically, we are referring to the package's status under
> > /var/log/dpkg.log file
> > and performing the debsrc_download operation.
> > 
> > Without these changes, bootstrap related deb-src files are not
> > downloaded
> > under the /downloads/deb-src folder, due to this the repo sanity
> > check
> > functions failed during base-apt caching stage.

What are these repo sanity checks?
Where do we see the failures?

From my base-apt workdir:

pwd && grep -ir error
<...>/build/base-apt/tmp/work/debian-bookworm-any/base-apt/1.0-r0/temp
run.repo.7287:		echo "ERROR: $*"

We probably need to be more specific if we are mentioning a failure.
Without this, people on this list will not understand what problem(s)
you are fixing

> > 
> > Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> > ---
> >  meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> > b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> > index 931f6f13..7380a658 100644
> > --- a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> > +++ b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> > @@ -168,6 +168,11 @@ do_bootstrap() {
> >          arch_param="$arch_param,${COMPAT_DISTRO_ARCH}"
> >      fi
> >  
> > +    cleanup=
> > +    if [ "${@bb.utils.contains('BASE_REPO_FEATURES', 'cache-deb-
> > src', 'yes', 'no', d)}" = "yes" ]; then
> > +        cleanup="--skip=cleanup/reproducible"
> > +    fi
> > +
> >      # Cleanup mounts if fails
> >      trap 'exit 1' INT HUP QUIT TERM ALRM USR1
> >      trap '[ -r "${WORKDIR}/mmtmpdir" ] && tmpdir=$(cat
> > "${WORKDIR}/mmtmpdir") \
> > @@ -183,6 +188,7 @@ do_bootstrap() {
> >  
> >      sudo TMPDIR="${BOOTSTRAP_TMPDIR}" mmdebstrap $bootstrap_args \
> >                     $arch_param \
> > +                   $cleanup \
> >                     --mode=unshare \
> >                     ${MMHOOKS} \
> >                     --setup-hook='mkdir -p
> > "$1/var/cache/apt/archives/"' \
> 
> What has changed in this version? I'm not seeing my concerns
> addressed,
> my questions answered.

+1 

Please make sure new revisions of your patch series include a changelog
(use --cover-letter with git format-patch)

> 
> Jan
> 


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/06c431535ff06f5f854f8f846dd511db1c5c82be.camel%40siemens.com.