public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	<isar-users@googlegroups.com>
Cc: <vijaikumar.kanagarajan@gmail.com>
Subject: Re: [PATCH v2 2/2] refactor linux-custom.inc to use ISAR's DEB_BUILD_PROFILES support
Date: Tue, 4 Jan 2022 12:25:35 +0100	[thread overview]
Message-ID: <06db8b2f-7a7d-8b97-2122-9ec3b73ec9a9@siemens.com> (raw)
In-Reply-To: <20220104100235.719079-3-felix.moessbauer@siemens.com>

On 04.01.22 11:02, Felix Moessbauer wrote:
> This patch replaces the manual setup of the DEB_BUILD_PROFILES
> environment variable in the linux-custom.inc recipe.
> Instead, the recently introduced DEB_BUILD_PROFILES infrastructure
> of ISAR is used.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/recipes-kernel/linux/linux-custom.inc | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index ed89aa09..5ac08487 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -117,6 +117,15 @@ def config_fragments(d):
>              fragments.append(local)
>      return fragments
>  
> +def get_additional_build_profiles(d):
> +    profiles = d.getVar('BASE_DISTRO', True)
> +    if d.getVar('KERNEL_LIBC_DEV_DEPLOY', True) != '1':
> +        profiles += ' nolibcdev'
> +    return profiles
> +
> +DEB_BUILD_PROFILES += "${@get_additional_build_profiles(d)}"
> +DEB_BUILD_PROFILES_CROSS += "${@get_additional_build_profiles(d)}"
> +

As said on patch 1: Having to set two vars in recipes is needless
boilerplate logic.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

      reply	other threads:[~2022-01-04 11:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 10:02 [PATCH v2 0/2] add support for debian build profiles Felix Moessbauer
2022-01-04 10:02 ` [PATCH v2 1/2] " Felix Moessbauer
2022-01-04 11:24   ` Jan Kiszka
2022-01-04 12:13   ` vijai kumar
2022-01-04 10:02 ` [PATCH v2 2/2] refactor linux-custom.inc to use ISAR's DEB_BUILD_PROFILES support Felix Moessbauer
2022-01-04 11:25   ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06db8b2f-7a7d-8b97-2122-9ec3b73ec9a9@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=vijaikumar.kanagarajan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox