From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a05:620a:1708:: with SMTP id az8mr35573425qkb.142.1641295540189; Tue, 04 Jan 2022 03:25:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a0c:e40e:: with SMTP id o14ls15987312qvl.10.gmail; Tue, 04 Jan 2022 03:25:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTu5F7uu7ihsA8dbSkaibrza9JV4h4EZ8nWXbhs0lYCknq6d7xYuH3abEQx9tUtRrx/CXA X-Received: by 2002:a05:6214:2307:: with SMTP id gc7mr25013373qvb.7.1641295539645; Tue, 04 Jan 2022 03:25:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1641295539; cv=pass; d=google.com; s=arc-20160816; b=XK9dbVIbLiKy7drnSfkTHSip+h0cpHiyE87/vDuqIhprihzNfA1xOu3NQoZ5RzMBBb bdFc9puTd/m8fS+ce+bysILI4KFI+M/y463YO/lf736Ykq+3JEjjia5Ba6gEJpB12a+/ omBdrbmmAOUSYvTZzCM4jz8Fzmq8VttGC/fqroCPS5VrVmUsYQEku0PyVUUDo1EzrTYT X67UeclbCC3DMAWh6KF9e8Egw4vBLRGVeLS/Oz2TahFfEEQd7Mgi+WkxOuxysey+0TtQ 8bCjaAiZljrkNgh8F5Egsj/2Y6LLTCcORHkyUZfKLFVUWuXjyfs/Y9+kVcIEvbVkOJBS f2Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=PjHwxEyJMQeQbWsL5xzwlHHCQKz3Lom1UhhWK2dluuo=; b=X3F8ZkN4dyGfLxmb8GgvQxiEI6qLi8149nbXgKmiykMvwdyDUraiUh+a40nw8IlnL6 zpnRLKp/j1ZaztAxmmTZFsu+t8t1FZyPb1mZaED1b2lDcmZh+h9v+D9yd37t0vfGKdT1 iyqMYYI0Yd687lopOiU+wMK4gygyxqtljumjoOuI6e9wQZGGkO8KQgrA751sdWLDwDUN vqJJb8eYaM+KhAkin3ZfV+MXnKU+0w+ruOLUZ42HwQ7spdVZ2M7pMefL1HWxglgfqx0A VDA2YjjM22gx95e88gJEyB5U4hCR0jWcHAhwJOPmGLKonRA8j/6uG7J3kekVTGZHZ2a0 1jNg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=x+lNIUx4; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.6.62 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60062.outbound.protection.outlook.com. [40.107.6.62]) by gmr-mx.google.com with ESMTPS id f23si4034318qkg.1.2022.01.04.03.25.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jan 2022 03:25:39 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.6.62 as permitted sender) client-ip=40.107.6.62; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=x+lNIUx4; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.6.62 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bTZn/CNqrdt2YdZAPr6n3WyXSX3q67QVDO49/7/KNTfPPDqky7ytwfZynB9in8/s5QqCyDLrrZJGVFPYHSSluKhHl2cpY9wFpn7s9XOFPrdFgVfY6r8vVAP1nSpNNE1X1q4td959sD0coqYjiDExAqbfgGEZeVK0UnuO2ATXVuonNXxXOem7C2okTr+l414InOrV3J7rQT9UqifEUJ1F1hbwpmu9yyEHfqr1uwLeuD1HHWKB+toPjbcIUrPxmaWSl1zbMOE6GQLvKRDx7P1lohamSwOvHfrazOm6ZeDwabB6mfOQXOtwjH9EF71n/9qmyJ5zWIo0WqdXE06NkzeRXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PjHwxEyJMQeQbWsL5xzwlHHCQKz3Lom1UhhWK2dluuo=; b=a1N1F1OZML2y9YuDILiPVdx2YXU4XGGytsD73sycTgveSfJhFkG+oyvNgLUx+OS9DnLMxUy/qo1NDD9t6Wa3a033iD6U6EOK+78ivGIATVVYYq8xZhYQDNv+/W7vbE6vmQDlYPJWiNFVxh6BFcgk4uAfKoWzjkvWtd2O68Sp63RobVKMl1bUelh+GBpQE5naSozIj05uM63iDF4c5YBtFxxYMY/6xSJR/CiqhsN1vdqLKk00x4tGgm2usdKm+ew0AKiAspuJ/AfbDxJqE+IMd6v8ZGPR7OV07TyTql9Tr1/FXnWFU64gv7R8jyJzMhZmbvGXtDOfBjF0CAkdDDLoFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PjHwxEyJMQeQbWsL5xzwlHHCQKz3Lom1UhhWK2dluuo=; b=x+lNIUx4gTtX3Z5+fGZMYLt1xEKAM3HNw/TVMxE/2HZFyCd13SP38JNTJNTfYlw6oLxVoAl1FQdlampt5RE/u2c1MvXl4MX7ILYQcmwExXffHzLN7xaiqh+IukoEgDSOc9YARdZOnsd+9rM6BdcaMGVlfY6Vq3agfI41NlLiN8Q7DJK4HVcmm88bB7MyoL15KFdEAVc1VFdLNVt+yp0zIA6n0/+LxTbZEkUSPuMFf0oBKyoEV15GUzGzEmK09nwfTh67vdHekyltnFslHGIkQCr5pbuH+vAEk8aYJZ6MZ3E+A1SpI/E9j0NdKxzyv+j3O6pbKDHG6a0mIUsJIvYMTw== Received: from DB6P195CA0024.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::34) by HE1PR1001MB1227.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:3:e9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Tue, 4 Jan 2022 11:25:37 +0000 Received: from DB5EUR01FT004.eop-EUR01.prod.protection.outlook.com (2603:10a6:4:cb:cafe::77) by DB6P195CA0024.outlook.office365.com (2603:10a6:4:cb::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14 via Frontend Transport; Tue, 4 Jan 2022 11:25:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.72) by DB5EUR01FT004.mail.protection.outlook.com (10.152.4.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4844.14 via Frontend Transport; Tue, 4 Jan 2022 11:25:36 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 4 Jan 2022 12:25:36 +0100 Received: from [167.87.32.20] (167.87.32.20) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 4 Jan 2022 12:25:35 +0100 Message-ID: <06db8b2f-7a7d-8b97-2122-9ec3b73ec9a9@siemens.com> Date: Tue, 4 Jan 2022 12:25:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 2/2] refactor linux-custom.inc to use ISAR's DEB_BUILD_PROFILES support Content-Language: en-US To: Felix Moessbauer , CC: References: <20220104100235.719079-1-felix.moessbauer@siemens.com> <20220104100235.719079-3-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: <20220104100235.719079-3-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.20] X-ClientProxiedBy: DEMCHDC89YA.ad011.siemens.net (139.25.226.104) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6104855d-8e1a-45b9-4d7c-08d9cf74ee16 X-MS-TrafficTypeDiagnostic: HE1PR1001MB1227:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /fS7kFzxFMMacKVgCazyicFMZbdXRHURVZXrF5SxvXOzva6bFs3R0AXaqLLeR1v595un9vXPCNsPHHxeYa39Ew4qgepDHlkgKKThSPi2/P51HiyykCyQQiJ/WhPE0Epn38dIux3sWRsBh5a6Ig0vxAjV3/sWABmoBNpk50flOoTDieVWFmfUKsnowCZeCKdCFwn65owITr0ojhug9mWIXmDlFzhJ02e7obZ/KFjATn/8GfN0G8q+8g2qInXUc6vjZwFmfyANVD6xhhXQwqKXFOllxDW7+H/DAhiwL7CmoeTwsCg6jXkc9U1ucmPSezzGAm9ndygz/OVtEsSi/EO6y2f9vSO98ADTMqI3Wzl3cgO1AnC5JT8uynwhxhfJsRogSaQJ7SSIrp/140qOQhxk++QGLb6ni/2hQOYk7jl3uHAe3dtp2M779BNgXFmx0pxz5vZpX4DXVzXGesMKi4wARJ1W27BfwLKNE4+j3JWaDoPyioHZxIBAuCHVwyXi0nQVvwlsX50bsFFWt+e9iNQMtpuqP3QeOtfSL7HNtrA/WHE16/jszdyeLk/FE4BxdICiQ/yJyoli0Wt9uvM2m19mFECy/NQoJLNgGkCtpXL6DtXB4uckxtPpK+4B1eEeQffpGTEyWl10gXQZYdj+N7PPJYruuUmWGge4DML1opfEykUjTjBCMtqosuhbVwmRduEQTpSxEU6ebn4bObQYMKv3qCPaO8q9e86Fj962XeNIOsk0kEYZeGPs1Ofc6HZAFcp9PobnLkc8lABENvZdMbP4aQxxui9+Ot7EImMHZnl41Fger2wNGn/XqboGyWJEbN80/yEfKpNs0ZEgK17SigVMLMd42vcSZ4hGkbxJEVYya3Q= X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(40470700002)(46966006)(36840700001)(16576012)(356005)(36860700001)(2906002)(70206006)(70586007)(186003)(86362001)(5660300002)(956004)(83380400001)(110136005)(82310400004)(31696002)(47076005)(316002)(4326008)(31686004)(2616005)(44832011)(336012)(82960400001)(53546011)(81166007)(508600001)(36756003)(26005)(40460700001)(6706004)(8676002)(8936002)(16526019)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 11:25:36.6462 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6104855d-8e1a-45b9-4d7c-08d9cf74ee16 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT004.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR1001MB1227 X-TUID: AXH+V/Yy17c1 On 04.01.22 11:02, Felix Moessbauer wrote: > This patch replaces the manual setup of the DEB_BUILD_PROFILES > environment variable in the linux-custom.inc recipe. > Instead, the recently introduced DEB_BUILD_PROFILES infrastructure > of ISAR is used. > > Signed-off-by: Felix Moessbauer > --- > meta/recipes-kernel/linux/linux-custom.inc | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index ed89aa09..5ac08487 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -117,6 +117,15 @@ def config_fragments(d): > fragments.append(local) > return fragments > > +def get_additional_build_profiles(d): > + profiles = d.getVar('BASE_DISTRO', True) > + if d.getVar('KERNEL_LIBC_DEV_DEPLOY', True) != '1': > + profiles += ' nolibcdev' > + return profiles > + > +DEB_BUILD_PROFILES += "${@get_additional_build_profiles(d)}" > +DEB_BUILD_PROFILES_CROSS += "${@get_additional_build_profiles(d)}" > + As said on patch 1: Having to set two vars in recipes is needless boilerplate logic. Jan -- Siemens AG, Technology Competence Center Embedded Linux