From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026294254479605760 X-Received: by 2002:a05:6000:1541:: with SMTP id 1mr6014658wry.347.1636437714197; Mon, 08 Nov 2021 22:01:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:23c8:: with SMTP id j191ls695490wmj.1.gmail; Mon, 08 Nov 2021 22:01:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiWguBPJynsCxK1tEwzxGYJleBH8CuGxfAmohm4izNs05BUSra7c3ER4m8m1DkCK57aDNb X-Received: by 2002:a05:600c:3584:: with SMTP id p4mr4382761wmq.65.1636437713194; Mon, 08 Nov 2021 22:01:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636437713; cv=none; d=google.com; s=arc-20160816; b=yz8/2Q4sCJSxlewy5hTqHZJLHYjCO7TpJH1kiaRSYcz+haTVxANnNR8bQUzIdiLc31 3QH9G7ZIlmDFfN5jaBOmi+6Q7bKwxK9prbhocHVouGEVOZzGtJtk2cYK/ZztfC0uipR+ Mgj3epo7uzlyWVKHnvLIP35G9ZWi9HqI0uHhgph9Sdn56CypJ2E8MQKEoPLwz5FBOIV/ VRrJs/5jUQyJlDmIU1LCCTYVLwK9ckP6D8ZXM8Qggk3XvH/qdXWk8ygPPrJR+4Wr2dOb acetd/wy7JTKYbzx9X/VrNccV7x85Vpoi/cCIttViKWxHon8HFI80uBQPJHLR1kmBI54 DB0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=hTFugGV+l0KqlLskJ/mjZ2rLAQXAtLR1zdedp0OHa1A=; b=XH3YnJf7oz2mhNVADqAYhWQPEsOs12uAo7b0U88tBpIqWU4xpMomo3WlWfFhNwjMq9 eeiqX641F/ygdyIcAwqyXgRjvWkQpfusj73a3LEML1gGZ5GYuoQljcwpIx2FWiRb6ZEB EXdt2XACjCcA1TWTttNGj4r3W8Bt5gjzwcUr21syvD+94vhFXaSrRbYC/3bsrRG6ASqM fRw/1TVyiL8d9otJLt1nC6fDw4vM5s95NSD2Npqgl7FNHF9fCUJPQDxrAHYKE4JsxXd7 650DW09e/fngl6bgQ37E1/niI6JIfmGe5r3tJqPaWZaKTDRTrFwz6ABr5zWmYnZm04Vf lfkA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id d9si675656wrf.0.2021.11.08.22.01.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Nov 2021 22:01:53 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 1A961qPD013434 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Nov 2021 07:01:52 +0100 Received: from [167.87.75.31] ([167.87.75.31]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1A961p2f014170; Tue, 9 Nov 2021 07:01:52 +0100 Subject: Re: [PATCH v3 2/2] u-boot: Move libssl-dev dependency to u-boot-custom To: Vijai Kumar K , isar-users@googlegroups.com References: <20211105061521.2142204-2-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-1-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-2-Vijaikumar_Kanagarajan@mentor.com> From: Jan Kiszka Message-ID: <07718b5f-1186-d912-419e-9dac134f9367@siemens.com> Date: Tue, 9 Nov 2021 07:01:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211106121203.3210294-2-Vijaikumar_Kanagarajan@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: HF2HRDGLbu9G On 06.11.21 13:12, Vijai Kumar K wrote: > Move the libssl-dependency to u-boot-custom.inc. > > Signed-off-by: Vijai Kumar K > --- > meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc | 3 --- > meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > index 158c297..f3f822a 100644 > --- a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > +++ b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > @@ -5,9 +5,6 @@ > > require recipes-bsp/u-boot/u-boot-custom.inc > > -DEBIAN_BUILD_DEPENDS += ", libssl-dev:native" > -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > - > SRC_URI += " \ > https://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \ > " > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > index 9984d8c..57d4f36 100644 > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > @@ -24,7 +24,9 @@ python() { > d.setVar('DEBIAN_BUILD_DEPENDS', d.getVar('BUILD_DEPENDS')) > } > > -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > + It would feel more logical to me to put the :native part under the cross-compile condition. The outcome will be the same, but :native is a redundant statement in the native build case. Jan > > TEMPLATE_FILES = "debian/control.tmpl" > TEMPLATE_VARS += "MACHINE DEBIAN_BUILD_DEPENDS" > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux