From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631790245711970304 X-Received: by 2002:a19:d8c6:: with SMTP id r67mr2206319lfi.3.1544083991613; Thu, 06 Dec 2018 00:13:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:2d4f:: with SMTP id t15ls2207192lft.2.gmail; Thu, 06 Dec 2018 00:13:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wm7haMt3NM3fNyvXf+e2gkJGNPftrDiQ6guec9vpW6KfpsWEKs12OBPU3U1YdwgxjcQDyO X-Received: by 2002:a19:5519:: with SMTP id n25mr2207554lfe.1.1544083990882; Thu, 06 Dec 2018 00:13:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544083990; cv=none; d=google.com; s=arc-20160816; b=K43LNwYK6C18IFkNBg7Q49XiCpWc28KbIEJqTYl/OOkS3kXIqe1zgCfiGxrP8BIoiW +jWljwJQ9k0OjnKiXHGu0wo9mygwZTLeDVpTYeHEletw21Z0JuxeBJMFBHeGECn0GJRK q/UgJFN0nel45qCbm/i3tg0JuvSb/QWbgv5qoNfl63edinuhSUtAoRx0v74ZLUsZF1Df qOnRjDIf4/ELbol3+QrZxs+oX4JWEarzfwSpN0snv1rVYCbO6GOxgcrE2Gsdu0YRbDmH +TS0x+OZ9zUvFVQDVbwCGRs/FljSPvGII8iHP1z56+Fs1BL0ZN0MLbFX6to2lsKNIDQz Ii8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:mime-version:user-agent :date:message-id:subject:from:cc:to; bh=7f7vA7oRjZtIgnqeTsI9vPr0PBHFWV81xXX18jXfeqE=; b=Jl3i0Qslu0/rnlV1ZYt1jHG2yRVj0k2l9EAQI2UO866lXejDDyvR7SRC8rwgMlAZVQ 8pmS+PpFLlzkuIKbNSHXRayXJFCRuXQ5O5ToVfEmL4lZF7Mkhy/bK949SymPdvXznUtY RZBP074ifNGVa9tHEYbXNdwh/oUc46NSn+omid983ueL5fUn/Ku/x5gfEyWRZQwM6Q2O OgCkBY8U4CU5gWYpPY62m0HHpXE1gewacqO+6edlmodRpm0wRDAt63oxDtwwMvLm+GdU NArzCQ5ZU3yFfJxWrERc4kk7gQzqW0WyrwqLBXqGTH9aqo7SRNOukBWrb2g4Dv+HayuO 4m0w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id t5-v6si639454lje.3.2018.12.06.00.13.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Dec 2018 00:13:10 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id wB68DAwt013372 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Dec 2018 09:13:10 +0100 Received: from [139.22.40.220] ([139.22.40.220]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB68D9XG007319; Thu, 6 Dec 2018 09:13:09 +0100 To: isar-users Cc: Cedric Hombourger From: Jan Kiszka Subject: [PATCH] isar-image: Make do_rootfs normal shell function Message-ID: <07d197fb-ce72-ae62-4497-706221fbdeec@siemens.com> Date: Thu, 6 Dec 2018 09:13:09 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: GDZRTEZtdlLP This restores logging support for the invoked subroutines which is more important then the convenience to chose python for overloading any of them. Signed-off-by: Jan Kiszka --- As it was the second time this annoyed me, remove this anti-pattern. meta/classes/isar-image.bbclass | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass index 14b97dd..81738ff 100644 --- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -69,9 +69,9 @@ isar_image_cleanup() { fi } -python do_rootfs() { - bb.build.exec_func("isar_image_gen_fstab", d) - bb.build.exec_func("isar_image_gen_rootfs", d) - bb.build.exec_func("isar_image_conf_rootfs", d) - bb.build.exec_func("isar_image_cleanup", d) +do_rootfs() { + isar_image_gen_fstab + isar_image_gen_rootfs + isar_image_conf_rootfs + isar_image_cleanup } -- 2.16.4