Re: [PATCH v4 0/8] imagetypes

[Jan Kiszka <jan.kiszka@siemens.com>]

On 04.05.22 10:09, Bezdeka, Florian wrote:
> On Wed, 2022-05-04 at 10:51 +0300, Anton Mikanovich wrote:
>> 28.04.2022 09:06, Adriaan Schmidt wrote:
>>> This series introduces image types and conversions as known from OE.
>>> The main motivation is to provide a more flexible way of generating
>>> and processing images, without the need to insert custom tasks (e.g.,
>>> currently we have custom classes adding tasks for things like bz2 or xz
>>> compression of images in several downstream layers).
>>>
>>> These patches have been tested on some of our layers, and also
>>> work with some more "challenging" use cases like image-in-image recipes
>>> and custom image types brought by layers.
>>>
>>> This only has a bare minimum of conversions (gz, xz), so there should
>>> probably be follow-ups for additional compressions, or things
>>> like checksums, which can also be nicely done with this.
>>>
>>> - p1 prepares by removing image-type-suffix from image build directories,
>>>    which enables sharing of the completed rootfs across image types
>>> - p2 refactors the SDK, and makes it an image feature instead of
>>>    a separate recipe (has been discussed here a while ago)
>>> - p3 does the actual work, but keeps all original files
>>> - p4 moves code to different files
>>> - p5 adapts meta-isar
>>> - p6 removes IMAGE_FSTYPES as a dimension in multiconfig. Now that
>>>    we can build multiple types from one rootfs, multconfig is
>>>    just the wrong way of doing this (also been discussed here).
>>> - p7 documents
>>> - p8 adapts start_vm tests
>>>
>>> changes since v3:
>>> - better handling of xz compression options (taken from OE)
>>> - fix IMAGE_FSTYPES append in qemuamd64-bullseye.conf
>>> - add patch to adapt start_vm to new image type and file names
>>>
>>> changes since v2:
>>> - fix bug where construction of IMAGE_BASETYPES was not recursive
>>> - add comment explaining IMAGE_BASETYPES
>>> - fix ISAR_CROSS_COMPILE exception for ubifs+armhf
>>> - use "IMAGE_CLASSES +=" instead of "INHERIT +=" in machine configs
>>> - fix whitespace errors in documentation
>>>
>>> changes since v1:
>>> - rebase
>>> - fixed naming issue in wic.bmap files
>>> - more reasonable default settings for xz
>>> - add documentation to user manual
>>>
>>> Adriaan Schmidt (7):
>>>    image: remove IMAGE_SUFFIX
>>>    image: refactor SDK
>>>    meta: introduce IMAGE_CMD_*
>>>    imagetypes: restructure files
>>>    imagetypes: switch meta-isar to the new scheme
>>>    meta-isar: remove IMAGE_FSTYPES from multiconfig definitions
>>>    docs: add new imagetypes to user manual
>>>
>>> Anton Mikanovich (1):
>>>    start_vm: update image types checking
>>>
> 
> [snip]
> 
>>>
>>>
>> Applied to next, thanks.
>>
> 
> My understanding is that all downstream layers have to update
> IMAGE_FSTYPES (mainly remove "-img"). Isn't that something that should
> make it into a changelog? Maybe into the "recipe API changelog"?
> 

Yes, please, that will help downstream a lot.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux