Re: [PATCH v3] wic-image: Fix up file ownership in isar repo after wic run

[Jan Kiszka <jan.kiszka@siemens.com>]

On 12.09.18 14:49, Henning Schild wrote:
> Am Thu, 23 Aug 2018 14:12:19 +0200
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> This prevents needlessly leaving the __pycache__ directories
>> root-owned behind after running wic as superuser - will only cause
>> troubles to the user when trying to clean up the isar repo.
>>
>> We update the ownership only for selected subdirs of the repo to avoid
>> touching local files.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Changes in v3:
>>   - catch ALL relevant folders (first test, then post - hmpf)
>>
>>   meta/classes/wic-img.bbclass | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/wic-img.bbclass
>> b/meta/classes/wic-img.bbclass index b56df7b..bc405c1 100644
>> --- a/meta/classes/wic-img.bbclass
>> +++ b/meta/classes/wic-img.bbclass
>> @@ -71,6 +71,7 @@ do_wic_image() {
>>       export MTOOLS_SKIP_CHECK=1
>>   
>>       sudo -E chroot ${BUILDCHROOT_DIR} ${ISARROOT}/scripts/wic create
>> ${WKS_FILE} --vars "${STAGING_DIR}/${MACHINE}/imgdata/" -o /tmp/ -e
>> ${IMAGE_BASENAME} ${WIC_CREATE_EXTRA_ARGS}
>> +    sudo chown -R $(stat -c "%U" ${ISARROOT}) ${ISARROOT}/meta
>> ${ISARROOT}/meta-isar ${ISARROOT}/scripts cp -f `ls -t -1
>> ${BUILDCHROOT_DIR}/tmp/${WKS_FILE}*.direct | head -1`
>> ${WIC_IMAGE_FILE} }
> 
> This breaks if ISARROOT is mounted ro, chown will fail with "read only
> file system" and there will not even be any __pycache__ things to chown.
> 
> Steps to reproduce:
> git clone isar
> cd isar
> mkdir out
> docker run -v $(pwd):/this/:ro -v $(pwd)/out:/out:rw -e USER_ID=$(id
> -u) --rm -t -i  --cap-add=SYS_ADMIN --cap-add=MKNOD -e
> http_proxy=$http_proxy -e https_proxy=$https_proxy  -e
> ftp_proxy=$ftp_proxy -e no_proxy=$no_proxy $CONTAINER sh -c bash
> docker> cd /out
> docker> source /this/isar-init-build-env
> isar> bitbake <a wic image>
> 

Valid remark, and I just realized that I recently hacked this effect away 
locally by adjusting some docker script.

Should be easy to fix by allowing that command to fail. Mind to write that 
one-liner and test it?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux