From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6644847399572340736 X-Received: by 2002:a1c:208c:: with SMTP id g134mr545006wmg.23.1547134293215; Thu, 10 Jan 2019 07:31:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4987:: with SMTP id w129ls1704061wma.13.gmail; Thu, 10 Jan 2019 07:31:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN6IZMHuyQCVUv0FOQePLpGJ2PUfyrHR0sa3fNfMgie39NDP3SFjKYbYP9b3Su7+CUcmqE1C X-Received: by 2002:a1c:f718:: with SMTP id v24mr552049wmh.4.1547134292832; Thu, 10 Jan 2019 07:31:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547134292; cv=none; d=google.com; s=arc-20160816; b=EN4tZ+58J6hA3PguEyF9mwl2yTGGx4EmrvWRIAWJjTYBcpAw1CfpHjFXUxZ884ix1w PES/cwVtq1asaFBLE1ggeaOfAOgEdTe0tFE9BsAHpQyjg81pd7DQdMSlVrohS8wSbSGH MS8k/FkDf6Hr6aNwQB3WHQehepHh5PLhUaB7mW14w+IDHBFo8hU7Q7pux+9xySIr6mIA LQBDUxYGvuucVCQhFzGHaAAyQq9hHEltxJqOZZDpY87fLQc+3p0wY2koGOlpSYCKmJYP PShqmyMDQf4+vKuBmJ0uNDesdAdO42N05DJvWBITXWS1IfiEz6dOxBgUYjrBUyRUio+V xLzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=GD4NVvfbiqpE81sThW4eh/BDEcGUZYfaIXJBcW4NzxY=; b=fZ7K7yjv40xRrk2txy+dBPk2ulmhG+GnBmeky4N8K5dMa6UdFF+K5YC2QEGXiOSfEj UGIeZAc4WsyLHA5O1Bxmn5DT/Z/CIxy2IsG/xPy0PI8lorXgwDYvx42rZEGDpYWlaWzI P65viq9KF9xNVDTps4QelsCQSruE8OfK/Z9ZPPD0XeuaQhE77WB3wFzjMS6ud28bEFNq PiarBuoxhT64PFS68RA00FNvWHLlxbgRs319OyfcGZTBZ6hDNxsG9SgBvVUojDigHLtb GICIba3xnTQ5b10MsKlayE6vpW757Z8ZPPvqPggtZQ7rH+d4DamwiBU8UuHe08lWEDOX El1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id t23si142971wmt.1.2019.01.10.07.31.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jan 2019 07:31:32 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0AFVWrO030775 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Jan 2019 16:31:32 +0100 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x0AFVV2t023514; Thu, 10 Jan 2019 16:31:31 +0100 Subject: Re: [PATCH v2] Fix wrong inline python in isar-image.bbclass To: "[ext] Andreas J. Reichel" , isar-users@googlegroups.com References: <20190110150351.27270-1-andreas.reichel.ext@siemens.com> From: Claudius Heine Message-ID: <0915ae2d-f72c-34ba-1997-0b50414cb2dc@siemens.com> Date: Thu, 10 Jan 2019 16:31:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190110150351.27270-1-andreas.reichel.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ckJmedDjwKjH Hi, On 10/01/2019 16.03, [ext] Andreas J. Reichel wrote: > From: Andreas Reichel > > The inline python string used a mixture of python > and shell, which failed while parsing recipes with: > > The URL: '${@' is invalid and cannot be interpreted > > Problem is that in > > SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" > > ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly. > Use d.getVar instead. For people wanting to reproduce this issue, AFAIK Andreas tried to use a custom distro config script. Maybe that only happens there. Would be nice to have a test case for that. Cheers, Claudius > > Signed-off-by: Andreas Reichel > --- > meta/classes/isar-image.bbclass | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass > index 754e896..e221ba6 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -6,8 +6,14 @@ > inherit image > inherit isar-bootstrap-helper > > +def cfg_script(d): > + cf = d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' > + if cf: > + return 'file://' + cf > + return '' > + > FILESPATH =. "${LAYERDIR_isar}/conf/distro:" > -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" > +SRC_URI += "${@ cfg_script(d) }" > > DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de