From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7249602373157388288 Date: Mon, 3 Jul 2023 00:07:31 -0700 (PDT) From: Srinuvasan Arjunan To: isar-users Message-Id: <095c5ab0-3c19-4247-970b-ea645540d5dfn@googlegroups.com> In-Reply-To: References: <20230628051920.2364466-1-srinuvasan_a@mentor.com> Subject: Re: [PATCH] classes/sdk.bbclass: remove additional "/" in new_target finding MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_47206_1376884120.1688368051162" X-TUID: cskUoeCubLAI ------=_Part_47206_1376884120.1688368051162 Content-Type: multipart/alternative; boundary="----=_Part_47207_1389142558.1688368051162" ------=_Part_47207_1389142558.1688368051162 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wednesday, June 28, 2023 at 12:42:52=E2=80=AFPM UTC+5:30 Jan Kiszka wrot= e: On 28.06.23 07:19, Srinuvasan Arjunan wrote:=20 > From: Srinuvasan A =20 >=20 > We observed that one additional / present in finding the new_target,=20 > here target already start with /, hence no need to append the additional= =20 > /.=20 >=20 > In functionality wise there is no change.=20 >=20 > Signed-off-by: Srinuvasan A =20 > ---=20 > meta/classes/sdk.bbclass | 2 +-=20 > 1 file changed, 1 insertion(+), 1 deletion(-)=20 >=20 > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass=20 > index c6dc689..f14b447 100644=20 > --- a/meta/classes/sdk.bbclass=20 > +++ b/meta/classes/sdk.bbclass=20 > @@ -100,7 +100,7 @@ sdkchroot_finalize() {=20 >=20 > if [ "${target#/}" !=3D "${target}" ]; then=20 > basedir=3D$(dirname $link)=20 > - new_target=3D$(realpath --no-symlinks -m --relative-to=3D$basedir=20 ${ROOTFSDIR}/${target})=20 > + new_target=3D$(realpath --no-symlinks -m --relative-to=3D$basedir=20 ${ROOTFSDIR}${target})=20 >=20 Can you guarantee that ROOTFSDIR comes with a trailing / in ALL case?=20 I'm skeptical about that. Actually ROOTFSDIR not contains / in all the cases, rather target always= =20 start with /, hence the additional / is not needed. f.e: Debug Logs: target=3D/etc/alternatives/lzma.1.gz [ etc/alternatives/lzma.1.gz !=3D /etc/alternatives/lzma.1.gz ] dirname=20 /home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/debian-bullse= ye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs/usr/share/man/man1/lzma.= 1.gz basedir=3D/home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/de= bian-bullseye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs/usr/share/man= /man1 realpath --no-symlinks -m=20 --relative-to=3D/home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/wo= rk/debian-bullseye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs/usr/shar= e/man/man1=20 /home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/debian-bullse= ye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs//etc/alternatives/lzma.1= .gz new_target=3D../../../../etc/alternatives/lzma.1.gz =20 Jan=20 --=20 Siemens AG, Technology=20 Competence Center Embedded Linux=20 ------=_Part_47207_1389142558.1688368051162 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Wednesday, June 28, 2023 at 12:42:52= =E2=80=AFPM UTC+5:30 Jan Kiszka wrote:
On 28.06.23 07:19, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuv...@s= iemens.com>
>=20
> We observed that one additional / present in finding the new_tar= get,
> here target already start with /, hence no need to append the ad= ditional
> /.
>=20
> In functionality wise there is no change.
>=20
> Signed-off-by: Srinuvasan A <sr= inuv...@siemens.com>
> ---
> meta/classes/sdk.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index c6dc689..f14b447 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -100,7 +100,7 @@ sdkchroot_finalize() {
> =20
> if [ "${target#/}" !=3D "${target}" ]; then
> basedir=3D$(dirname $link)
> - new_target=3D$(realpath --no-symlinks -m --relative= -to=3D$basedir ${ROOTFSDIR}/${target})
> + new_target=3D$(realpath --no-symlinks -m --relative= -to=3D$basedir ${ROOTFSDIR}${target})
> =20

Can you guarantee that ROOTFSDIR comes with a trailing / in ALL case?
I'm skeptical about that.

=C2=A0 Ac= tually ROOTFSDIR not contains / in all the cases, rather target always star= t with /, hence the additional / is not needed.
f.e:
De= bug Logs:
target=3D/etc/alternatives/lzma.1.gz
=C2=A0[ etc/a= lternatives/lzma.1.gz !=3D /etc/alternatives/lzma.1.gz ]
=C2=A0dirname= /home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/debian-bulls= eye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs/usr/share/man/man1/lzma= .1.gz
=C2=A0basedir=3D/home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/b= uild/tmp/work/debian-bullseye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/root= fs/usr/share/man/man1
=C2=A0realpath --no-symlinks -m --relative-to=3D= /home/srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/debian-bullse= ye-armhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs/usr/share/man/man1 /home= /srinu/work/TEST/ISAR_REL_PATH_CHECK_TEST/build/tmp/work/debian-bullseye-ar= mhf/isar-image-base-sdk-qemuarm/1.0-r0/rootfs//etc/alternatives/lzma.1.gz=C2=A0new_target=3D../../../../etc/alternatives/lzma.1.gz
=C2= =A0=C2=A0


Jan

--=20
Siemens AG, Technology
Competence Center Embedded Linux

------=_Part_47207_1389142558.1688368051162-- ------=_Part_47206_1376884120.1688368051162--