public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: Re: [PATCH 1/3] ci: Wait for bitbake worker to finish before deleting artifacts
Date: Wed, 5 Dec 2018 12:59:05 +0300	[thread overview]
Message-ID: <09dc1e24-4ac4-32d5-5dc4-054e6725a05b@ilbers.de> (raw)
In-Reply-To: <4a738881362bc31233c348ca6cb051163f5d5a26.1544002190.git.jan.kiszka@siemens.com>

On 12/5/18 12:29 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> bitbake completes asynchronously to the worker daemon. Therefore, we
> must not start deleting its tmp folder before the termination because it
> may contain active mounts.
> 
> Wait for the socket that links frontend and backend to go away. This is
> a reliably sign that the worker finished as well.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   scripts/ci_build.sh | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> index 20b77b7..aae9084 100755
> --- a/scripts/ci_build.sh
> +++ b/scripts/ci_build.sh
> @@ -92,6 +92,7 @@ if [ -n "$FAST_BUILD" ]; then
>           multiconfig:qemuarm-stretch:isar-image-base \
>           multiconfig:qemuarm64-stretch:isar-image-base \
>           multiconfig:qemuamd64-stretch:isar-image-base
> +    while [ -e bitbake.sock ]; do sleep 1; done

I'm OK with this change, but this doesn't solve problems
with hangs - when commands are launched by hand:

Command 1)
bitbake  -c cache_base_repo multiconfig:qemuarm-stretch:isar-image-base 
multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-
stretch:isar-image-base

At this step I've doublechecked  that bitbake.sock is cleaned.
Command 2)
sudo rm -rf tmp

Command 3)
sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO 
?= "1"/g' conf/local.conf

No problems detected at this point - the same mounts etc.

The next command hangs on the last task (according strace bitbake tries 
to unmount /sys /dev)

Command 4)
bitbake multiconfig:qemuarm-stretch:isar-image-base 
multiconfig:qemuarm64-stretch:isar-image-base 
multiconfig:qemuamd64-stretch:isar-image-base

Maxim.

>       sudo rm -rf tmp
>       sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
>       bitbake $BB_ARGS \
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  parent reply	other threads:[~2018-12-05  9:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  9:29 [PATCH 0/3] umount fixes and cleanups Jan Kiszka
2018-12-05  9:29 ` [PATCH 1/3] ci: Wait for bitbake worker to finish before deleting artifacts Jan Kiszka
2018-12-05  9:52   ` Hombourger, Cedric
2018-12-05  9:59   ` Maxim Yu. Osipov [this message]
2018-12-05 10:04     ` Jan Kiszka
2018-12-05  9:29 ` [PATCH 2/3] isar-events: Improve umount handler Jan Kiszka
2018-12-05  9:29 ` [PATCH 3/3] Remove redundant recursive umounts Jan Kiszka
2018-12-05 11:12 ` [PATCH 0/3] umount fixes and cleanups Maxim Yu. Osipov
2018-12-05 11:32   ` Hombourger, Cedric
2018-12-05 12:14   ` Jan Kiszka
2018-12-05 12:31     ` Hombourger, Cedric
2018-12-05 12:35       ` Jan Kiszka
2018-12-05 12:48         ` Hombourger, Cedric
2018-12-05 12:54           ` Jan Kiszka
2018-12-05 14:26     ` Maxim Yu. Osipov
2018-12-05 14:52       ` Jan Kiszka
2018-12-05 23:08         ` Jan Kiszka
2018-12-07 13:46 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09dc1e24-4ac4-32d5-5dc4-054e6725a05b@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox