* [PATCH] fix: remove unsigned example module before including the signed one @ 2023-05-25 7:06 Pingfang Liao 2023-05-25 9:53 ` MOESSBAUER, Felix 2023-05-25 9:56 ` MOESSBAUER, Felix 0 siblings, 2 replies; 5+ messages in thread From: Pingfang Liao @ 2023-05-25 7:06 UTC (permalink / raw) To: isar-users; +Cc: felix.moessbauer, pingfang.liao, Pingfang Liao We need remove unsigned exmple module firstly, because signed and unsigned exmaple module will install example-module.ko to the same path, which will lead to dpkg error. --- meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf index 19a105e..ca76685 100644 --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye" # include public keys IMAGE_INSTALL += "sb-mok-public" -# include signed example module +# remove unsigned example module and include signed example module +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" # add MOK utilities to insert MOK into EFI -- 2.20.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix: remove unsigned example module before including the signed one 2023-05-25 7:06 [PATCH] fix: remove unsigned example module before including the signed one Pingfang Liao @ 2023-05-25 9:53 ` MOESSBAUER, Felix 2023-05-25 9:56 ` MOESSBAUER, Felix 1 sibling, 0 replies; 5+ messages in thread From: MOESSBAUER, Felix @ 2023-05-25 9:53 UTC (permalink / raw) To: isar-users, pingfang.liao; +Cc: Liao, Pingfang (Marshell) On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote: > We need remove unsigned exmple module firstly, because signed and > unsigned > exmaple module will install example-module.ko to the same path, which > will > lead to dpkg error. > --- > meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > index 19a105e..ca76685 100644 > --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye" > > # include public keys > IMAGE_INSTALL += "sb-mok-public" > -# include signed example module > +# remove unsigned example module and include signed example module > +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" Good catch, thanks. ACK! > IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" > > # add MOK utilities to insert MOK into EFI ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix: remove unsigned example module before including the signed one 2023-05-25 7:06 [PATCH] fix: remove unsigned example module before including the signed one Pingfang Liao 2023-05-25 9:53 ` MOESSBAUER, Felix @ 2023-05-25 9:56 ` MOESSBAUER, Felix 2023-05-25 16:24 ` Jan Kiszka 1 sibling, 1 reply; 5+ messages in thread From: MOESSBAUER, Felix @ 2023-05-25 9:56 UTC (permalink / raw) To: isar-users, pingfang.liao; +Cc: Liao, Pingfang (Marshell) On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote: > We need remove unsigned exmple module firstly, because signed and > unsigned > exmaple module will install example-module.ko to the same path, which > will > lead to dpkg error. Please add the signed-off line to the commit message (git commit --signoff). For details, see https://wiki.linuxfoundation.org/dco Felix > --- > meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > index 19a105e..ca76685 100644 > --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye" > > # include public keys > IMAGE_INSTALL += "sb-mok-public" > -# include signed example module > +# remove unsigned example module and include signed example module > +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" > IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" > > # add MOK utilities to insert MOK into EFI ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix: remove unsigned example module before including the signed one 2023-05-25 9:56 ` MOESSBAUER, Felix @ 2023-05-25 16:24 ` Jan Kiszka 2023-05-29 2:19 ` Liao, Pingfang (Marshell) 0 siblings, 1 reply; 5+ messages in thread From: Jan Kiszka @ 2023-05-25 16:24 UTC (permalink / raw) To: MOESSBAUER, Felix, isar-users, pingfang.liao; +Cc: Liao, Pingfang (Marshell) On 25.05.23 11:56, 'MOESSBAUER, Felix' via isar-users wrote: > On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote: >> We need remove unsigned exmple module firstly, because signed and >> unsigned >> exmaple module will install example-module.ko to the same path, which >> will >> lead to dpkg error. > > Please add the signed-off line to the commit message (git commit > --signoff). For details, see https://wiki.linuxfoundation.org/dco > And fix the "exm[a]ple" typos at this chance. ;) Thanks, Jan > Felix > >> --- >> meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> index 19a105e..ca76685 100644 >> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye" >> >> # include public keys >> IMAGE_INSTALL += "sb-mok-public" >> -# include signed example module >> +# remove unsigned example module and include signed example module >> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" >> IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" >> >> # add MOK utilities to insert MOK into EFI > -- Siemens AG, Technology Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] fix: remove unsigned example module before including the signed one 2023-05-25 16:24 ` Jan Kiszka @ 2023-05-29 2:19 ` Liao, Pingfang (Marshell) 0 siblings, 0 replies; 5+ messages in thread From: Liao, Pingfang (Marshell) @ 2023-05-29 2:19 UTC (permalink / raw) To: Kiszka, Jan, MOESSBAUER, Felix, isar-users, pingfang.liao Thanks for the comments, will update the patch. -----Original Message----- From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> Sent: Friday, May 26, 2023 12:24 AM To: MOESSBAUER, Felix (T CED INW-CN) <felix.moessbauer@siemens.com>; isar-users@googlegroups.com; pingfang.liao@outlook.com Cc: Liao, Pingfang (Marshell) (DI FA CTR SVC&AI CN) <Pingfang.Liao@siemens.com> Subject: Re: [PATCH] fix: remove unsigned example module before including the signed one On 25.05.23 11:56, 'MOESSBAUER, Felix' via isar-users wrote: > On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote: >> We need remove unsigned exmple module firstly, because signed and >> unsigned exmaple module will install example-module.ko to the same >> path, which will lead to dpkg error. > > Please add the signed-off line to the commit message (git commit > --signoff). For details, see > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki > .linuxfoundation.org%2Fdco&data=05%7C01%7CPingfang.Liao%40ad011.siemen > s.com%7C4cc19e2489704d47add908db5d3c78b1%7C38ae3bcd95794fd4addab42e149 > 5d55a%7C1%7C0%7C638206286528707710%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7 > C&sdata=QNlWSFHmjvtEnaQAkRdUn8wF9DH6%2BDgHXqFyNwNg9T4%3D&reserved=0 > And fix the "exm[a]ple" typos at this chance. ;) Thanks, Jan > Felix > >> --- >> meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> index 19a105e..ca76685 100644 >> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf >> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye" >> >> # include public keys >> IMAGE_INSTALL += "sb-mok-public" >> -# include signed example module >> +# remove unsigned example module and include signed example module >> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" >> IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" >> >> # add MOK utilities to insert MOK into EFI > -- Siemens AG, Technology Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-29 5:32 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-25 7:06 [PATCH] fix: remove unsigned example module before including the signed one Pingfang Liao 2023-05-25 9:53 ` MOESSBAUER, Felix 2023-05-25 9:56 ` MOESSBAUER, Felix 2023-05-25 16:24 ` Jan Kiszka 2023-05-29 2:19 ` Liao, Pingfang (Marshell)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox