From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7059736144635756544 X-Received: by 2002:adf:ebc2:: with SMTP id v2mr24846115wrn.498.1643785518783; Tue, 01 Feb 2022 23:05:18 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ec88:: with SMTP id z8ls1102923wrn.2.gmail; Tue, 01 Feb 2022 23:05:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPpA/P4p3K+i8/YMQKwbZLqh/4MdB4GSRMGvrZ/QeZ0XdZ7yyrhGuRalgxOnYG3PZte4HG X-Received: by 2002:adf:f8c2:: with SMTP id f2mr24840111wrq.150.1643785517765; Tue, 01 Feb 2022 23:05:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643785517; cv=pass; d=google.com; s=arc-20160816; b=WEZ0iv5HT9EMr6VGRaYPbrPDnwHnzFRmm0fXzSEwAhnkc6XZxQF4H6ZiSoFLSX2YGt F0nEIEAPlC7HDa5th7mriIhtd5jEP4WQhp++6J5BKDSWleVsbI/FtpMg2npOEK+YLgBL e3Z0ZGYTdoxd4Aj647WJ9zDdHFC4PE4MHBdOWRuTLukHKi93VeeCwswPVqZ4KSlLTZKC j6FJKjY3d9fEeQcdfn1SRPoQ6flcF4JiDTgAQq8LKF/r5hliGRQ7ik89YHnIA4nkuM4a /ENo/oztjpojKaXxjqoKlqnOCyALvHZ+bkKpk8BqoFC5foLUiN8JU3ryOQ9N//BZj6OK 3Pwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=mnPv3xwIzqcNsH8WJA/MeK5v6waO8CU2lY7VPwzHoGs=; b=egeMnogsVaG78ayItMKQ4IILBHjILnD97BWIsW1lk/1rv1hPxw8cNB/3RstqVSezrZ E/x0EzQJBofCSli2LRl2qsL7wsWsox7BsJAhjT0e3Rvqn7RV9uzvuH9cfCLFth38TN3T OnC+o6k3zPm9Fl6V2v/2wCxujoi9XC1zmBBCCYAIsKsr8Laxu3mqu4LYsP57ec7PYTVd PyOia6xvHil0IpGowHIwiuhABoHSgvxRa3S1vwR+N2qVcLeOTCaPNYBxcAhEk/YsZELK otUgZ9rgNnnj6Yv5ZmuiMHxhuM0ztb2gcvoaehBsEooAzbMg9/W6429zlpQGuVSOmfYn ZDJA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="AG/twDNl"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.20.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com. [40.107.20.40]) by gmr-mx.google.com with ESMTPS id h2si1456456wrp.7.2022.02.01.23.05.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Feb 2022 23:05:17 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.20.40 as permitted sender) client-ip=40.107.20.40; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="AG/twDNl"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.20.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5+FMUp1/K/MQLCXqeRHiy45JEBREKFciveYLHPo3Y5pKIB1p1Tib9HnMouKi4qxxGlOC34dI7CNNgkaQM1hDrHSpRtBsitJOKYTBm/q5enoatvH/+fTRAJ0BrNElBWfXowKWKQERSaJUFQWydM862iE/grfKavQOPkL9REWsmCcneeD/Vrzl4JHqkd9i+xA4tgn9+TpkbAoEjkLbVLMf90hK0Jv8JILpNzbQ8e1Sr6OO9/olmlqnMGoBMRAf2YbAYNXNxEpZPnAoi211RVgwYNLdY/3bJfDX1rpt8bP/HuLkBAXcDGJdUXAupCxh17/fl+tfd/7k+QQSAr4EOl0mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mnPv3xwIzqcNsH8WJA/MeK5v6waO8CU2lY7VPwzHoGs=; b=dZ2F4qOCtMdVZK4wBgiC808mfp3juaompEYV15t6TnLq/vN/5uS5YFYcHREcoErSN4XFC7Ai04aTgf0szmjnFlCeBJ4PcnMHCpuarRKt+jTAm+Tyyz2FhDymeLfpuZMnQD8yM4UXkOS5XsUrkjVqS5ZeboK6XEBVbVjb7jLeoqTp6qB11iSPaecydUq9/dCmO77JJnlqmojPdHXAAmQawtTVy1lVVZHUoqQkBmVOeenYeuYGrRM+drpySDYaGoBpF/WPy/ssDpRagWDuRU/jvPHP6K1EEj5A4nGD+bMNjOZrFK2wFLa8oKz2ocI/dVduaZI7itvrAIXsgZP70ir2jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=mentor.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mnPv3xwIzqcNsH8WJA/MeK5v6waO8CU2lY7VPwzHoGs=; b=AG/twDNlKXg3Y0aciDarrqyomIk1jXBS8mimtSfnQalVXSKwdIs/TDn9TJhm+gLokXG6dt3GoizDP3cVjsM2RZO6TxShY+oK5WtfUXCOyVnvBO8M2Sz374EGKiDJe2gVQGn3wotsPSMjOOpf59sZDZpjIBmvwUQwVNcglJIg10bJ/gfbTyDl7KyUuz7P3zML7FzSzvzbInf06qgTAh3XNrjyPhLZCPxBzxFq833CCRpWUyE8aBEG6+6KrlL+t0nv1ZvD0OESYEuKM4FSKgSHAdAAJO0CLc3wWrGjES9MOIpmEMM05x6I2QYtzfwnlWnuoyGTXhbyrVP1DBLGAup86A== Received: from DB6PR0202CA0035.eurprd02.prod.outlook.com (2603:10a6:4:a5::21) by AM8PR10MB3986.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1e5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb 2022 07:05:17 +0000 Received: from DB5EUR01FT051.eop-EUR01.prod.protection.outlook.com (2603:10a6:4:a5:cafe::15) by DB6PR0202CA0035.outlook.office365.com (2603:10a6:4:a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22 via Frontend Transport; Wed, 2 Feb 2022 07:05:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.72) by DB5EUR01FT051.mail.protection.outlook.com (10.152.5.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 07:05:16 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 2 Feb 2022 08:05:16 +0100 Received: from [167.87.1.21] (167.87.1.21) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 2 Feb 2022 08:05:15 +0100 Message-ID: <0a7f590d-63f5-5505-a9c9-718f9d8c81fb@siemens.com> Date: Wed, 2 Feb 2022 08:05:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] dpkg-base: cope with race around check/creation of .git-downloads symlink Content-Language: en-US To: Cedric Hombourger , References: <20220201134125.24853-1-Cedric_Hombourger@mentor.com> From: Jan Kiszka In-Reply-To: <20220201134125.24853-1-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.1.21] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 092c4a67-ef7c-4746-014d-08d9e61a5de9 X-MS-TrafficTypeDiagnostic: AM8PR10MB3986:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YrROxdGFcnHMfuzlRBHAwUZh5l3bL9tJzZ49gyPEIsXQaEMjaHbKJk4Ds4c9RnzEIid0lRIma/sLKIhhW+zHzIcb3lKhY6ZH5Y7t3Oowi+SxfSncy6MAbs5P/mlaX9Wck73YoWGlhgdakos+YK9yQCusGMMCp1aYAiHwLjR4HzTQpl3mDIJKEZ4aowSZvwHhMgNtyeiTt9V3NEnEOWRDH5V8fgl1wmeT6F2/eiKOn0gx0EYT4fpj6U+CthbwJyhJDxRNIyK/YWQu2jSTiTsuPigp3ap6Aovqm10I/4nDYHbj35Iq44jOooZGdx6NPZogKvbNafjokVgV9XCiMX2Z6a795Yy6IKMAuMGFjCLaaJSdijszg150WFJL0NZV9eUGfnfLmVm7ooLw9La/2Hna6SZzJtne0Hq0J6MAUP4FX3EnQBb2mvNuXIv7ou0tqANj/ZCBQ7VdmersfLGMY5/FscwktUMLj+27qTo/2DEvGdJeoLTABhyUkpf3T822GC9wK06smYl4561AewdVnD9jwmHlIwv4ATwH9MPLkoVzYl01zRsoicx+PChSjY+ZPU+NiXIwQx2BdaBTqfn0Sj1JP9pbjq4mducS+ohWFSCqbHo4r1TR3i1Sr4guZGGEhZurKVmPds+FMfcHqfmLztO4881EGeNZe2/SvfOct29P8+103qtf4QMZmQQ9v3C7H9OsRMDUg+gY4Mp7D5v2y1cPtATTnwmYquS2G7GjrKfGSmkySiOlaznxDGk3nsJp6W1FGsgThFbG9xcuvPfK9qsDZpKnk8qDopoxVeC5yCerkKw= X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(956004)(82960400001)(356005)(40460700003)(83380400001)(81166007)(16526019)(2616005)(47076005)(336012)(186003)(110136005)(36756003)(5660300002)(44832011)(2906002)(26005)(31686004)(70206006)(8936002)(70586007)(508600001)(6706004)(316002)(82310400004)(86362001)(53546011)(8676002)(31696002)(36860700001)(16576012)(142923001)(3940600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 07:05:16.8100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 092c4a67-ef7c-4746-014d-08d9e61a5de9 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT051.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB3986 X-TUID: 8o8idz4rRWub On 01.02.22 14:41, Cedric Hombourger wrote: > There is a race condition between the check for the .git-downloads symbolic > link existing and its creation. Ignore the FileExistsError exception when > hitting this race. > > Signed-off-by: Cedric Hombourger > --- > meta/classes/dpkg-base.bbclass | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 2add0b2..3aa52b1 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -23,7 +23,10 @@ python do_adjust_git() { > git_dl = os.path.join(d.getVar("DL_DIR"), "git") > > if not os.path.exists(git_link) or os.path.realpath(git_link) != git_dl: > - os.symlink(git_dl, git_link) > + try: > + os.symlink(git_dl, git_link) > + except FileExistsError: > + pass > > for src_uri in (d.getVar("SRC_URI", True) or "").split(): > try: do_adjust_git is run under global ${DL_DIR}/git/isar.lock - how do you trigger this race then? Jan -- Siemens AG, Technology Competence Center Embedded Linux