From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH 1/1] classes/image: Separate image rootfs for machines
Date: Tue, 12 Mar 2019 09:30:12 +0100 [thread overview]
Message-ID: <0b01c663-c270-1303-1a8a-d4e95b71c691@ilbers.de> (raw)
In-Reply-To: <79936060-c03e-ab1a-d0a8-b05213fad84c@siemens.com>
On 3/11/19 7:00 PM, Jan Kiszka wrote:
> On 11.03.19 18:03, Maxim Yu. Osipov wrote:
>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>> ---
>> meta/classes/image.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 2514c88..ed9d6eb 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -3,7 +3,7 @@
>> IMAGE_INSTALL ?= ""
>> IMAGE_TYPE ?= "ext4-img"
>> -IMAGE_ROOTFS = "${WORKDIR}/rootfs"
>> +IMAGE_ROOTFS = "${WORKDIR}/${MACHINE}/rootfs/"
>> IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
>> True)) if d.getVar("KERNEL_NAME", True) else ""}"
>>
>
> Hmm, I wonder if that is actually a sufficient change - or a needed one.
> Just checked jailhouse-images, and there I do
>
> PN .= "-${MACHINE}"
>
> in the image recipe to ensure that distinct images (in different
> IMAGE_ROOTFS) are built. That change above will still run the recipe
> multiple times, overwriting at least the logs in confusing ways, if not
> more, no?
Agree - this is the right approach.
Maxim.
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
prev parent reply other threads:[~2019-03-12 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 17:03 [PATCH 0/1] " Maxim Yu. Osipov
2019-03-11 17:03 ` [PATCH 1/1] classes/image: " Maxim Yu. Osipov
2019-03-11 18:00 ` Jan Kiszka
2019-03-11 19:43 ` cedric_hombourger
2019-03-12 5:13 ` Jan Kiszka
2019-03-12 5:57 ` [PATCH] isar-image: use a per-machine WORKDIR for image builds Cedric Hombourger
2019-03-12 10:45 ` Maxim Yu. Osipov
2019-03-14 10:54 ` [PATCH 1/1] classes/image: Separate image rootfs for machines Baurzhan Ismagulov
2019-03-12 8:30 ` Maxim Yu. Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b01c663-c270-1303-1a8a-d4e95b71c691@ilbers.de \
--to=mosipov@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox