Re: [PATCH v2 3/4] meta-isar: add some empty space at the end of our wic images

["Schaffner, Tobias" <tobias.schaffner@siemens.com>]

On 14.11.22 18:40, Henning Schild wrote:
> Add some empty space at the end of our example images. This will enable
> better interactive use of our example images since people will have some
> space to install some more packages. While the space seems fixed it
> really is open end if the mass storage happens to be bigger, because we
> installed expand-on-first-boot earlier.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks | 2 ++
>   meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks    | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks
> index 754fbc46f8e4..e6b7128eb3ae 100644
> --- a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks
> +++ b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks
> @@ -6,4 +6,6 @@ part /boot --source bootimg-efi-isar --sourceparams "loader=systemd-boot" --ondi
>   
>   part / --source rootfs --ondisk sda --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --use-uuid --exclude-path boot/
>   
> +part --source empty --no-table --ondisk sda --size 256M

It might be a good idea to use some odd value here. Wic only allows you 
to go down to Kibibyte with --fixed-size. Still when using something 
that is not dividable by 4 e.g. ext4 filesystems will not fit perfectly 
into the partition.

Imho we should enlarge the image only for the CI and maybe document how 
to use qemu-img resize for users that want to install additional 
packages. I see that its only an example image and therefore rarely used 
but still it will eat up more space when uncompressed and take longer to 
flash.

Greetings!
> +
>   bootloader --ptable gpt --timeout 3 --append "rootwait console=ttyS0,115200 console=tty0"
> diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
> index f3addbc7515d..5e555b3cc472 100644
> --- a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
> +++ b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
> @@ -6,4 +6,6 @@ part /boot --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk s
>   
>   part / --source rootfs --ondisk sda --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --use-uuid --exclude-path boot/
>   
> +part --source empty --no-table --ondisk sda --size 256M
> +
>   bootloader --ptable gpt --timeout 3 --append "rootwait console=ttyS0,115200 console=tty0"