Re: [PATCH v2 4/4] image-postproc-extension: extract systemd's version using rootfs_cmd

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 20.06.25 11:16, 'Quirin Gylstorff' via isar-users wrote:
> 
> 
> On 6/18/25 15:50, 'Cedric Hombourger' via isar-users wrote:
>> Elevated privileges are not required to query the rootfs for the version
>> of systemd: replace "sudo chroot" with "rootfs_cmd"
>>
>> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
>> ---
>>   meta/classes/image-postproc-extension.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image-postproc-extension.bbclass b/meta/
>> classes/image-postproc-extension.bbclass
>> index 0af588d8..21dcfccc 100644
>> --- a/meta/classes/image-postproc-extension.bbclass
>> +++ b/meta/classes/image-postproc-extension.bbclass
>> @@ -55,7 +55,7 @@ image_postprocess_mark() {
>>     # Use dpkg to find out which version of systemd is installed into
>> the image or reports "0"
>>   image_systemd_version() {
>> -    sudo chroot ${IMAGE_ROOTFS} dpkg-query --
>> showformat='${source:Upstream-Version}' --show systemd || echo "0"
>> +    rootfs_cmd ${IMAGE_ROOTFS} -- dpkg-query --
>> showformat='${source:Upstream-Version}' --show systemd || echo "0"
>>   }
> Why are we not using the root parameter of dpkg-query for this?
> 

Pro: even faster than any wrapper
Con: brings some dependency between dpkg and data base versions

But this option should still be considered in the discussion, maybe also
depending on the type of access (read as above vs. write as in other cases).

Cedric, did you think about it?

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/0d1c4ca7-69e4-48f4-b49d-2f5366c97e85%40siemens.com.