public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: Badrikesh Prusty <badrikesh.prusty@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] installer: improve root device detection and skip additional devices
Date: Wed, 18 Feb 2026 09:25:10 +0100	[thread overview]
Message-ID: <0d6ffb28-ee46-4ad5-9f88-fd4d97677ed3@ilbers.de> (raw)
In-Reply-To: <20260212202449.1274384-1-badrikesh.prusty@siemens.com>

Applied to next, thanks.

Zhihang

On 2/12/26 21:24, 'Badrikesh Prusty' via isar-users wrote:
> Strip trailing digits correctly to determine the base device name for
> p-style partitioned devices such as mmcblk0p2 and nvme0n1p3. Handle
> these devices by removing the p<partition> suffix while preserving
> behavior for traditional devices like sda1.
>
> Skip device-mapper (dm-*) and zram (zram*) devices to prevent
> presenting virtual or non-installable devices as installation targets.
>
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>   .../deploy-image/files/usr/bin/deploy-image-wic.sh   | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index ca586aa6..9c041a50 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> @@ -64,7 +64,11 @@ if ! $installer_unattended; then
>           # Always exclude the exact device mounted as /
>           exclude_list+=("$current_root_dev")
>   
> -        base_no_part=${current_root_dev%%[0-9]*}
> +        if [[ "$current_root_dev" =~ ^(mmcblk|nvme) ]]; then
> +            base_no_part="${current_root_dev%p[0-9]*}"
> +        else
> +            base_no_part="${current_root_dev%%[0-9]*}"
> +        fi
>           if [ -n "$base_no_part" ]; then
>               exclude_list+=("$base_no_part")
>           fi
> @@ -121,6 +125,9 @@ if ! $installer_unattended; then
>           fi
>   
>           case $device in
> +            dm-*)
> +                # skip device-mapper device
> +                ;;
>               loop*)
>                   # skip loop device
>                   ;;
> @@ -132,6 +139,9 @@ if ! $installer_unattended; then
>               ram*)
>                   # skip ram device
>                   ;;
> +            zram*)
> +                # skip zram device
> +                ;;
>               *)
>                   #skip any excluded devices (root and its slaves)
>                   skip_device=0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/0d6ffb28-ee46-4ad5-9f88-fd4d97677ed3%40ilbers.de.

      reply	other threads:[~2026-02-18  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 20:24 'Badrikesh Prusty' via isar-users
2026-02-18  8:25 ` Zhihang Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d6ffb28-ee46-4ad5-9f88-fd4d97677ed3@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=badrikesh.prusty@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox