public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH] meta/conf/bitbake.conf: add default value for SRCREV
Date: Fri, 30 Jun 2023 14:57:32 +0300	[thread overview]
Message-ID: <0dc30155defdd7f0f73c5a4b350c9c1006a3fd16.camel@ilbers.de> (raw)
In-Reply-To: <20230622165238.25748-1-henning.schild@siemens.com>

On Thu, 2023-06-22 at 18:52 +0200, 'Henning Schild' via isar-users
wrote:
> The line is taken from the bitbake.conf of OE. The value "INVALID" is
> magic and makes bitbake throw exceptions in case the variable needs a
> value assigned but a recipe did not assign one.
> So it is a minor fix to improve error reporting when recipes have
> mistakes.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/conf/bitbake.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a85fea77877e..c122914b2ee9 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -35,6 +35,7 @@ PV = "${@bb.parse.vars_from_file(d.getVar('FILE',
> False),d)[1] or '1.0'}"
>  PR = "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or
> 'r0'}"
>  PROVIDES = ""
>  S = "${WORKDIR}/${P}"
> +SRCREV ??= "INVALID"
>  AUTOREV = "${@bb.fetch2.get_autorev(d)}"
>  AUTOREV[vardepvalue] = "${SRCPV}"
>  # Set Dynamically in base.bbclass
> -- 
> 2.39.3
> 

Applied to next, thanks.

      reply	other threads:[~2023-06-30 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 16:52 Henning Schild
2023-06-30 11:57 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dc30155defdd7f0f73c5a4b350c9c1006a3fd16.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox