From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7247554479741992960 X-Received: by 2002:a05:6512:118d:b0:4f8:4b19:9533 with SMTP id g13-20020a056512118d00b004f84b199533mr2660710lfr.19.1688126255994; Fri, 30 Jun 2023 04:57:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:544:b0:4f0:9517:7df6 with SMTP id h4-20020a056512054400b004f095177df6ls984288lfl.0.-pod-prod-06-eu; Fri, 30 Jun 2023 04:57:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlH93DLvuJHOJlbIIVLuOn3M97PY8CdxEBnUz3J31Qe17mvdTZx4gC+LfQxUIWGtNhu43pTW X-Received: by 2002:a2e:888e:0:b0:2b6:9f1e:12bf with SMTP id k14-20020a2e888e000000b002b69f1e12bfmr2059898lji.1.1688126254285; Fri, 30 Jun 2023 04:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688126254; cv=none; d=google.com; s=arc-20160816; b=02Q/PTYgmGBUTGs8vj/NPyjMGb/+QzX1pLcNImS00IQUnLN5ScDDBTVYYbjoxyjVMs gc/yDyc849yoQMC5YQJGxFsBhVgOFJPNXgbtZOY1eYJi+CxnTq8+edpVix/7g9kSpm+u o7wtUiBSOXrlyMwakJtZSAk506MRr9oaH423WbAMvRZDdzzCEGEqnbLYcqVxoDO2v2Oi rIFGNnyeFJuEldcRtCu9BfWYP2Ko0bwQAlC9TwZgUgbfrbvTSq2p1j4t+ig21LKxFfsg J8XNADQEQb9SfmwVVq8Wa28oUiPUygXSq85ZzMPQ6FfXAkarQwaqTPyANw1AtdrkpNGQ k60A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=1uk8HbXN1+QB0H5tqh/wfdW9Rx2h1kH2RA00Bltal/E=; fh=iniy8Lr+j5VHk0lfX++izBgIHPUnuY9hOv2FppYk+JQ=; b=tWyJKE9a//RM4JG5ezdxGOa3fRPlwYrFfEk87ZA9zRUoeWafAbz6uunXc/tfGBlUMJ ZweIIgykx7nAJ4h2FKd2YQbd/T67Q8+053/Mk8AovrCc3Ms/TD+gp5m2Tbpe2U4zrMRC GKgAPEfMB7xX+PC0wn4ZPG6/hFRiPqmSuWJA7nBSykzx4lg+Lcwu/WlVyigiQ4bznHas 4kCsdm53rozDrU1sRGvC0EJoyfW4zr6EEn2sIboHGzN/0G/I3fS0DUEQRVZwgcyPMNEl RQDoOrmDcFSqtAsAALk6oSLTTkIq483vQ1e4HItAkWZ57KXF++kfE0JcPtsreDzqdmOC bMyw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id x19-20020a2ea7d3000000b002b6a63b9bb2si624510ljp.2.2023.06.30.04.57.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Jun 2023 04:57:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 35UBvWwB031052 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 13:57:33 +0200 Message-ID: <0dc30155defdd7f0f73c5a4b350c9c1006a3fd16.camel@ilbers.de> Subject: Re: [PATCH] meta/conf/bitbake.conf: add default value for SRCREV From: Uladzimir Bely To: Henning Schild , isar-users@googlegroups.com Date: Fri, 30 Jun 2023 14:57:32 +0300 In-Reply-To: <20230622165238.25748-1-henning.schild@siemens.com> References: <20230622165238.25748-1-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: yVhBH/e0xWpm On Thu, 2023-06-22 at 18:52 +0200, 'Henning Schild' via isar-users wrote: > The line is taken from the bitbake.conf of OE. The value "INVALID" is > magic and makes bitbake throw exceptions in case the variable needs a > value assigned but a recipe did not assign one. > So it is a minor fix to improve error reporting when recipes have > mistakes. >=20 > Signed-off-by: Henning Schild > --- > =C2=A0meta/conf/bitbake.conf | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index a85fea77877e..c122914b2ee9 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -35,6 +35,7 @@ PV =3D "${@bb.parse.vars_from_file(d.getVar('FILE', > False),d)[1] or '1.0'}" > =C2=A0PR =3D "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or > 'r0'}" > =C2=A0PROVIDES =3D "" > =C2=A0S =3D "${WORKDIR}/${P}" > +SRCREV ??=3D "INVALID" > =C2=A0AUTOREV =3D "${@bb.fetch2.get_autorev(d)}" > =C2=A0AUTOREV[vardepvalue] =3D "${SRCPV}" > =C2=A0# Set Dynamically in base.bbclass > --=20 > 2.39.3 >=20 Applied to next, thanks.