public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Maxim Yu. Osipov" <mosipov@ilbers.de>,
	Cedric Hombourger <Cedric_Hombourger@mentor.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH v3] image: include image name in the kernel/initrd image copies
Date: Fri, 9 Nov 2018 12:04:43 +0100	[thread overview]
Message-ID: <0dca3794-b119-aa6a-6b1b-0061bc7fc559@siemens.com> (raw)
In-Reply-To: <012d3fdc-9740-938d-da25-e826efdce0de@ilbers.de>

On 26.10.18 14:58, Maxim Yu. Osipov wrote:
> On 10/25/18 5:46 PM, Cedric Hombourger wrote:
>> The kernel and initrd images are really image-specific (especially the later
>> as the initrd is created/updated as packages get installed into the root
>> file-system). Make sure we retain a per-image copy of these images in the
>> image deploy directory by inserting the name of the image (${PN}) into the
>> full name of the artifacts (set in ${KERNEL_IMAGE} and ${INITRD_IMAGE}).
>>
>> In addition, an IMAGE_FULLNAME variable is introduced to combine the three
>> components of the image name: the (base) name of the image, the name of the
>> distribution and the name of the machine. This variable is now used in the
>> start_vm script and the image classes (image, ext4-img and wic-img).
> 
> Applied to the 'next',

Just realized that we were trying to fix this issue at the wrong end. The proper 
fix is doing what OE does:

DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images/${MACHINE}"

Then we can revert this commit again.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2018-11-09 11:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  9:04 [PATCH] " Cedric Hombourger
2018-10-18  9:27 ` Jan Kiszka
2018-10-18  9:46   ` chombourger
2018-10-18 10:29     ` Jan Kiszka
2018-10-18 10:37       ` Jan Kiszka
2018-10-18 11:45       ` chombourger
2018-10-18 13:53         ` Jan Kiszka
2018-10-18 17:23           ` [PATCH v2] " Cedric Hombourger
2018-10-22 12:49             ` cedric_hombourger
2018-10-22 13:52               ` Jan Kiszka
2018-10-25 11:19                 ` Maxim Yu. Osipov
2018-10-25 11:20                   ` Cedric Hombourger
2018-10-22 15:24             ` Henning Schild
2018-10-25 11:50               ` Cedric Hombourger
2018-10-25 14:22                 ` Henning Schild
2018-10-25 14:46                   ` [PATCH v3] " Cedric Hombourger
2018-10-26 12:58                     ` Maxim Yu. Osipov
2018-11-09 11:04                       ` Jan Kiszka [this message]
2018-10-22 15:48       ` [PATCH] " Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dca3794-b119-aa6a-6b1b-0061bc7fc559@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox