From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 13 Jan 2026 16:13:27 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f191.google.com (mail-qt1-f191.google.com [209.85.160.191]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 60DFDQm7028381 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 13 Jan 2026 16:13:27 +0100 Received: by mail-qt1-f191.google.com with SMTP id d75a77b69052e-4ed782d4c7dsf149912361cf.2 for ; Tue, 13 Jan 2026 07:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1768317201; x=1768922001; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:x-original-sender :mime-version:subject:references:in-reply-to:message-id:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=CQMCCWNzktrKVcOh4gOcl2wbtkY3VIOCfWb1mrkWxSc=; b=Ia0gTHHhftOyYP8UiR11K+ox54dp0ZpKWzEN7VaaiA387zfrkwxrsVYvxPUGEQxcBv VDrb9epiMXqL8LMo5uutKo5D8UoIZrt7D7/xoM++rfzLz6NCFU7sBSs9LyGnnk5p/kZ7 VBxZxFf3ozAbzADJTswZvDfe8qHSQyaZF3LJrfOCG6ljp9Q9VVTHEyuvWkOW7poAptgL eetgc2wpxR1jKgAxvjbsLVMNKA+aquOhV9DaIZb7OzmAql9Do4/iySkyzWDPAjWMVhJf a0F4qXXWRsQFyQYzmQQHSEFSnuwSfhBxf4eptg7IcVFcrdufUCnLVdSiITFFrZJGz5Ve 8c9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768317201; x=1768922001; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-sender:mime-version:subject:references:in-reply-to :message-id:to:from:date:x-beenthere:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CQMCCWNzktrKVcOh4gOcl2wbtkY3VIOCfWb1mrkWxSc=; b=AAEC2y4cj1rcazL5djbEXhqDHx2LuPhBE1dZw8aEDg5zLSyIwzVxalq10X6O/SU4pM zFrg81lG4qUlT8gA95XbNKHlNtwZxlvCLOTJKqFxyhMLvCreIYK2mZATZdFnclrGovVB 8jMxO8QXZ5EkmRWaM2nRyXtxpfe+WO76rgfTIlIhEOMFs1Ck36xxxMfCJ7MQ2i78skbY llMg8Wb7ke8KPDEgeU+N80fAyhDyEdCJ4nrZOaGqqoihHZaQsptiD0iiwaSzntUvKF/R U9DCsfPNsxU0SbGaRrejJh7klDsuWuuzI7sctmmdDk4TJJXWVCuZP1xr62Q9s6ueDu3Q Q7rw== X-Forwarded-Encrypted: i=1; AJvYcCWEGH0956wFc4h6mURfyduS4UJexMTb1znta4iziVCuh5ZYAKVk2OYWRf4vE9SseSzvabdV@ilbers.de X-Gm-Message-State: AOJu0Yyc/bAx7Gn1/F7dMsghKLjMdSZY5SjsU6mG9UImo+kSaNyGS3RZ pdQH5PAmtuvOEH+v6zqFfqdTuhUkNizcRWlzXsdyyPpyBtjOCehTsb+Q X-Google-Smtp-Source: AGHT+IFcIO6WwVRnI9H2U98PQqISMjUHbcUwvpGQZ6OQOKK3M4AFhndoe6NL+WnuY7QkoVI7mm445w== X-Received: by 2002:a05:622a:4106:b0:4f4:db5f:6e00 with SMTP id d75a77b69052e-4ffb4a6d426mr284959871cf.49.1768317200583; Tue, 13 Jan 2026 07:13:20 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="AV1CL+EuB1bFL435H2/RXLnHD2tMLmlVJvbyltgxjyTo7b7ujQ==" Received: by 2002:ac8:580f:0:b0:4ed:9424:fa31 with SMTP id d75a77b69052e-4ffa72630dels164239641cf.2.-pod-prod-01-us; Tue, 13 Jan 2026 07:13:19 -0800 (PST) X-Received: by 2002:a05:620a:4611:b0:8c0:e5ac:af11 with SMTP id af79cd13be357-8c389421cc1mr2650750585a.87.1768317199563; Tue, 13 Jan 2026 07:13:19 -0800 (PST) Date: Tue, 13 Jan 2026 07:13:18 -0800 (PST) From: "'Badrikesh Prusty' via isar-users" To: isar-users Message-Id: <0e282996-91a7-4c2c-92b8-d00550eb1dben@googlegroups.com> In-Reply-To: <195b950564b846dfac8fe4772f76bb38b8eeef6a.camel@siemens.com> References: <20260113144832.3231870-1-badrikesh.prusty@siemens.com> <195b950564b846dfac8fe4772f76bb38b8eeef6a.camel@siemens.com> Subject: Re: [PATCH v2 1/2] image-postproc: ignore systemd preset failures MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_1054070_1796367539.1768317198281" X-Original-Sender: badrikesh.prusty@siemens.com X-Original-From: Badrikesh Prusty Reply-To: Badrikesh Prusty Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ZXQOwTWLM6rj ------=_Part_1054070_1796367539.1768317198281 Content-Type: multipart/alternative; boundary="----=_Part_1054071_1211650349.1768317198281" ------=_Part_1054071_1211650349.1768317198281 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, >> Hm. It's an assumption that this can only fail because of already-masked >> units, no? Looking at the implementation below it looks more like that >> we hide any error now. >> Definitely not just an assumption, that=E2=80=99s one concrete reason among= others. For example, I have a package that runs `systemctl mask ` in its postinst script of a package getting installed to rootfs during the=20 rootfs_install task. When the image postprocessing runs `systemctl preset ....` , it fails because it tries to enable that masked service. Thanks, Badrikesh On Tuesday, January 13, 2026 at 8:25:17=E2=80=AFPM UTC+5:30 Florian Bezdeka= wrote: > On Tue, 2026-01-13 at 09:48 -0500, 'Badrikesh Prusty' via isar-users > wrote: > > Add '|| true' to systemd preset invocation during image postprocessing > > to tolerate failures caused by already-masked units. > > Hm. It's an assumption that this can only fail because of already-masked > units, no? Looking at the implementation below it looks more like that > we hide any error now. > > >=20 > > Signed-off-by: Badrikesh Prusty > > --- > > meta/classes-recipe/rootfs.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/meta/classes-recipe/rootfs.bbclass=20 > b/meta/classes-recipe/rootfs.bbclass > > index 8485b32f..ef3ddb84 100644 > > --- a/meta/classes-recipe/rootfs.bbclass > > +++ b/meta/classes-recipe/rootfs.bbclass > > @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() { > > --show systemd || echo "" ) > >=20 > > if (test "$SYSTEMD_INSTALLED" =3D "installed"); then > > - sudo chroot '${ROOTFSDIR}' systemctl preset-all=20 > --preset-mode=3D"enable-only" > > + sudo chroot '${ROOTFSDIR}' systemctl preset-all=20 > --preset-mode=3D"enable-only" || true > > fi > > } > >=20 > > --=20 > > 2.47.3 > >=20 > > --=20 > > You received this message because you are subscribed to the Google=20 > Groups "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, send= =20 > an email to isar-users+...@googlegroups.com. > > To view this discussion visit=20 > https://groups.google.com/d/msgid/isar-users/20260113144832.3231870-1-bad= rikesh.prusty%40siemens.com > . > --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 0e282996-91a7-4c2c-92b8-d00550eb1dben%40googlegroups.com. ------=_Part_1054071_1211650349.1768317198281 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi,

>> Hm. It's an assumption that this can only= fail because of already-masked
>> units, no? Looking at the imp= lementation below it looks more like that
>> we hide any error n= ow.
>>

Definitely not just an as= sumption, that=E2=80=99s one concrete reason among others.
For ex= ample, I have a package that runs `systemctl mask <service>` in its
postinst script of a package getting installed to rootfs during th= e rootfs_install
task. When the image postprocessing runs `system= ctl preset ....` , it fails
because it tries to enable that maske= d service.

Thanks,
Badrikesh
On Tuesday, J= anuary 13, 2026 at 8:25:17=E2=80=AFPM UTC+5:30 Florian Bezdeka wrote:
<= /div>
On Tue, 2026-01-13= at 09:48 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Add '|| true' to systemd preset invocation during image po= stprocessing
> to tolerate failures caused by already-masked units.

Hm. It's an assumption that this can only fail because of already-m= asked
units, no? Looking at the implementation below it looks more like that
we hide any error now.

>=20
> Signed-off-by: Badrikesh Prusty <badrikes...@siemens.com>
> ---
> meta/classes-recipe/rootfs.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-rec= ipe/rootfs.bbclass
> index 8485b32f..ef3ddb84 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
> --show systemd || echo "" )
> =20
> if (test "$SYSTEMD_INSTALLED" =3D "installed&q= uot;); then
> - sudo chroot '${ROOTFSDIR}' systemctl preset-all -= -preset-mode=3D"enable-only"
> + sudo chroot '${ROOTFSDIR}' systemctl preset-all -= -preset-mode=3D"enable-only" || true
> fi
> }
> =20
> --=20
> 2.47.3
>=20
> --=20
> You received this message because you are subscribed to the Google= Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, = send an email to isar-users+...@= googlegroups.com.
> To view this discussion visit https:/= /groups.google.com/d/msgid/isar-users/20260113144832.3231870-1-badrikesh.pr= usty%40siemens.com.

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-use= rs+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-use= rs/0e282996-91a7-4c2c-92b8-d00550eb1dben%40googlegroups.com.
------=_Part_1054071_1211650349.1768317198281-- ------=_Part_1054070_1796367539.1768317198281--