From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057122428766388224 X-Received: by 2002:a05:600c:2251:: with SMTP id a17mr2911974wmm.102.1643738951675; Tue, 01 Feb 2022 10:09:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:694d:: with SMTP id r13ls185846wrw.3.gmail; Tue, 01 Feb 2022 10:09:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCJdGS7XLSPrHjQ4nGh/hlS6Rpmv5LNAldLWFZ9vdnRXX5+zCga1mPtXeRhmApVkicLRpc X-Received: by 2002:adf:f144:: with SMTP id y4mr12972078wro.310.1643738950718; Tue, 01 Feb 2022 10:09:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643738950; cv=pass; d=google.com; s=arc-20160816; b=t6oqNuc8XpE6MoQM22mBOJfsfuhnnx633OXC16GyucUax6dddacTMoLCE3uS3hs9V0 Ux8GirWdUtsfGnE7f+oc5oI3eYjXSHz0hW2lCntWkcgoty+w158ho4sKgOXzSSqvYSep s4XKoPPASagGKMJGDvsxldY/VXq1v8L4TvwCwME+32pIgCpasy0EuLScqvuyq/AhstzP bQrg1axtltQOYmNesnX/ymVtFKaKQApAAiwuCAtCtSF6FL5AO8tfqacu/7vc0cYwFRmD RR2bxuw83mv0/WUdT9WlpumHUF6dRxInefO23GSG+JwOlp3DDSLwDskFPHzFApL/JY6h O/cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=+onUJoqwESAJAIVBvbYW1aSpzQ0Bp51SORweuPnbksg=; b=09A6CbagmTSuwrLBY8bNRjjjKxeIXIIIpqDS8paSZhUDUUSD+5wO/dI+tbPM8LH1EB y/PA1xQvMFr0vXqNyRPgdr4ezFFZSxuOVPvQwxY0HNyDvMTVQZdyuNFIEGvWRgNzfqWh USWR5LvMhnqc6NnR3GqE0uq6QLeZ8ZEDC/gnNOwvCVnvsRvuhKBynR1Lpp63Kzz9UNAI k7QPaVN8hseWeAXUzrNtxA/9Xyc+6KUfSlZzSuX/64pNRex/5MFnU0IinSPwKlorD25C L9e/nG8fBRHB8PfDvgyrLsVbNJdpCb8jNbkx82LdE/6tW25io6NZBnNqVM7Y975JTX3V +3pQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=m0dFePdt; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::607 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20607.outbound.protection.outlook.com. [2a01:111:f400:7d00::607]) by gmr-mx.google.com with ESMTPS id az22si1005792wrb.5.2022.02.01.10.09.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Feb 2022 10:09:10 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::607 as permitted sender) client-ip=2a01:111:f400:7d00::607; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=m0dFePdt; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::607 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EEwy3Umx+5Xp3jEfb/5eeIhKDiJwLhxTxX2UiNmFQcFAJPq/bWjcbymg/N/2ewthmuoLoR0FBL9J9jcOgA9qyC/gkjLJ67x0DhKDGk8G+40ppsCD8x6JuEVrJtxF8EBgG5MWLfTL7YBUc9GcwwtI7k+nFnOkAHtO2XRnYmiyPFTPz5xaaNXtTTNHAhOewYB13TxNaepbqHUJbGN5CEEMpJIdjszUVE+5mFe6fxEHaE/MuKxSnSfP7ED/8Z9FFkZaCzr1Tpac4ej6LWTifBBWCdvXDOVu32qUlF4OvLuR7MPQwAjNedLwdNp8Al/wuc7lA0/jOdujjux1MmFHW8bmQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+onUJoqwESAJAIVBvbYW1aSpzQ0Bp51SORweuPnbksg=; b=c+ll7qO9/kmc2ram0Lv/MdKlgabEeqQ0412LdJI8BeoScuzeEPhA8XKiTojCl/L82AvpqPlaSOnND6eF6ZrT07G8ZBM1wK05uh3YmadNYl95XFpa1qsdyVIYz4i6LkT3G10lH3QoL1bWsf1fXP/JuwI0WZAevlytllZeJ9al0GVAw8Yi6AMmHUjJopUxM99f5KZ5+ROxB0cEA4+LehZLnFXGY7S42ndwQFZlK0ctwUwoOCKAx3gRZnokJN/rY/mJX2Ty7jrPjKqcvoHADjpKqgbcMprrV4VJn5BQHMxeKdgh3nsdswgjNO4FEKMvUyPL55AzZijtRTQhAHsh8hKAmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.73) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+onUJoqwESAJAIVBvbYW1aSpzQ0Bp51SORweuPnbksg=; b=m0dFePdtsXPbJ4x5Ojmn3KrLRtJGY87pYVhjexGBNolV0lzg3EhRtPIlRoiZAq6G58EdU/+j1FUsNTtg06VbJm4RyVkHAhQpwHgqX++GhWglx+D9yhihxuSU0+Tw69ZYzv9JErqgKap0JuEN8D/esddlDsV9CEQ/s/UakjB4NiN2lNArHjzH+gpUvand0GKpJc65zrGiz8tIW32vtNgP3ymAdw/8Qk5PiUCwzLifLLjt7AI+gqqTpH4R6jbY/vlZ+8Gvl81Fxw5fx0st5sws+29C8jiZTKJpU4oUwIRloNzwHbgtGoLVzr41UvPXJ9SBxa70nyMsd7tj3r715CS5AQ== Received: from AM6PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:6e::36) by AM0PR10MB3634.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:152::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 18:09:09 +0000 Received: from HE1EUR01FT059.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::c2) by AM6PR02CA0023.outlook.office365.com (2603:10a6:20b:6e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21 via Frontend Transport; Tue, 1 Feb 2022 18:09:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.73) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.73 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.73; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.73) by HE1EUR01FT059.mail.protection.outlook.com (10.152.0.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4951.12 via Frontend Transport; Tue, 1 Feb 2022 18:09:09 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SNA.ad011.siemens.net (194.138.21.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 1 Feb 2022 19:09:08 +0100 Received: from [167.87.32.84] (167.87.32.84) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 1 Feb 2022 19:09:08 +0100 Message-ID: <0e396fe1-889c-8c38-de5d-91274222b955@siemens.com> Date: Tue, 1 Feb 2022 19:09:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 07/12] sbuild: support of shell exports from dpkg_runbuild_prepend Content-Language: en-US To: Uladzimir Bely , References: <20220201170038.5723-1-ubely@ilbers.de> <20220201170038.5723-8-ubely@ilbers.de> From: Jan Kiszka In-Reply-To: <20220201170038.5723-8-ubely@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.84] X-ClientProxiedBy: DEMCHDC8A1A.ad011.siemens.net (139.25.226.107) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 361fdc36-d697-4aaa-9b7c-08d9e5adf174 X-MS-TrafficTypeDiagnostic: AM0PR10MB3634:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XAWo2KfhvYFvDoLhU3XQmId5mhJb6fGK8NPBu8yxT5gsry2sOeqtGBeGnbnWgWVeND6Gf0U390nykXNsix32rObuaT1ysGGoeDUnJf7EZNA/u11rYt0PNGWRPliTZW3LL1D8cn0f+jAPymCF9pNQY79GDw516yo4CccgbNcpwKiMuaT12H1H/5M8TJiNlIbFxwRJFTAYeXVkyaZ+0VnfhTyC+j8cNpXyf3u1bEFNe4/iWLmoL0aNtDwLTGwo08sQgRmzGYOhyMOtQNZaUjNRZ+15uqWiyzvgsJVjE/mTEf7m5CMSxnMPbbjqTHBWpRZCCU7iNce/o6mZEC9df8yvfgxmUA5tPlC/gspr++wYf1/WOrFqBjyazA3viTNWLKZEMB+LYeO3PrZgez/UBLaLkLtlHxbCOwK21AgV5D9gTsc7lPBheMvCnaU/0Swmw9PpQzzHobe8SBYxH7FpX45oDH/FFlR3d3S50GELTf08+DsJ/+X5Rk2JzLoJP+bqWJV/p5FDqru3DW7SeTnaD1RmfwTE59JT25SqGtlc7Brz7z7Mra2rQ8X6/cXR10sr5Hs86POQ0jYuCkIuthmdZNoolg9iwrgdegP0fp06KTmFCrUZrXkPnmSJJ6VkT1uJ/HTtkn46Gq52Xk97Xk4+HFBsJ34zQtAVhwjgBIoqAMSQ/9NX9VahkYf9hnobHmfN5yEKUKQRp2yPbgYFCMmoaz0tUKcMOoQ8O/pw1+d5mf96YTbV+QbPXS8HIu7gbkfnn56GvLTt15/ydE3C35I3PPRWjA== X-Forefront-Antispam-Report: CIP:194.138.21.73;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(356005)(16576012)(316002)(8936002)(40460700003)(82960400001)(44832011)(70586007)(70206006)(110136005)(5660300002)(36756003)(81166007)(31686004)(8676002)(6706004)(53546011)(508600001)(36860700001)(956004)(336012)(83380400001)(47076005)(31696002)(82310400004)(26005)(86362001)(16526019)(2616005)(186003)(2906002)(3940600001)(43740500002)(36900700001)(20210929001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 18:09:09.1866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 361fdc36-d697-4aaa-9b7c-08d9e5adf174 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.73];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT059.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3634 X-TUID: PGOgft2KbHhm On 01.02.22 18:00, Uladzimir Bely wrote: > Many of recipes often use shell exports done in dpkg_run_prepend, so that > this changed environment is used during build. > > While sbuild is performed in isolated environment, we need a way to > pass these variables to it. This is done by storing environment before > dpkg_runbuild (after prepare_build) and finding just before the actual > build what was changed or added. > > Signed-off-by: Uladzimir Bely > --- > meta/classes/dpkg.bbclass | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 66db7ec5..c252e9b3 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -29,12 +29,30 @@ do_install_builddeps[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > > addtask devshell after do_install_builddeps > > +DPKG_PREBUILD_ENV_FILE="${WORKDIR}/dpkg_prebuild.env" > + > +do_prepare_build_append() { > + env > ${DPKG_PREBUILD_ENV_FILE} > +} > + > # Build package from sources using build script > dpkg_runbuild() { > E="${@ isar_export_proxies(d)}" > E="${@ isar_export_ccache(d)}" > export PARALLEL_MAKE="${PARALLEL_MAKE}" > > + env | while read -r line; do > + # Filter the same lines > + grep -q "^${line}" ${DPKG_PREBUILD_ENV_FILE} && continue > + # Filter some standard variables > + echo ${line} | grep -q "^HOME=" && continue > + echo ${line} | grep -q "^PWD=" && continue > + > + var=$(echo "${line}" | cut -d '=' -f1) > + value=$(echo "${line}" | cut -d '=' -f2-) > + sbuild_export $var "$value" > + done > + > profiles=$(grep "DEB_BUILD_PROFILES" ${SBUILD_CONFIG} | tail -n1 | cut -d "'" -f 4) > if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then > profiles="${profiles} cross nocheck" So, this basically decouples "Avoid using shell environment during the build" and similar conversions downstream from this series, right? It's indeed good to have a compat path now. However, what are the patterns we want to push? Avoiding exports? Then we should probably warn here that this compat path should be avoided and might be removed in the future. If we want to keep both, we can probably leave several recipes alone in that other series. Jan -- Siemens AG, Technology Competence Center Embedded Linux