Re: [PATCH 2/3] meta-isar: Add example for user settings

[Quirin Gylstorff <quirin.gylstorff@siemens.com>]

On 7/23/19 10:08 AM, Henning Schild wrote:
> Am Fri, 19 Jul 2019 14:38:22 +0200
> schrieb Quirin Gylstorff <quirin.gylstorff@siemens.com>:
> 
>> Add a new image which creates two user. One with default skel from
>> /etc/skel the other from /etc/extra-skel
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   .../example-user-skel_0.1.bb                  | 20 ++++++++++++
>>   .../recipes-core/images/isar-image-user.bb    | 31
>> +++++++++++++++++++ 2 files changed, 51 insertions(+)
>>   create mode 100644
>> meta-isar/recipes-app/example-user-skel/example-user-skel_0.1.bb
>> create mode 100644 meta-isar/recipes-core/images/isar-image-user.bb
>>
>> diff --git
>> a/meta-isar/recipes-app/example-user-skel/example-user-skel_0.1.bb
>> b/meta-isar/recipes-app/example-user-skel/example-user-skel_0.1.bb
>> new file mode 100644 index 0000000..c53d7f6 --- /dev/null
>> +++ b/meta-isar/recipes-app/example-user-skel/example-user-skel_0.1.bb
>> @@ -0,0 +1,20 @@
>> +# Sample Skel modifiction for ISAR
>> +#
>> +# This software is a part of ISAR.
>> +# Copyright (C) Siemens AG, 2019
>> +#
>> +# SPDX-License-Identifier: MIT
>> +
>> +DESCRIPTION = "Sample Skel modifiction for ISAR"
>> +MAINTAINER = "Your name here <you@domain.com>"
>> +DEBIAN_DEPENDS = "apt (>= 0.4.2), passwd, bash"
> 
> This looks wrong and copied from an outdated example-raw. My guess is
> this one can be empty.
> 
My mistake, I will remove the dependencies.
>> +
>> +inherit dpkg-raw
>> +
>> +do_install() {
>> +	bbnote "Create a fake extra skel"
>> +	echo "# empty config file" > ${WORKDIR}/${PN}.conf
>> +	install -v -d ${D}/etc/extra-skel
>> +	install -v -m 644 ${WORKDIR}/${PN}.conf
>> ${D}/etc/extra-skel/${PN}.conf +}
>> \ No newline at end of file
>> diff --git a/meta-isar/recipes-core/images/isar-image-user.bb
>> b/meta-isar/recipes-core/images/isar-image-user.bb new file mode
>> 100644 index 0000000..f8464f0
>> --- /dev/null
>> +++ b/meta-isar/recipes-core/images/isar-image-user.bb
>> @@ -0,0 +1,31 @@
>> +# User image recipe
>> +#
>> +# This software is a part of ISAR.
>> +# Copyright (C) Siemens AG, 2019
>> +#
>> +# SPDX-License-Identifier: MIT
>> +
>> +DESCRIPTION = "User Isar image"
>> +
>> +LICENSE = "gpl-2.0"
>> +LIC_FILES_CHKSUM =
>> "file://${LAYERDIR_core}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe"
>> + +inherit image
>> +
>> +IMAGE_INSTALL += "example-user-skel"
>> +
>> +# create a user isar with no password and default home
>> +USERS += "isar"
>> +USER_isar[password] = ""
>> +USER_isar[uid] = "1000"
>> +USER_isar[groups] = "audio video "
>> +USER_isar[shell] = "/bin/bash"
>> +USER_isar[flags] = "allow-empty-password create-home"
>> +# create a user isarskel with no password and home generated
>> from /etc/extra-skel +USERS += "isarskel"
>> +USER_isarskel[password] = ""
>> +USER_isarskel[uid] = "2000"
>> +USER_isarskel[groups] = "audio video "
>> +USER_isarskel[shell] = "/bin/bash"
>> +USER_isarskel[skel] = "/etc/extra-skel"
>> +USER_isarskel[flags] = "allow-empty-password create-home"
> 
> I am not sure an extra image type makes a whole lot of sense here.
> Either isar-image-base or nothing i guess. Some sort of test would be
> nice but an extra image is too much.
> 
> Have a look at meta-isar/conf/local.conf.sample, that is the root of
> running raw isar and it is used for CI testing.
> 
> Henning
> 

OK thanks for the hint,  I will move the user settings to the base image.

Quirin