From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6519007876157014016 X-Received: by 10.223.182.161 with SMTP id j33mr4867811wre.16.1517825887209; Mon, 05 Feb 2018 02:18:07 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.199.10 with SMTP id x10ls1516875wmf.9.gmail; Mon, 05 Feb 2018 02:18:06 -0800 (PST) X-Google-Smtp-Source: AH8x227+BUeTvfQC9Cdwj1zMMUDwPcFv4VWi7VuY5G9HoEL/cVPonzmxSHxcPWloNhMCdKo9nqVB X-Received: by 10.28.28.197 with SMTP id c188mr5030216wmc.6.1517825886659; Mon, 05 Feb 2018 02:18:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517825886; cv=none; d=google.com; s=arc-20160816; b=a4gI5yvO5IKYZ4aNa5ZosbsKl2qc5+fBV6g8/x3uw6Ar5uK8hWWy4o28G+gQNe/EJA F6Uo1d1DwMh/GhTHFlQsANu1E1Tl0ybIc0yNpxzBPog0dc1xQTksgN9rc1bYg2MZuPxG 1Pusste8GNRzO6JF3FuVnrPF4HWVdaq7TurvF/bhglXKRWXT9rIk8WR45cFQkRAIJJk1 IJAYSUuANDiCToVFh2migsMJXtdlEerRzVCT0i2iAJO1OPRV/gYDOoFWFjQS7LUwLbR/ M/UP9Nm0xiMnMkrkfMXR7TjtrbyKRql7PzrxSjD2vueq9ZLqIrN7NJ62TLq63h2AMmXK BE5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=/FZO8Wmk+1OUQ7my6JE7LmXbHxHsSumnLyDr1/qHyiY=; b=rUdPtBbPgpDUqsdVUnJ/xTMyId5KpD/dXVG7UPNeSdqW+iE81I+FkOV5UUfHWHk00+ xqggxWXZNiDhVab0F479EVwdt0P0uQRRoEUweAnjY936NA37b/9HD0QAZ1RKwmkUQCM4 FxkXD8sSQl+Wy2kKQSKew8YZxWNF+gc+dfAsWtVDmPDstt+vlOaGXjNZV5hBQLe8IZP6 mR+vXOCk2oZVCg+63DJYtOPZmlqIFLCgfxN8s73RRJJOik96jJzSFWn7g/iZces++Wzk 1jskB4NKVOpIE3U1YggXOrH2YWeOZrNrxTQtr3LxXfaXK4klBdw2+l3ZIqCni4ZJXfKM o0uw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i75si365210wmg.1.2018.02.05.02.18.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 02:18:06 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w15AI6JB026831 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Feb 2018 11:18:06 +0100 Received: from [167.87.56.101] ([167.87.56.101]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w15AI5w9012240; Mon, 5 Feb 2018 11:18:05 +0100 Subject: Re: [PATCH 3/5] buildchroot: Enable isar-apt To: Alexander Smirnov , isar-users@googlegroups.com References: <20180205095931.23903-1-asmirnov@ilbers.de> <20180205095931.23903-4-asmirnov@ilbers.de> From: Jan Kiszka Message-ID: <0f008581-a852-79fa-f67e-6361c4ca35ed@siemens.com> Date: Mon, 5 Feb 2018 11:18:05 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180205095931.23903-4-asmirnov@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: FpSGHsYxjjqv On 2018-02-05 10:59, Alexander Smirnov wrote: > This patch provides access to isar-apt from buildchroot. It does the > following: > - mount isar-apt during buildchroot building. > - umount isar-apt using bitbake events. > > Also it needs to keep Isar build tree clean from any mounts despite on whether > build succeed of failed. bitbake provides various events that could trigger > custom python hooks. In this patch BuildCompleted event is used, which happened > when bitbake finished its execution despite on the result. > > Signed-off-by: Alexander Smirnov > --- > meta-isar/conf/local.conf.sample | 3 +++ > meta/classes/isar-events.bbclass | 20 ++++++++++++++++++++ > meta/recipes-devtools/buildchroot/buildchroot.bb | 7 +++++++ > .../buildchroot/files/multistrap.conf.in | 8 +++++++- > 4 files changed, 37 insertions(+), 1 deletion(-) > create mode 100644 meta/classes/isar-events.bbclass > > diff --git a/meta-isar/conf/local.conf.sample b/meta-isar/conf/local.conf.sample > index 2ae43e7..fc760ed 100644 > --- a/meta-isar/conf/local.conf.sample > +++ b/meta-isar/conf/local.conf.sample > @@ -158,3 +158,6 @@ IMAGE_INSTALL = "example-hello example-raw" > # > # Default parallel jobs for bitbake: > BB_NUMBER_THREADS = "4" > + > +# Add event handlers for bitbake > +INHERIT += "isar-events" > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > new file mode 100644 > index 0000000..55fc106 > --- /dev/null > +++ b/meta/classes/isar-events.bbclass > @@ -0,0 +1,20 @@ > +# Isar event handlers. > +# > +# This software is a part of ISAR. > +# Copyright (C) 2015-2017 ilbers GmbH > + > +addhandler isar_handler > + > +python isar_handler () { > + import subprocess > + > + devnull = open(os.devnull, 'w') > + > + if isinstance(e, bb.event.BuildCompleted): > + bchroot = d.getVar('BUILDCHROOT_DIR', True) > + > + # Clean up buildchroot > + subprocess.call('/usr/bin/sudo /bin/umount ' + bchroot + '/isar-apt || /bin/true', stdout=devnull, stderr=devnull, shell=True) > + > + devnull.close() > +} > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb > index 51f9d5d..cb90148 100644 > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb > @@ -33,6 +33,7 @@ WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" > > do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > do_build[dirs] = "${WORKDIR}/hooks_multistrap" > +do_build[depends] = "isar-apt:do_cache_config" > > do_build() { > E="${@ bb.utils.export_proxies(d)}" > @@ -58,6 +59,9 @@ do_build() { > -e 's|##DIR_HOOKS##|./'"$WORKDIR_REL"'/hooks_multistrap|g' \ > "${WORKDIR}/multistrap.conf.in" > "${WORKDIR}/multistrap.conf" > > + [ ! -d ${BUILDCHROOT_DIR}/isar-apt ] && install -d -m 555 ${BUILDCHROOT_DIR}/isar-apt > + sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt > + > [ ! -d ${BUILDCHROOT_DIR}/proc ] && install -d -m 555 ${BUILDCHROOT_DIR}/proc > sudo mount -t proc none ${BUILDCHROOT_DIR}/proc > _do_build_cleanup() { > @@ -73,6 +77,9 @@ do_build() { > # Install package builder script > sudo install -m 755 ${WORKDIR}/build.sh ${BUILDCHROOT_DIR} > > + # Create share point for isar-apt > + sudo install -d ${BUILDCHROOT_DIR}/isar-apt > + > # Configure root filesystem > sudo chroot ${BUILDCHROOT_DIR} /configscript.sh > _do_build_cleanup > diff --git a/meta/recipes-devtools/buildchroot/files/multistrap.conf.in b/meta/recipes-devtools/buildchroot/files/multistrap.conf.in > index a0b28e3..480a4b8 100644 > --- a/meta/recipes-devtools/buildchroot/files/multistrap.conf.in > +++ b/meta/recipes-devtools/buildchroot/files/multistrap.conf.in > @@ -6,7 +6,7 @@ noauth=true > unpack=true > ignorenativearch=true > bootstrap=##DISTRO_MULTICONF_BOOTSTRAP## > -aptsources=##DISTRO_MULTICONF_APTSOURCES## > +aptsources=isar-apt ##DISTRO_MULTICONF_APTSOURCES## > configscript=##CONFIG_SCRIPT## > setupscript=##SETUP_SCRIPT## > hookdir=##DIR_HOOKS## > @@ -29,3 +29,9 @@ source=##DISTRO_APT_SOURCE_SEC## > suite=##DISTRO_SUITE##/updates > components=##DISTRO_COMPONENTS## > omitdebsrc=true > + > +[isar-apt] > +source=file:///isar-apt > +suite=isar > +components=main > +omitdebsrc=true > On first glance, this looks identical to v1 which I tried over the current bitbake version we have in Isar. There I see two issues: - umount does not work if the build fails - re-mount will not happen if the buildchroot was built in a previous run and only a depending packages is built now Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux