From: Jan Kiszka <jan.kiszka@siemens.com>
To: <isar-users@googlegroups.com>
Subject: Re: [PATCH] template: Make templates passthrough
Date: Mon, 13 Dec 2021 11:53:10 +0100 [thread overview]
Message-ID: <0fabf982-d214-d4ea-7691-e8ddc7b644b8@siemens.com> (raw)
In-Reply-To: <20211210113023.GL22100@yssyq.m.ilbers.de>
On 10.12.21 12:30, Baurzhan Ismagulov wrote:
> On Mon, Nov 15, 2021 at 04:57:45PM +0100, Henning Schild wrote:
>> always keep as with all other templates, unless it makes debian unhappy.
>
> It does. In short, this patch:
>
> * Removes spurious source changes for proper source package and .changes
> generation
>
> * Keep the permissions the same as for the template files
>
> Since sbuild requires proper source packages (which is a Good Thing), this
> patch is also a pre-requisite for sbuild. If there are no objections, we would
> like to apply this next week.
>
The patch is correct when it works on template files that have been
copied from the workdir to some place where they are unexpected. The
patch is incorrect in removing files from the workdir where the fetcher
put them.
And, as Henning pointed out, that option to keep the input files is
redundant if the problem is solved properly - we must keep anyway what
the fetcher placed into workdir.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2021-12-13 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 15:09 Anton Mikanovich
2021-11-15 15:57 ` Henning Schild
2021-11-16 16:35 ` Anton Mikanovich
2021-12-10 11:30 ` Baurzhan Ismagulov
2021-12-13 10:53 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fabf982-d214-d4ea-7691-e8ddc7b644b8@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox