From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6656673633724792832 X-Received: by 2002:a5d:5003:: with SMTP id e3mr1781427wrt.14.1549889589871; Mon, 11 Feb 2019 04:53:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f70e:: with SMTP id r14ls2500853wrp.10.gmail; Mon, 11 Feb 2019 04:53:09 -0800 (PST) X-Google-Smtp-Source: AHgI3IYNbEiVZtL4RIZy1M33nyTMoUoRyvjlPsQLB7UA6yZ72Xh2c3X7ey4hwfMw/0UKEEvzlv2m X-Received: by 2002:adf:dbd0:: with SMTP id e16mr700548wrj.31.1549889589343; Mon, 11 Feb 2019 04:53:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549889589; cv=none; d=google.com; s=arc-20160816; b=RiXfmI5T/zCLnldoL3uClovnNXE0s5fpbOyYz0TSlnQQG22qrzrMX+/sNsed5e+B/D NGzL/7lL06lHqX0rl/oEZtc6pb8KqUZxHy5sCXKA2Y9I40/iHUjZAIc5/JfZTDUmIvQ6 7ikmHKHibaH/QgKnVpD4OqJH5KHNocH5cKNQwB5Ob5V9i1d5842PKZ4LYgrfr7qrJY25 S4u/C4lYNi1jDousuheK7z8GpuZMPZ3uPSqXoWkjXNxFJ0BhN1XT5bRV/6Ox+DO2UoOc HCmMb/OejKZWlwo5nTrFEqSVDkL+KuaEZh9u58wPeeO8+y6q0XGEcimw7Mr1hsDSMiya +F/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=3hGeG0cq61KIloGwIvizq68QX3R2T8MeEuRRUBggK2c=; b=yJH0YH2L+cGbpAIaJ6nMbj2R4SQbv9/Qo9wIjnhCh6/6kiAWhPS8/FE3iqZuVJGSp+ IsF3iMbEpAnryckoL+A4OGLLnhVuQVFRHSJ8FptN2eH9Mnwgn/N5ErqGNCdvDrt14UMv Vq2ihX+gDBdh0xwWVpo5XVM1Q9RwvbAilvrQQ3Fe39uyM6nmj79vLg12qW7h409PW5jc QAFCx2kfm2HqrNQD5ze2FFFaxUT+xa3JCOzpn+OeCgkyggFUPrCyzXtOpj2+YvRTU9Om QJbgBm0i/TcemHJazfPWiFOcOEntFbY/Y0K++NodkF4d/z+SK37BToccpM6Mzmv7/Yqm MJzg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id r6si428499wrv.2.2019.02.11.04.53.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 04:53:09 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x1BCr8Qc006132 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Feb 2019 13:53:08 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x1BCr8mV029788; Mon, 11 Feb 2019 13:53:08 +0100 Subject: Re: [PATCH] dpkg-base: apt-get "update" before "source" To: "[ext] Henning Schild" , isar-users@googlegroups.com References: <20190211093324.1444-1-henning.schild@siemens.com> <20190211103526.3d92babf@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <0ff54328-5b30-e645-619e-0eaac9c184b5@siemens.com> Date: Mon, 11 Feb 2019 13:53:07 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190211103526.3d92babf@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Nq2vU69E4Nnc On 11.02.19 10:35, [ext] Henning Schild wrote: > Here i see an often repeating pattern. That "apt-get update" is now > present in many entry points to the buildchroot. > I guess we should factor it out and put it into a central place. And > the rule of thumb probably is ... whenever you use anything apt, > apt-get update before you do ... If you are only talking about updating our locally maintained repo (like below), that is fine to factor out and reuse. However, we must not update against public repos after the initial pulling, in order to ensure we have a consistent package set along the whole build. Jan > > Henning > > Am Mon, 11 Feb 2019 10:33:24 +0100 > schrieb Henning Schild : > >> From: Henning Schild >> >> When rebuilding we can run into an inconsistent view where buildchroot >> assumes it could download the sources of a modified upstream package. >> After a "reprepro ... remove" we always need to "apt-get update" to >> not operate on an old version of the metadata. >> >> Signed-off-by: Henning Schild >> --- >> meta/classes/dpkg-base.bbclass | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index 175dc80..5425df8 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -31,6 +31,10 @@ do_apt_fetch() { >> fi >> dpkg_do_mounts >> E="${@ bb.utils.export_proxies(d)}" >> + sudo -E chroot ${BUILDCHROOT_DIR} /usr/bin/apt-get update \ >> + -o >> Dir::Etc::sourcelist="sources.list.d/isar-apt.list" \ >> + -o Dir::Etc::sourceparts="-" \ >> + -o APT::Get::List-Cleanup="0" >> sudo -E chroot --userspec=$( id -u ):$( id -g ) >> ${BUILDCHROOT_DIR} \ sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}' >> dpkg_undo_mounts > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux