From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7138269680747151360 X-Received: by 2002:a05:600c:350:b0:3a5:3473:1c23 with SMTP id u16-20020a05600c035000b003a534731c23mr5045600wmd.9.1662031275254; Thu, 01 Sep 2022 04:21:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:247:b0:221:24a2:5cf with SMTP id m7-20020a056000024700b0022124a205cfls2621916wrz.0.-pod-prod-gmail; Thu, 01 Sep 2022 04:21:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR6xtYnV6lWCLtIBCNQWtjy/98aq/WQdiRwrpKNvEflJ0DNNmHsOKbdMcu3F7C8qOBNWrSLQ X-Received: by 2002:a5d:5c0a:0:b0:225:b956:4e56 with SMTP id cc10-20020a5d5c0a000000b00225b9564e56mr14219616wrb.218.1662031273935; Thu, 01 Sep 2022 04:21:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662031273; cv=pass; d=google.com; s=arc-20160816; b=xmcnztKG93AmavGC30CXK/VodWHlYqQCdMMY2M7JZUH0HQ1NwH7aIpS0TyN2JZSFAO 2CgmqYXNleLCol76zh+IBkqIj4ByZEuQZS6m4R69cg6LStjZsnF3sk4NscKzXYBE9HW4 ychhTHSCts1oZizOjrnuw8nEqHHKGf6UFu55m+cQaItlxl5SPeryqyxOznBajDRGNBqW BMsvmQGd+hc8yH9iWEsU5Yw9GhiiXyGfA2xmYYA11ZDBfHu1LUdrjGW/2aJo88n17GAN /I++hJu4DN1aZtCklREhp3zbTGD9PJ32O3689KdMFrKorUtXuKrBrDzlgQ6xbjCTb+Vq nKVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=dSJnCrO6z7xDbvd9A8eQ3MPGSi1B8TmaOuHXXXApIMo=; b=Az6O38sirSvMp3O89/2v0WAeZQm7EZcdLRVAxgs7O1ISHixj645EZUx5BMxTMCg/AD vCL1ky5nJUA35XbWcuVFW89J/37ZxdJ3ULUkrzm83gb6YUMU/04bQTLl1wImoVilijJK dH2MUaz6CbD4WZCHYKGaQr3Kcz8ihKaMH8nJTzKfx07ZC7hwws+R/fQs6ZyqY+E9hxGE V6gMDjr1cUJkJPh6TSePrvBKaMBjRoN/WMTSoTH3IXw6zwPgpkYxLQFWaK00GxKfmc9r 2FlDq4NLFBwQrdWXj8CwPllViAu1OQ6FOkyUGlBaC5EL/bL5nnglVo+q8Qcha43B156e f7og== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=V0Z0soyf; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70040.outbound.protection.outlook.com. [40.107.7.40]) by gmr-mx.google.com with ESMTPS id n20-20020a05600c501400b003a5b20f80f5si286468wmr.1.2022.09.01.04.21.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2022 04:21:13 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.40 as permitted sender) client-ip=40.107.7.40; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=V0Z0soyf; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1viEGEQ/g7ijriuTom3HYnj++miHMNOMGWjffH2XJ1mwcjjWwspI3CTPoCibED9/8b6O7Dl7hibh1aLwZHYRoCcgZqs1JeLb585RiwRN7nDu5IF2Y+cFO9Gdxj6z8UkL31rb1IbsOY038ljq+ro86yMwOoluOhihdmMO4dez/KyhRLKG+QikgWqMnUzKkf+/XrBp+b2Gqu2RgQrdWG4IK2/pC4YNyczgS2+VmWVd9F+rnPkvpM6784w6t45lKkDsWYfsQRymxwF1U7lDSTVEChNAa7VMpEloi3pmuwaQt8yEeqzlvCsnktdr5RDmXI+Xp9NT7h664xSLi/ulR5ZBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSJnCrO6z7xDbvd9A8eQ3MPGSi1B8TmaOuHXXXApIMo=; b=DUd4uLB3/0oB/AyKrmeajyHfMXsAgnB41DgQ2DF4m1BFzmgh3Kd5vUDkeFqmNRa/fZjCR+Mtha6u3suX5XMMpbN4XPZKkoupjJPzaVtNrvoPVgNU5uowyVke9XQKiQ6o1wHRhPIBzO7QnTY72+7dR7Hedmb8O7/CIluTNTpxEc4lLQ8ghFyEy1UD1e316UhtR0Fk4i0RIkS3Mq487U6GAnTSjVJzYx80p7LImuWZCs1HIE+xysfRnrRgtG8NyNtMYU0Zr4mUp9HcmdohYDHrxSjEiLy9y0RfOaujCMIweFUW6DQxMH5HRbN4ZH6cYkOPWaEIFbfWGw2QmBGmnIP0gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.74) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSJnCrO6z7xDbvd9A8eQ3MPGSi1B8TmaOuHXXXApIMo=; b=V0Z0soyfHZIhxnFBPhcijDmEkVMl8Nu0ldB/xmTLmJ2FGKvgB1GJPXuZpDzNIpP3brU3uLg/Zz+lS75ytjZC0PZdyT6nDAmk8YxW1Dvu2ekEBw5OGqremeHawjySoCNKIX5rqop+ZVCyH2Cyc0IPUbr3KY3wSXIYCVyn6tqANcCNeRZHDM5ZtpdffZvmNus0LUrMPz8ZLju3Cu2TLMqd+EmhN5F86tlYebne7NWG69S7QrKUdWvZ5MWWb2KyeSfk870eWxv3DLAeNtlF0qYNJDlUEGL/6rXFinVNDqQTaLd+10t7lKmWG44m+GFN9MRwOpfQ1hZ05Yu0DRkpafenwg== Received: from DB6PR0601CA0012.eurprd06.prod.outlook.com (2603:10a6:4:7b::22) by PAXPR10MB5637.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:243::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 11:21:12 +0000 Received: from DB5EUR01FT025.eop-EUR01.prod.protection.outlook.com (2603:10a6:4:7b:cafe::b7) by DB6PR0601CA0012.outlook.office365.com (2603:10a6:4:7b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 11:21:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.74) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.74 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.74; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.74) by DB5EUR01FT025.mail.protection.outlook.com (10.152.4.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 11:21:12 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VQA.ad011.siemens.net (194.138.21.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Thu, 1 Sep 2022 13:21:11 +0200 Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Thu, 1 Sep 2022 13:21:11 +0200 Message-ID: <0ff9a2e3-5aec-f604-d1d4-6978193403c6@siemens.com> Date: Thu, 1 Sep 2022 13:21:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/2] opensbi-sifive-fu540: Fix build with binutils 2.38 Content-Language: en-US To: Uladzimir Bely , References: <20220901045201.9294-1-ubely@ilbers.de> <20220901045201.9294-3-ubely@ilbers.de> From: Jan Kiszka In-Reply-To: <20220901045201.9294-3-ubely@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.25.68.37] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--14.582800-8.000000 X-TMASE-MatchedRID: qeBAs1OleyY5QaOxwNGfvo9bHfxDWoibXSJ4c3nT+QeTeuX4xo2DEEyQ 5fRSh265zP9LEqj2YnhGIzSvkOhmQOUZ4LV9ny+dB6v+5gVW3HIIasXPlctLdD8Ckw9b/GFeovA /6ONsv0rFlplu6sV5VvF1bqtPiQUi6zBPuCbw++nsaDY1jE+0qDgdazg4t/q/LIrMljt3adtgVM 903mVhiiBQRBOQhaJi9fBfIr/Z3NS2gLrBTU007okcMgUzVryJZjB2MkVgi787/z3woaa9tGnjG is711KZrFjA6CZN1k0lYTzvR9yKDrOApq74wt7heKnhVGNo31vk0jVFgcafFTLRY601LrakGfZI mb3fqAT3aTNmWiTJHmluU0XZ+boz1CJJbWkgILIMs5kCh42BCZXvqupO0P3ML8y5bOx03xkORjM 32hn2b4Fum2PEjqt1o8WMkQWv6iUD0yuKrQIMCAGLeSok4rrZC24oEZ6SpSkj80Za3RRg8GvQ/Y MhttWhoLWUVnXhYWvoZp24xR9KUk5Hcu6HaMWepI8EFEZVbig= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--14.582800-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 1098BFB08850C266DD5D593EBE7CCEA4AD034A44D1B755423C3AEFB66138A5B62000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 890f9faa-ebdf-46c8-ecd5-08da8c0c1398 X-MS-TrafficTypeDiagnostic: PAXPR10MB5637:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +CyAtTX07hoPxLJrXm83M7d1ib5BT1WN7lCaKypto2CPTusszJRfXboClSKptAslRX7Lity7I89Dk8b0x1Mue86dajJ4xHPAdVn/paTvR/Y7wS12BIXurZPIoG/JueS7wlLIyejlC7j4q+OlhYweHRTsFMbY+y1se+7rcjNzSxfVzKKBWUXvp3Of6uM4L6bLXVFr5XhkIY5RIu8+c9Y+L4EYYigcv7tWpQh9gf05N0paWj0h/aOu6yNOhi1brakVWSMwW1fhZK+HuR/5tl46a3wVkLTmbXAwvXdi1VIhbeceTKuwiOqMoJCuDS4n4iFgtgZSn3s0NAmsQkKykXMelayz2FkjKb7zF9GyCGa4VJXghuEKVCA0JaXl7v8LeanquiGs1sbOUy73Auk5/stgRtDorLL6+uECvu0VfXV1E9VvHcN5gEJWCUbxQ24sdLn8Knwj+qm0PTMusvMAhVGHwO4s/UGF1oRFG7f0BkySvVPxjMEsoHJhcxNFRQdHPtmHg5MvrtZFEFSdo+8r70ePfCsc1Psl9mK+JZVsRb1AQQombYZZZpmVRtccZRYNUMf3Ic2RdrvwkpU0DQ5Vwqrx4cnVELRZujZEvFAPXc4U6OFN/8NXDuJZ09QtqiJLWZL8yG+nLPsBdqY+184i/6s8MK1AtVRuRELqnkQjlnkF7gKcRfzxWJ+sgtEL4Y5icf4SMLHGCmZoJV0JadnQVpMfNeLWEXXhh972Yy4lXwtMmeav+dpcKq0Tp5mTiUqklEkCMOWBfUlJM0vqPmr/2BLs5FN/a3D3rNwL4227MMacbGb1wnQYcJfIxbJ7V/8he5XDKssugqL+W/KYTwNmxjOxkH1fvFPxOzTjHsTJJIARjDTjgN8ycbE5DaGMTG1Sxvgd/qlc8Xdvhqg70n0WHs9cCA== X-Forefront-Antispam-Report: CIP:194.138.21.74;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(396003)(36840700001)(40470700004)(46966006)(70586007)(83380400001)(47076005)(186003)(70206006)(2616005)(956004)(16526019)(110136005)(36756003)(966005)(316002)(16576012)(31686004)(6706004)(2906002)(26005)(53546011)(86362001)(40460700003)(31696002)(8936002)(41300700001)(336012)(478600001)(5660300002)(8676002)(82310400005)(44832011)(36860700001)(40480700001)(82740400003)(356005)(7636003)(7596003)(82960400001)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 11:21:12.1850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 890f9faa-ebdf-46c8-ecd5-08da8c0c1398 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.74];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT025.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5637 X-TUID: +I00Evn9TklY On 01.09.22 06:52, Uladzimir Bely wrote: > Backport of https://github.com/riscv-software-src/opensbi/commit/5d53b55 > from opensbi-1.1. > > Signed-off-by: Uladzimir Bely > --- > ...akefile-fix-build-with-binutils-2.38.patch | 58 +++++++++++++++++++ > .../opensbi/opensbi-sifive-fu540_0.9.bb | 1 + > 2 files changed, 59 insertions(+) > create mode 100644 meta-isar/recipes-bsp/opensbi/files/0001-Makefile-fix-build-with-binutils-2.38.patch > > diff --git a/meta-isar/recipes-bsp/opensbi/files/0001-Makefile-fix-build-with-binutils-2.38.patch b/meta-isar/recipes-bsp/opensbi/files/0001-Makefile-fix-build-with-binutils-2.38.patch > new file mode 100644 > index 00000000..d52a4695 > --- /dev/null > +++ b/meta-isar/recipes-bsp/opensbi/files/0001-Makefile-fix-build-with-binutils-2.38.patch > @@ -0,0 +1,58 @@ > +From 5d53b55aa77ffeefd4012445dfa6ad3535e1ff2c Mon Sep 17 00:00:00 2001 > +From: Aurelien Jarno > +Date: Fri, 28 Jan 2022 18:33:46 +0100 > +Subject: [PATCH] Makefile: fix build with binutils 2.38 > + > +From version 2.38, binutils default to ISA spec version 20191213. This > +means that the csr read/write (csrr*/csrw*) instructions and fence.i > +instruction has separated from the `I` extension, become two standalone > +extensions: Zicsr and Zifencei. As the kernel uses those instruction, > +this causes the following build failure: > + > + CC lib/sbi/sbi_tlb.o > +<>/lib/sbi/sbi_tlb.c: Assembler messages: > +<>/lib/sbi/sbi_tlb.c:190: Error: unrecognized opcode `fence.i' > +make: *** [Makefile:431: <>/build/lib/sbi/sbi_tlb.o] Error 1 > + > +The fix is to specify those extensions explicitly in -march. However as > +older binutils version do not support this, we first need to detect > +that. > + > +Signed-off-by: Aurelien Jarno > +Reviewed-by: Bin Meng > +Tested-by: Alexandre Ghiti > +Reviewed-by: Anup Patel > +--- > + Makefile | 9 ++++++++- > + 1 file changed, 8 insertions(+), 1 deletion(-) > + > +diff --git a/Makefile b/Makefile > +index d6f097d..a294f46 100644 > +--- a/Makefile > ++++ b/Makefile > +@@ -106,6 +106,9 @@ ifndef PLATFORM_RISCV_XLEN > + endif > + endif > + > ++# Check whether the assembler and the compiler support the Zicsr and Zifencei extensions > ++CC_SUPPORT_ZICSR_ZIFENCEI := $(shell $(CC) $(CLANG_TARGET) $(RELAX_FLAG) -nostdlib -march=rv$(OPENSBI_CC_XLEN)imafd_zicsr_zifencei -x c /dev/null -o /dev/null 2>&1 | grep "zicsr\|zifencei" > /dev/null && echo n || echo y) > ++ > + # Setup list of objects.mk files > + ifdef PLATFORM > + platform-object-mks=$(shell if [ -d $(platform_src_dir)/ ]; then find $(platform_src_dir) -iname "objects.mk" | sort -r; fi) > +@@ -157,7 +160,11 @@ ifndef PLATFORM_RISCV_ABI > + endif > + ifndef PLATFORM_RISCV_ISA > + ifneq ($(PLATFORM_RISCV_TOOLCHAIN_DEFAULT), 1) > +- PLATFORM_RISCV_ISA = rv$(PLATFORM_RISCV_XLEN)imafdc > ++ ifeq ($(CC_SUPPORT_ZICSR_ZIFENCEI), y) > ++ PLATFORM_RISCV_ISA = rv$(PLATFORM_RISCV_XLEN)imafdc_zicsr_zifencei > ++ else > ++ PLATFORM_RISCV_ISA = rv$(PLATFORM_RISCV_XLEN)imafdc > ++ endif > + else > + PLATFORM_RISCV_ISA = $(OPENSBI_CC_ISA) > + endif > +-- > +2.35.1 > + > diff --git a/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb b/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb > index c25215be..f114cec9 100644 > --- a/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb > +++ b/meta-isar/recipes-bsp/opensbi/opensbi-sifive-fu540_0.9.bb > @@ -7,6 +7,7 @@ inherit dpkg > > SRC_URI = " \ > https://github.com/riscv/opensbi/archive/v${PV}.tar.gz;downloadfilename=opensbi-${PV}.tar.gz \ > + file://0001-Makefile-fix-build-with-binutils-2.38.patch \ > file://sifive-fu540-rules" > SRC_URI[sha256sum] = "60f995cb3cd03e3cf5e649194d3395d0fe67499fd960a36cf7058a4efde686f0" > Maybe it's better to update the opensbi revision then. Jan -- Siemens AG, Technology Competence Center Embedded Linux