From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7350220502645866496 Date: Mon, 25 Mar 2024 06:54:44 -0700 (PDT) From: Srinuvasan Arjunan To: isar-users Message-Id: <100dc56f-97eb-4be8-82e1-2ba250891434n@googlegroups.com> In-Reply-To: References: <20240325084904.2036784-1-srinuvasan.a@siemens.com> Subject: Re: [PATCH] wic: bootimg-efi-isar: use static method for _copy_additional_files MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_18020_1032482597.1711374884649" X-TUID: rSoqB8B7z56G ------=_Part_18020_1032482597.1711374884649 Content-Type: multipart/alternative; boundary="----=_Part_18021_1380005075.1711374884649" ------=_Part_18021_1380005075.1711374884649 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Monday, March 25, 2024 at 7:00:51=E2=80=AFPM UTC+5:30 Jan Kiszka wrote: On 25.03.24 09:49, srinuvasan.a via isar-users wrote:=20 > From: Srinuvasan A =20 >=20 > Presently we uses classmethod decorator for _copy_additional_files=20 > method, and actually this not needed becuase we are not accessing any=20 > class variable or method in this function.=20 >=20 > Change to static method for the below reason=20 > - We are performing the generic functionality=20 > - Moreover this should be initialized only once=20 >=20 > Signed-off-by: Srinuvasan A =20 > ---=20 > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 4 ++--=20 > 1 file changed, 2 insertions(+), 2 deletions(-)=20 >=20 > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py=20 b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py=20 > index 4bfb70a0..5fe9bcb0 100644=20 > --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py=20 > +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py=20 > @@ -40,8 +40,8 @@ class BootimgEFIPlugin(SourcePlugin):=20 >=20 > name =3D 'bootimg-efi-isar'=20 >=20 > - @classmethod=20 > - def _copy_additional_files(cls, hdddir, initrd, dtb):=20 > + @staticmethod=20 > + def _copy_additional_files(hdddir, initrd, dtb):=20 > bootimg_dir =3D get_bitbake_var("DEPLOY_DIR_IMAGE")=20 > if not bootimg_dir:=20 > raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")=20 This is not Isar-specific. Please address this in OE first. Sure, thanks.=20 Jan=20 --=20 Siemens AG, Technology=20 Linux Expert Center=20 ------=_Part_18021_1380005075.1711374884649 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Monday, March 25, 2024 at 7:00:51=E2= =80=AFPM UTC+5:30 Jan Kiszka wrote:
On 25.03.24 09:49, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuv...@s= iemens.com>
>=20
> Presently we uses classmethod decorator for _copy_additional_fil= es
> method, and actually this not needed becuase we are not accessin= g any
> class variable or method in this function.
>=20
> Change to static method for the below reason
> - We are performing the generic functionality
> - Moreover this should be initialized only once
>=20
> Signed-off-by: Srinuvasan A <sr= inuv...@siemens.com>
> ---
> meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 4 ++-= -
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isa= r.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
> index 4bfb70a0..5fe9bcb0 100644
> --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
> +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
> @@ -40,8 +40,8 @@ class BootimgEFIPlugin(SourcePlugin):
> =20
> name =3D 'bootimg-efi-isar'
> =20
> - @classmethod
> - def _copy_additional_files(cls, hdddir, initrd, dtb):
> + @staticmethod
> + def _copy_additional_files(hdddir, initrd, dtb):
> bootimg_dir =3D get_bitbake_var("DEPLOY_DIR_IMAGE")
> if not bootimg_dir:
> raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exi= ting")

This is not Isar-specific. Please address this in OE first.

=C2=A0 =C2=A0Sure, thanks.=C2=A0


Jan

--=20
Siemens AG, Technology
Linux Expert Center

------=_Part_18021_1380005075.1711374884649-- ------=_Part_18020_1032482597.1711374884649--