Re: [RFC PATCH 4/6] meta/class/image: Add do_isar task to trigger SDK rootfs creation.

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

On 06/14/2018 11:23 AM, Henning Schild wrote:
> Am Wed, 13 Jun 2018 15:58:27 +0200
> schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:
> 
>> User manually triggers creation of SDK root filesystem for his target
>> platform by launching the task `do_isar_sdk` for target image, f.e.
>> `bitbake -c do_isar_sdk
>> multiconfig:${MACHINE}-${DISTRO}:isar-image-base`.
>>
>> The resulting SDK rootfs is located under
>> `tmp/work/${DITSRO}-${DISTRO_ARCH}/sdkchroot/rootfs`. SDK rootfs
>> directory `/isar-apt` contains the copy of isar-apt repo with locally
>> prebuilt target debian packages. One may chroot to SDK and install
>> required target packages with the help of `apt-get install
>> <package_name>:<DISTRO_ARCH>` command.
>>
>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>> ---
>>   meta/classes/image.bbclass | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 4738cb8..dc7da2c 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -71,3 +71,11 @@ do_copy_boot_files() {
>>   addtask copy_boot_files before do_build after do_rootfs
>>   do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
>>   do_copy_boot_files[stamp-extra-info] = "${DISTRO}-${MACHINE}"
>> +
>> +do_isar_sdk() {
>> +}
>>
>> +
>> +do_isar_sdk[stamp-extra-info] = "${MACHINE}-${DISTRO}"
>> +do_isar_sdk[depends] = "sdkchroot:do_build"
>> +
>> +addtask isar_sdk after do_rootfs
> 
> Could you explain why sdkchroot is a recipe of its own and you are
> building that dependency chain. So why can sdkchroot:do_build not just
> be implemented in do_isar_sdk? The reasoning should probably be added
> to the commit message.

One of the initial ideas of adding such dependency to image class
is to make sure that target packages which user lists in IMAGE_INSTALL 
are already built.

So sdkchroot has two major dependencies

1) target rootfs (and prebuilt target packages)
This dependency is placed in meta/classes/image.bbclass:
addtask isar_sdk after do_rootfs

2) host's isar-bootstrap
This dependency is placed in meta/recipes-devtools/sdkchroot/sdkchroot.bb:

do_build[depends] = "isar-apt:do_cache_config isar-bootstrap-host:do_deploy"

As I mentioned before sdkchroot is very similar to buildchroot.

So such split between sdkchroot and image class seems to be natural.

Maxim.
-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov