From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6566568349648551936 X-Received: by 2002:a19:9850:: with SMTP id a77-v6mr94722lfe.15.1528976975739; Thu, 14 Jun 2018 04:49:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9c05:: with SMTP id s5-v6ls812434lji.15.gmail; Thu, 14 Jun 2018 04:49:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKeYud2DEF5Nj6IA+tLplnQ+wrvryfs+Rr2VWHsFSBCpuUF4TLTuKMNAj/1763dCxDNsKyf X-Received: by 2002:a2e:8889:: with SMTP id k9-v6mr99428lji.22.1528976975243; Thu, 14 Jun 2018 04:49:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528976975; cv=none; d=google.com; s=arc-20160816; b=gFlrM/56jRiDAUHRz8W0ubRiJLRXut65GeNfuyr9RapYAOEEYkqWaxoKm/g2J1GOPK U1x307+XrHnsnXR1XFZh7LD0a4w9mE1/LKm3SM6LRsN1bzXrsk7cOOG6IGkWnyLQk+Vt MSPEKLvUQ8NpWjOXI3Bsb9sKPv9zb2ZH5NSOCVtr0Ty++6rw5WxKww9htKLm1rIgYUxx MDWqLcIYK/uqQ1OX5sZJW+Sm8Ey+4aBBEWQWteRoHnq6NiBU4QKPWR7seN3KCQICyAsH t8RxjPYh2Sgd7FcO1MFbxZXFtS9Vq3roHCKCIpnas8ZnzjkwlqJIbhQFG85I7AVxgGNN h2ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject:arc-authentication-results; bh=rzcUwYebvcLfnDUMldXSxT9vySgl0oRj+wA0GS9G/eQ=; b=ojUwQDaZkL11UK/2Jsm7jYbNqABC8eO6HCNZbZOQpnJJcRnVef2Qi3Ds60J9wjLIgg LvhvSoLfgkU6Wdu2uMhNYTHbFDu+4ftwX/dF+ynXhxBOCFbN82mEdZ3qjYfuVkM0/2Om jXRjSRNzlSSwRxoEarcdygtudUlNVX0Gfn8Lr+OZYluz4Wu05HaLIdOpQvL17Nms9l4z 8AfspidAw6co7bwyzIMwIAsMPjNbxJMrpOVrjrEJjHVSu6Dr0b8PQJa521ekxTRkfYE2 RbmS3EOq8xVbeWvQ+i8B7NnbqXp0YpBQ7EzRr2y/zffh1JyA3fMvtszZ9tAC7Zu3g/7K rvFw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id u23-v6si107509lji.3.2018.06.14.04.49.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jun 2018 04:49:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w5EBnWYw001066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 14 Jun 2018 13:49:33 +0200 Subject: Re: [RFC PATCH 4/6] meta/class/image: Add do_isar task to trigger SDK rootfs creation. To: Henning Schild Cc: isar-users@googlegroups.com References: <20180613135829.3151-1-mosipov@ilbers.de> <20180613135829.3151-5-mosipov@ilbers.de> <20180614112301.6666f0c4@md1pvb1c.ad001.siemens.net> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <1025ec39-1e97-25eb-74be-db027f265e00@ilbers.de> Date: Thu, 14 Jun 2018 13:49:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180614112301.6666f0c4@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: x7BgxI3iYqQE On 06/14/2018 11:23 AM, Henning Schild wrote: > Am Wed, 13 Jun 2018 15:58:27 +0200 > schrieb "Maxim Yu. Osipov" : > >> User manually triggers creation of SDK root filesystem for his target >> platform by launching the task `do_isar_sdk` for target image, f.e. >> `bitbake -c do_isar_sdk >> multiconfig:${MACHINE}-${DISTRO}:isar-image-base`. >> >> The resulting SDK rootfs is located under >> `tmp/work/${DITSRO}-${DISTRO_ARCH}/sdkchroot/rootfs`. SDK rootfs >> directory `/isar-apt` contains the copy of isar-apt repo with locally >> prebuilt target debian packages. One may chroot to SDK and install >> required target packages with the help of `apt-get install >> :` command. >> >> Signed-off-by: Maxim Yu. Osipov >> --- >> meta/classes/image.bbclass | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 4738cb8..dc7da2c 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -71,3 +71,11 @@ do_copy_boot_files() { >> addtask copy_boot_files before do_build after do_rootfs >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" >> do_copy_boot_files[stamp-extra-info] = "${DISTRO}-${MACHINE}" >> + >> +do_isar_sdk() { >> +} >> >> + >> +do_isar_sdk[stamp-extra-info] = "${MACHINE}-${DISTRO}" >> +do_isar_sdk[depends] = "sdkchroot:do_build" >> + >> +addtask isar_sdk after do_rootfs > > Could you explain why sdkchroot is a recipe of its own and you are > building that dependency chain. So why can sdkchroot:do_build not just > be implemented in do_isar_sdk? The reasoning should probably be added > to the commit message. One of the initial ideas of adding such dependency to image class is to make sure that target packages which user lists in IMAGE_INSTALL are already built. So sdkchroot has two major dependencies 1) target rootfs (and prebuilt target packages) This dependency is placed in meta/classes/image.bbclass: addtask isar_sdk after do_rootfs 2) host's isar-bootstrap This dependency is placed in meta/recipes-devtools/sdkchroot/sdkchroot.bb: do_build[depends] = "isar-apt:do_cache_config isar-bootstrap-host:do_deploy" As I mentioned before sdkchroot is very similar to buildchroot. So such split between sdkchroot and image class seems to be natural. Maxim. -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov