Re: [PATCH v5 0/5] Provide infrastructure and examples for custom kernels and modules

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-15 12:24, Alexander Smirnov wrote:
> On 02/14/2018 12:13 PM, Jan Kiszka wrote:
>> This is now finally the promised patches to provide simple patterns for
>> building custom kernels for Isar images that replace the distro kernels.
>> It also provids the same pattern for custom out-of-tree kernel modules.
>>
>> Changes in v5:
>>   - dropped merged patches
>>   - reworked kernel packages naming and selection mechanism to use
>>     flavor/arch rather them overwriting upstream names
>>   - fixed rebuilds of the kernel (.version was causing problems)
>>   - moved kernel build into script - and switched back to include pattern
>>   - provided note on origin of exemplary defconfig
>>   - add KERNEL_DEFCONFIG variable
>>
> 
> Looks good to me, applied to next. Should I wait documentation for this
> feature?
> 
> One small issue: you use @XYZ@ pattern for substitution, while ##XYZ##
> is used in multistrap configs. I'm with unified style in Isar. I'd
> prefer your variant, so just as TODO for somebody - replace remaining
> ##XYZ## patterns in Isar to @XYZ@.

If the multistrap cases will go anyway, this consolidation would come
for free.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux