From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a1c:ac87:: with SMTP id v129mr5424591wme.72.1553512127329; Mon, 25 Mar 2019 04:08:47 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fc51:: with SMTP id e17ls3534000wrs.15.gmail; Mon, 25 Mar 2019 04:08:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/0HUQuYIlV2yh7jxgJ2taKUKmaM33u0RtMagyERzjWjHUEpTyrviKMWxXljUPf2c1EioG X-Received: by 2002:adf:9c91:: with SMTP id d17mr1690785wre.285.1553512126878; Mon, 25 Mar 2019 04:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553512126; cv=none; d=google.com; s=arc-20160816; b=s/becP7ByalRz3cGLHC3imirLxTFaz70lugYrrAjjvenXK7EG0aNSwWPg880jJorQn IYCxBO7OHWYkVsfAe96E9e1QGNhm3Ff1DV2D2+kBnmheaRbn/vPzQrZVzDMNZl3aJtTO CXLat9r9XwKDJSTJS+3DsncuhjuaZuhr9DiKYOQwm7Nb4H5OK25e3txB/G3QzChr01ZV WXVZayoa6xUV64supCSFRVfRLYwHB3t2ySMCoUN0HRON6XDRc46v5HGw1TKFNhTJ/lIm NisVFazSGAXSgoT88yNcaqrO9Y7Mouwrd8rnKH9uzWTd9/vBflq9aJ0cEHn5f0SGkbPT cL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject :dkim-signature; bh=oZuyrcHLUrWVXQ02nAYERpQtGp6mPDGbqg7OoL+FIZ0=; b=JwyiDJ/wqaMafH3VaHPyehvY/uXDUVX2j5TXMqhtjsO6Z3Tm2+KQKnue5PzW9kJqLp 4D/HGkLHA0/a9gSwkUqEJaxPufV02oI6NJAU4ONMI0r4PuhlJmOYXARYtqYHe516BMOr pTU4kufzRNF8ojeI4UxiEMELgYYVivtJOKeVoe636LjL1hBPhVTMH3PII4fGa12vZH8Q 1CZbeqY8/1ghUpEJ2ydaGUufGvAMm46Q3+KbVBp68jb/SZ2LabmzXVKAyR2fMpESNNpg AOkl89To9js9Za8Un4W/qde8Iigbwnr2t7e7lxCOUK/+QcFLTOJlCLs4w1kIxpnaiR0a q0tg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cMLUr6zB; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.14]) by gmr-mx.google.com with ESMTPS id n5si932098wrj.0.2019.03.25.04.08.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 04:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) client-ip=212.227.15.14; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=cMLUr6zB; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.14 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553512126; bh=oZuyrcHLUrWVXQ02nAYERpQtGp6mPDGbqg7OoL+FIZ0=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=cMLUr6zBYgqXHewi8dkhSAo38mT0gfxu3R/6P8giS81ddc/Y60PIjUE7AOyJIgP93 aFb8pghJO55SW1A5zgwcbmPTZKaCyP9ATGejth2hEZnggj9OYbs+erS6f3yZNg5/xd XknysisHj7NnNlPFs4ybwEt3RPK2rLtqKMWV3GZE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LfAbI-1gbCMg02NU-00oqAe; Mon, 25 Mar 2019 12:08:46 +0100 Subject: Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch From: Jan Kiszka To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190214112850.12469-1-claudius.heine.ext@siemens.com> <20190214112850.12469-2-claudius.heine.ext@siemens.com> <56f05745-cd50-e946-e189-22402b7c4d63@web.de> <15145951-bf01-4a34-7f55-0493573769f2@web.de> <038e94f9-547a-9704-3221-2956b6cde69a@siemens.com> <57786819-c53a-98ed-91f3-0c9adf2ddb7f@web.de> Message-ID: <10421a3e-15cf-df0a-12a7-485db9ee10db@web.de> Date: Mon, 25 Mar 2019 12:08:45 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <57786819-c53a-98ed-91f3-0c9adf2ddb7f@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:RlBk/10KoJvXI8BpK//gM3y9L+qwfu99NbDxoWa3M9GtdSmeHAS zUhdjNdkB5bKXiyut1LCG7Tbh3VBBlWU5SbUTWRZSTNsUjsIlDj3NBoFsdVkG9gRWnnKBke D13061ckrGbIQ07/gEDTp4ZKg2AVwDBKOdiFtV3df0krDPwJAScAUcEIaIe1snFxpM0C4Ix bAIyNGTB4n55egwE9aTAA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MHHdIfRu7vg=:3M8kk0XuKv+JFZHpBPhLMk ctb2uPWq6OdCn12nYb8kpHFzYg7LIUZ30oMOiJy8Hgjg0hNdT9bl3r3INdwUHlsnq+RC3JuSm i5bo06zkrj1y/+PCWsuczRu5Eh8QhWAgvnXb8ogh2r6PQ2Hq2SCEAOpl36I6WiSZN5gqdE79+ X/J1ht/VpahLngFTNu5jukU51r+lpAKnPe9vXrlKSQ/N7PcH7meyxrPl4Kh71BNymy4LsXozH cC4yK+4O6bCKNrA8/+BwJ5j9nV2DYSXW6RAUU65aychf7HRCGzhTlymx/U6vlSvuGsUTC5ktg tva7uRDJI24vCn0o+s/yWhAcBkm2uVn0RauczoKDMKtJS5NxkLfvYU0QuV9mXrclRyspTMzYD ZIL9aLxRpKBmvjwwI8neQDFNxOX2DjiHOs/ZDZzp5c5HjjztVT5KgknNTORHZVbKZLSV/P6Y9 E18xgtYLcMSq670R6k7fcVuttV3zf1qzuYppAfmab+XbKGaMOkGbCIdx6ZYULUnDOWEJKGswl 6vAr6Z1Zim+/P011jBxGQjerRo52/WtTRHhoAOVnn7Y4WC90RHzJ2xxJEbNmwBWTPrnOGOdG7 FuXqBSMLIJTtI4hUpJIaz/tA4G1Jvzb796ueCfqn1ZhAh+EvJIpRBH6QUGstE9q4C3UM6emeV G7dk7226nFMhAlja48neSFdbx6wKGYyn3l51l208RHq8QsXTdzshLNh3W5ehv1p2jlYPV0+69 SOOA/xpcqbJJbBQhJ51g228OQceg+mYUeZ6VlA8NdQkelGbXORz1lJJ6v4bOpj0WcLsLQjpM/ LO36z8WaRcn7Uum7xqkA93AEJM5IOZ/Qo+dN6tEUtT7ZeDCd+yzkjhYiQwo5qXKDWbT1STxeF CGozr7TQjlkRCK+MpXxpPJOAbAMXJkpXdAdVQ/o48HHPmQHl2lL3aH7S1aTYx04B+3LG1DAIi y+Ean1KvREg== X-TUID: 9PX7oEY6gIpc On 25.03.19 09:44, Jan Kiszka wrote: > On 25.03.19 09:21, Claudius Heine wrote: >> Hi, >> >> On 25/03/2019 09.13, Jan Kiszka wrote: >>> On 25.03.19 08:53, Claudius Heine wrote: >>>> Hi Jan, >>>> >>>> On Sun, 2019-03-24 at 19:28 +0100, Jan Kiszka wrote: >>>>> On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote: >>>>>> From: Claudius Heine >>>>>> >>>>>> The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS. >>>>>> TEMPLATE_FILES is a list of files that should be processed in the >>>>>> `do_transform_template` task and TEMPLATE_VARS is a list of bitbake >>>>>> variable names that should be substituted in the template file. >>>>>> >>>>> >>>>> Bad news: This patch introduced a regression into the release (sorry= , >>>>> didn't >>>>> manage to test earlier). It destroys the reuse of self-built >>>>> identical packages >>>>> for different targets. Namely, jailhouse-images now tries to build >>>>> the shared >>>>> (per arch) kernel multiple times, and that fails miserably because >>>>> there is a >>>>> common folder for all of them. The issue disappears when removing th= e >>>>> do_transform_template task from the chain. >>>> >>>> Hmm, have you looked at the resulting 'TEMPLATE_VARS' variable? All >>>> variables in there need to be the same in order for it to have the sa= me >>>> stamp. If that is not the case then maybe overwriting it instead of >>>> appending it might work. >>>> >>>> These are the defaults set in 'template.bbclass': >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 TEMPLATE_VARS ?=3D "PN PV DESCRIPTION HOMEPA= GE MAINTAINER KERNEL_NAME >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MACHINE DI= STRO_ARCH" >>>> >>>> If I understand you correctly then your recipe should not be dependan= t >>>> on the MACHINE? So either remove MACHINE 'TEMPLATE_VARS_remove =3D >>>> "MACHINE"' or just set a 'TEMPLATE_VARS' that you really need in your >>>> template files. >>> >>> OK, might be that "MACHINE" is the problem here. Will check. If that t= urns out >>> to be true, it is highly counter-intuitive and should be fixed, at lea= st for >>> nop-jobs. >> >> Well sane defaults is always WIP :) >> >> I think I added this because the u-boot recipe in meta needed it. It se= ems >> that u-boot is special here. > > OK, clearing TEMPLATE_VARS seems to address the issue (still seeing othe= rs, but > that might be a local topic). > > Given these side effects, I'm in favor of removing MACHINE from the defa= ults. > The other vars look harmless, at least so far. > Actually, we have to: Even standard packages like isar-cfg-localepurge sta= rt to fail building when there are multiple targets of the same arch pulling the= m in. They share the same workdir, thus break when trying to be built multiple t= imes. Will send a patch. Jan