[PATCH] fix: remove unsigned example module before including the signed one

[PATCH] fix: remove unsigned example module before including the signed one

[Pingfang Liao]

We need remove unsigned exmple module firstly, because signed and unsigned
exmaple module will install example-module.ko to the same path, which will
lead to dpkg error.
---
 meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
index 19a105e..ca76685 100644
--- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
+++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
@@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
 
 # include public keys
 IMAGE_INSTALL += "sb-mok-public"
-# include signed example module
+# remove unsigned example module and include signed example module
+IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" 
 IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
 
 # add MOK utilities to insert MOK into EFI
-- 
2.20.1

Re: [PATCH] fix: remove unsigned example module before including the signed one

[MOESSBAUER, Felix]

On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote:
> We need remove unsigned exmple module firstly, because signed and
> unsigned
> exmaple module will install example-module.ko to the same path, which
> will
> lead to dpkg error.
> ---
>  meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> index 19a105e..ca76685 100644
> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
>  
>  # include public keys
>  IMAGE_INSTALL += "sb-mok-public"
> -# include signed example module
> +# remove unsigned example module and include signed example module
> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" 

Good catch, thanks.

ACK!

>  IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
>  
>  # add MOK utilities to insert MOK into EFI

Re: [PATCH] fix: remove unsigned example module before including the signed one

[MOESSBAUER, Felix]

On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote:
> We need remove unsigned exmple module firstly, because signed and
> unsigned
> exmaple module will install example-module.ko to the same path, which
> will
> lead to dpkg error.

Please add the signed-off line to the commit message (git commit
--signoff). For details, see https://wiki.linuxfoundation.org/dco

Felix

> ---
>  meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> index 19a105e..ca76685 100644
> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
>  
>  # include public keys
>  IMAGE_INSTALL += "sb-mok-public"
> -# include signed example module
> +# remove unsigned example module and include signed example module
> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" 
>  IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
>  
>  # add MOK utilities to insert MOK into EFI

Re: [PATCH] fix: remove unsigned example module before including the signed one

[Jan Kiszka]

On 25.05.23 11:56, 'MOESSBAUER, Felix' via isar-users wrote:
> On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote:
>> We need remove unsigned exmple module firstly, because signed and
>> unsigned
>> exmaple module will install example-module.ko to the same path, which
>> will
>> lead to dpkg error.
> 
> Please add the signed-off line to the commit message (git commit
> --signoff). For details, see https://wiki.linuxfoundation.org/dco
> 

And fix the "exm[a]ple" typos at this chance. ;)

Thanks,
Jan

> Felix
> 
>> ---
>>  meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> index 19a105e..ca76685 100644
>> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
>>  
>>  # include public keys
>>  IMAGE_INSTALL += "sb-mok-public"
>> -# include signed example module
>> +# remove unsigned example module and include signed example module
>> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}" 
>>  IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
>>  
>>  # add MOK utilities to insert MOK into EFI
> 

-- 
Siemens AG, Technology
Competence Center Embedded Linux

RE: [PATCH] fix: remove unsigned example module before including the signed one

[Liao, Pingfang (Marshell)]

Thanks for the comments, will update the patch.

-----Original Message-----
From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> 
Sent: Friday, May 26, 2023 12:24 AM
To: MOESSBAUER, Felix (T CED INW-CN) <felix.moessbauer@siemens.com>; isar-users@googlegroups.com; pingfang.liao@outlook.com
Cc: Liao, Pingfang (Marshell) (DI FA CTR SVC&AI CN) <Pingfang.Liao@siemens.com>
Subject: Re: [PATCH] fix: remove unsigned example module before including the signed one

On 25.05.23 11:56, 'MOESSBAUER, Felix' via isar-users wrote:
> On Thu, 2023-05-25 at 03:06 -0400, Pingfang Liao wrote:
>> We need remove unsigned exmple module firstly, because signed and 
>> unsigned exmaple module will install example-module.ko to the same 
>> path, which will lead to dpkg error.
> 
> Please add the signed-off line to the commit message (git commit 
> --signoff). For details, see 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki
> .linuxfoundation.org%2Fdco&data=05%7C01%7CPingfang.Liao%40ad011.siemen
> s.com%7C4cc19e2489704d47add908db5d3c78b1%7C38ae3bcd95794fd4addab42e149
> 5d55a%7C1%7C0%7C638206286528707710%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7
> C&sdata=QNlWSFHmjvtEnaQAkRdUn8wF9DH6%2BDgHXqFyNwNg9T4%3D&reserved=0
> 

And fix the "exm[a]ple" typos at this chance. ;)

Thanks,
Jan

> Felix
> 
>> ---
>>  meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> index 19a105e..ca76685 100644
>> --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf
>> @@ -4,7 +4,8 @@ DISTRO ?= "debian-bullseye"
>>  
>>  # include public keys
>>  IMAGE_INSTALL += "sb-mok-public"
>> -# include signed example module
>> +# remove unsigned example module and include signed example module 
>> +IMAGE_INSTALL:remove = "example-module-${KERNEL_NAME}"
>>  IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}"
>>  
>>  # add MOK utilities to insert MOK into EFI
> 

--
Siemens AG, Technology
Competence Center Embedded Linux