public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] debian-configscript.sh: Remove creation of console device
@ 2019-04-01 14:57 Maxim Yu. Osipov
  2019-04-02 14:54 ` Maxim Yu. Osipov
  0 siblings, 1 reply; 2+ messages in thread
From: Maxim Yu. Osipov @ 2019-04-01 14:57 UTC (permalink / raw)
  To: isar-users

Creation of console device was introduced by commit e7e5915
with the  comment "on some hosts, ISAR running in QEMU fails with error:
/init: 326: /init: cannot open /root/dev/console: No such file"

The mentioned problem is not reproduced anymore on supported hosts,
moreover, it was reported that such creation of /dev/console
caused races.

Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
---
 meta/conf/distro/debian-configscript.sh | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/meta/conf/distro/debian-configscript.sh b/meta/conf/distro/debian-configscript.sh
index bcd5507..d66fa03 100755
--- a/meta/conf/distro/debian-configscript.sh
+++ b/meta/conf/distro/debian-configscript.sh
@@ -8,11 +8,6 @@ set -e
 readonly MACHINE_SERIAL="$1"
 readonly BAUDRATE_TTY="$2"
 
-# Create console device
-if [ ! -e /dev/console ]; then
-     mknod /dev/console c 5 1
-fi
-
 # Enable tty conditionally, systemd does not have the file but its own magic
 if [ -f /etc/inittab ]; then
     echo "T0:23:respawn:/sbin/getty -L $MACHINE_SERIAL $BAUDRATE_TTY vt100" \
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] debian-configscript.sh: Remove creation of console device
  2019-04-01 14:57 [PATCH] debian-configscript.sh: Remove creation of console device Maxim Yu. Osipov
@ 2019-04-02 14:54 ` Maxim Yu. Osipov
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Yu. Osipov @ 2019-04-02 14:54 UTC (permalink / raw)
  To: isar-users

On 4/1/19 4:57 PM, Maxim Yu. Osipov wrote:
> Creation of console device was introduced by commit e7e5915
> with the  comment "on some hosts, ISAR running in QEMU fails with error:
> /init: 326: /init: cannot open /root/dev/console: No such file"
> 
> The mentioned problem is not reproduced anymore on supported hosts,
> moreover, it was reported that such creation of /dev/console
> caused races.

Applied to the 'next'.


> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> ---
>   meta/conf/distro/debian-configscript.sh | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/meta/conf/distro/debian-configscript.sh b/meta/conf/distro/debian-configscript.sh
> index bcd5507..d66fa03 100755
> --- a/meta/conf/distro/debian-configscript.sh
> +++ b/meta/conf/distro/debian-configscript.sh
> @@ -8,11 +8,6 @@ set -e
>   readonly MACHINE_SERIAL="$1"
>   readonly BAUDRATE_TTY="$2"
>   
> -# Create console device
> -if [ ! -e /dev/console ]; then
> -     mknod /dev/console c 5 1
> -fi
> -
>   # Enable tty conditionally, systemd does not have the file but its own magic
>   if [ -f /etc/inittab ]; then
>       echo "T0:23:respawn:/sbin/getty -L $MACHINE_SERIAL $BAUDRATE_TTY vt100" \
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-02 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 14:57 [PATCH] debian-configscript.sh: Remove creation of console device Maxim Yu. Osipov
2019-04-02 14:54 ` Maxim Yu. Osipov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox